From: Marius Bakke <mbakke@fastmail.com>
To: Guillaume Le Vaillant <glv@posteo.net>
Cc: 37825@debbugs.gnu.org
Subject: [bug#37825] [PATCH] gnu: bitcoin-abc: Update to 0.20.4.
Date: Sun, 03 Nov 2019 18:11:50 +0100 [thread overview]
Message-ID: <87r22oopex.fsf@devup.no> (raw)
In-Reply-To: <87tv7nlx1q.fsf@yamatai>
[-- Attachment #1: Type: text/plain, Size: 1687 bytes --]
Guillaume Le Vaillant <glv@posteo.net> writes:
> Marius Bakke skribis:
>
>> Guillaume Le Vaillant <glv@posteo.net> writes:
>>
>>> * gnu/packages/finance.scm (bitcoin-abc): Update to 0.20.4.
>>> [source]: Fix uri.
>>> [inputs]: Use bdb-5.3 (bdb-4.8 is not supported).
>>> [arguments]: Add 'fix-tests' phase.
>>
>> [...]
>>
>>> + (arguments
>>> + (substitute-keyword-arguments (package-arguments bitcoin-core)
>>> + ((#:phases phases)
>>> + `(modify-phases ,phases
>>> + (add-after 'unpack 'fix-tests
>>> + ;; Disable 'check-devtools' test which tries to run a
>>> + ;; python script that doesn't exist.
>>> + (lambda _
>>> + (substitute* "Makefile.in"
>>> + (("^check-local: check-devtools")
>>> + "check-local:"))
>>> + #t))))))
>>
>> Do you know why this script is not distributed? Should we provide it,
>> or was it a packaging mistake upstream?
>>
>> In any case I pushed this patch in
>> 28d46d9d4317180b348ad5baeddad8ef25ed430a. Thank you!
>
> I'm not sure if it's a packaging mistake or a makefile mistake (if these
> tests are not supposed to be run on a release version). They are tests
> to check that some development tools work correctly (e.g. tools to
> generate a header file which is included in the release tarball, to
> update the copyright years in the headers, etc).
I see, thanks for the explanation. Perhaps we are simply using the
wrong Makefile target? By default gnu-build-system runs 'make check' in
the 'check' phase: some packages use 'make test' or 'make ci' instead.
Something to look out for in the next version. :-)
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]
prev parent reply other threads:[~2019-11-03 17:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-19 18:48 [bug#37825] [PATCH] gnu: bitcoin-abc: Update to 0.20.4 Guillaume Le Vaillant
2019-10-31 23:23 ` bug#37825: " Marius Bakke
2019-11-01 10:18 ` [bug#37825] " Guillaume Le Vaillant
2019-11-03 17:11 ` Marius Bakke [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r22oopex.fsf@devup.no \
--to=mbakke@fastmail.com \
--cc=37825@debbugs.gnu.org \
--cc=glv@posteo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.