all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: Lars-Dominik Braun <ldb@leibniz-psychology.org>
Cc: Ricardo Wurmus <rekado@elephly.net>, 38576@debbugs.gnu.org
Subject: [bug#38576] [PATCH] gnu: r-irkernel: Fix R kernel loading
Date: Thu, 19 Dec 2019 23:47:33 +0100	[thread overview]
Message-ID: <87r210j5kq.fsf@gnu.org> (raw)
In-Reply-To: <20191212100452.GE22717@zpidnp36> (Lars-Dominik Braun's message of "Thu, 12 Dec 2019 11:04:52 +0100")

Hello,

Lars-Dominik Braun <ldb@leibniz-psychology.org> skribis:

>> This part looks fine to me, though I wonder if that’s what users of this
>> package would expect.  Is there an expectation that the effective R is
>> defined by the environment?  Or would that not work anyway?
> it’s what python-ipykernel does – without explanation though. I’m not an R
> expert, so I’m unsure whether any R installation from the environment (which
> could be user-installed in $HOME) would be able to load this plugin or just the
> one it was “built” for. This change assumes the latter.
>
>> 
>> > @@ -12423,6 +12429,8 @@ running IRkernel session.")
>> >         ("r-evaluate" ,r-evaluate)
>> >         ("r-irdisplay" ,r-irdisplay)
>> >         ("r-jsonlite" ,r-jsonlite)
>> > +       ;; sets R_LIBS_SITE, so R can actually find this package (IRkernel)
>> > +       ("r-minimal" ,r-minimal)
>> >         ("r-pbdzmq" ,r-pbdzmq)
>> >         ("r-repr" ,r-repr)
>> >         ("r-uuid" ,r-uuid)))
>> 
>> This doesn’t look right to me.  It seems wrong for any R package to
>> propagate R itself.  The R_LIBS_SITE variable is “attached” to
>> “r-minimal”, so when that is installed R will find the r-irkernel
>> package.  Am I missing something?
> If r-minimal is not installed, the kernel will simply not work and thus
> render this package useless. That’s why I would consider it a dependency.

An argument in favor of the status quo would be that it allows users to
choose between ‘r’ and ‘r-minimal’.  Is that a compelling argument?

It may be more important for ‘r-irkernel’ to work out of the box, like
you did.

However, if we go that route, we should arrange to not propagate
‘r-minimal’ (it’s intrusive) and instead have ‘kernel.json’ do the right
thing.

How does that sound?

Thanks,
Ludo’.

  parent reply	other threads:[~2019-12-19 22:48 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-12  7:46 [bug#38576] [PATCH] gnu: r-irkernel: Fix R kernel loading Lars-Dominik Braun
2019-12-12  9:41 ` Ricardo Wurmus
2019-12-12 10:04   ` Lars-Dominik Braun
2019-12-12 19:13     ` zimoun
     [not found]       ` <20191213073056.GG22717@zpidnp36>
     [not found]         ` <CAJ3okZ3TKG4K3ZE2hXGo6GXGUTC+xzKrd9vAzk8skJaLz3QPtQ@mail.gmail.com>
2019-12-16  7:53           ` Package runtime dependencies (see bug#38576) Lars-Dominik Braun
2019-12-19 22:47     ` Ludovic Courtès [this message]
2020-01-02  7:35       ` [bug#38576] [PATCH] gnu: r-irkernel: Fix R kernel loading Lars-Dominik Braun
2020-01-02 11:43         ` Ludovic Courtès
2020-01-03 15:12           ` bug#38576: " Ludovic Courtès
2020-01-06 18:14           ` [bug#38576] " zimoun
2020-01-07 21:02           ` Roel Janssen
2020-01-07 23:01             ` Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87r210j5kq.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=38576@debbugs.gnu.org \
    --cc=ldb@leibniz-psychology.org \
    --cc=rekado@elephly.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.