From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:58617) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iqQW3-00061I-Qm for guix-patches@gnu.org; Sat, 11 Jan 2020 18:50:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iqQW2-00051L-KD for guix-patches@gnu.org; Sat, 11 Jan 2020 18:50:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:50893) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iqQW2-0004zj-AW for guix-patches@gnu.org; Sat, 11 Jan 2020 18:50:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iqQW2-00005d-6V for guix-patches@gnu.org; Sat, 11 Jan 2020 18:50:02 -0500 Subject: [bug#39053] [PATCH] Add pulseaudio configuration and fix volume bugs Resent-Message-ID: From: Marius Bakke In-Reply-To: References: <20200109135746.1993-1-leo.prikler@student.tugraz.at> <87ftglzz3l.fsf@devup.no> Date: Sun, 12 Jan 2020 00:49:00 +0100 Message-ID: <87r205y2oj.fsf@devup.no> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Leo Prikler , 39053-done@debbugs.gnu.org --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Leo Prikler writes: > Am Samstag, den 11.01.2020, 18:23 +0100 schrieb Marius Bakke: >> Leo Prikler writes: >>=20 >> > This series of patches adds a configuration type for pulseaudio and >> > also fixes >> > a bug, where various applications would inadvertently max out the >> > system volume >> > (see e.g. #38172). >>=20 >> Thanks! I've pushed the patches with mentioned tweaks in >> 2c7511fb6..71e33e32f. > Thanks! Also, I'm sorry about accidentally opening like 10 bugs due to > my misconfiguration there. I only noticed after the fact, that merely > CC'ing the original bug does nothing, when the mail is still sent to > guix-patches as well. I've learned my lesson and will be more careful > in the future. Right, no worries! > I do still have some open questions, though. >> > +In addition to the above, @code{default-script-file} will be set to >> > the >> > +value of @code{script-file}. By default, @var{flat-volumes} is >> > set >> > to >> > +``no'', so as to avoid bugs related to this feature. >> >=20 >> The first sentence of this paragraph is obsolete, no? The second is >> rather vague, so I opted to remove the whole thing. Let me know if >> you >> think something should be added! > I'm not quite sure about the first sentence. While everyone can read > the code and the output files produced from it, I think we should > document, that we actually always insert this line into > @file{daemon.conf}. > For instance, if you don't supply your own @file{default.pa}, the first > line of @file{daemon.conf} will be > --8<---------------cut here---------------start------------->8--- > default-script-file =3D /gnu/store/-pulseaudio- > /etc/pulse/default.pa > --8<---------------cut here---------------end--------------->8--- > What are your thoughts on this? Oh, right. I suppose that can be surprising. Would you like to resubmit a documentation update? I wonder if we could use the flunking new 'this-record', and refer to the SCRIPT-FILE directly in the default parameter list. But that's probably overkill for this instance. :-) >> I added a (default: ...) on these two and removed the related >> sentences. > I was hesitant to do that due to the line limits. Do those not count > for documentation or are such exceptions allowed? Not sure what/if there are line length limits on guix.texi, but 95 characters should be okay for one-off instances like these. I suppose we could escape a line break if it breaks someones workflow. > Thanks again for your help and also thanks for your feedback. Thanks! --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAl4aXu0ACgkQoqBt8qM6 VPpavQgAyWJU6ushGNQ+c70cK74zPQXpMlFCGINPAwzp7/0lXoMZbncygM+Jq6Qj 1/3lX+BJP3P9cHKBjRVV2PcgPLNuAQdkqeHLUBJjicbXNl48tIs3bsHr/pGMfq8/ gUArrzuW/99aOitcv8MpeCYJ25B8eU3ymER1XVoCBroKacnHi1upCC34C40wl6Os mAY0KeUWtyLapIHFStlERgPY+21FVMyPCS2t77nEzq9ag0B+sMbjfUHvD4W2vrVE +bsQUg1zV4gHX42b8AB0y3E39JnUOTJKYRyzPZW0MlyH8blrYzGZsegp4791p/lN MxojRaJCWkSoZomiqVtzpr1wGWaK+g== =0ZM+ -----END PGP SIGNATURE----- --=-=-=--