From: "Ludovic Courtès" <ludo@gnu.org>
To: guix-devel@gnu.org, Tobias Geerinckx-Rice <me@tobias.gr>
Subject: Re: 13/15: gnu: libreoffice: Fix ‘soffice’ in a pure environment.
Date: Sat, 22 Feb 2020 15:14:08 +0100 [thread overview]
Message-ID: <87r1ymyaj3.fsf@gnu.org> (raw)
In-Reply-To: <20200221173946.F136121233@vcs0.savannah.gnu.org> (guix-commits@gnu.org's message of "Fri, 21 Feb 2020 12:39:46 -0500 (EST)")
Hi!
guix-commits@gnu.org skribis:
> commit d5f344c987c8cc7b597e938c22e02edf1c4335f3
> Author: Tobias Geerinckx-Rice <me@tobias.gr>
> AuthorDate: Fri Feb 21 05:19:27 2020 +0100
>
> gnu: libreoffice: Fix ‘soffice’ in a pure environment.
>
> * gnu/packages/libreoffice.scm (libreoffice)[arguments]: Refer to grep
> and coreutils by absolute file name in the soffice launcher script.
[...]
> + ;; Use store references for strictly necessary commands,
> + ;; but not for optional tools like ‘gdb’ and ‘valgrind’.
> + (for-each (lambda (command)
> + (substitute* "desktop/scripts/soffice.sh"
> + (((format #f"~a " command))
> + (format #f "~a " (which command)))))
> + (list "dirname" "grep" "uname"))
I strongly encourage using literal strings as patterns, it’s more
robust. In this case, you could replace the ‘for-each’ expression with
something like (untested):
(substitute* "desktop/scripts/soffice.sh"
(("\\<(dirname|grep|uname)\\>" _ cmomand)
(which command)))
WDYT?
Ludo’.
next parent reply other threads:[~2020-02-22 14:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200221173940.26669.60790@vcs0.savannah.gnu.org>
[not found] ` <20200221173946.F136121233@vcs0.savannah.gnu.org>
2020-02-22 14:14 ` Ludovic Courtès [this message]
2020-02-22 18:19 ` 13/15: gnu: libreoffice: Fix ‘soffice’ in a pure environment Tobias Geerinckx-Rice
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r1ymyaj3.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=guix-devel@gnu.org \
--cc=me@tobias.gr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.