From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mathieu Othacehe Subject: Re: Cross-compilation broken on canonical packages. Date: Fri, 06 Mar 2020 10:19:30 +0100 Message-ID: <87r1y5et7h.fsf@gmail.com> References: <878snff7pv.fsf@gmail.com> <877e2zf7kv.fsf@gmail.com> <871rt0ntvy.fsf@gnu.org> <87fthc9vav.fsf@gmail.com> <87y2ut645u.fsf@gnu.org> <87tv5gbz0o.fsf@gmail.com> <87blrlu3zv.fsf@gnu.org> <877e29v7qu.fsf@gmail.com> <87tv5cwxv1.fsf@gmail.com> <87pnelmg5e.fsf@gmail.com> <878sl943uz.fsf@gnu.org> <8736bg5coz.fsf@gmail.com> <87r1ykj776.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:470:142:3::10]:37936) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jA98p-0003LM-6c for guix-devel@gnu.org; Fri, 06 Mar 2020 04:19:36 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jA98o-0003nV-7P for guix-devel@gnu.org; Fri, 06 Mar 2020 04:19:35 -0500 In-reply-to: <87r1ykj776.fsf@gnu.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane-mx.org@gnu.org Sender: "Guix-devel" To: Ludovic =?utf-8?Q?Court=C3=A8s?= Cc: guix-devel@gnu.org Hey Ludo, > Do we need to do it for =E2=80=98lower-object=E2=80=99? I think that one= is (almost) > always called from a gexp compiler where it=E2=80=99s explicitly passed = =E2=80=98system=E2=80=99 > and =E2=80=98target=E2=80=99. Yes because of lower-object call in "system-derivation" procedure of (gnu services). > Also, a test or two would be welcome as it=E2=80=99s easy to break it wit= hout > noticing. > > Otherwise LGTM, thank you, and sorry for the delay! Pushed with a few tests on core-updates, thanks for reviewing! Mathieu