From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:42100) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jC27X-0000er-HJ for guix-patches@gnu.org; Wed, 11 Mar 2020 10:14:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jC27W-0005zH-Bo for guix-patches@gnu.org; Wed, 11 Mar 2020 10:14:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:49312) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jC27W-0005zD-8H for guix-patches@gnu.org; Wed, 11 Mar 2020 10:14:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jC27W-00067E-4M for guix-patches@gnu.org; Wed, 11 Mar 2020 10:14:02 -0400 Subject: [bug#39943] [PATCH v2 4/4] gnu: Add hyperledger-iroha. Resent-Message-ID: From: Pierre Neidhardt In-Reply-To: <20200310083105.21013-5-efraim@flashner.co.il> References: <20200310083105.21013-1-efraim@flashner.co.il> <20200310083105.21013-5-efraim@flashner.co.il> Date: Wed, 11 Mar 2020 15:13:25 +0100 Message-ID: <87r1xz2d4q.fsf@ambrevar.xyz> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Efraim Flashner , 39943@debbugs.gnu.org --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable I've tested it and run the example here https://iroha.readthedocs.io/en/latest/getting_started/cli-guide.html It works! Patch looks good, feel free to merge. A few comments below: > + (snippet > + '(begin > + ;; Backport unversioned fmt dependency: > + (substitute* "libs/logger/logger.hpp" > + (("fmt::v5") "fmt")) > + #t)))) Mention the commit you've sent me and that this should be removed on next update. > + (build-system cmake-build-system) > + (arguments > + `(#:configure-flags > + '("-DTESTING=3DOFF" > + ; Don't install the shared libraries of the dependencies: > + "-DENABLE_LIBS_PACKAGING=3DOFF") > + #:tests? #f Explain why the tests must be disabled. > + #:test-target "." Why setting the test-target if you are not running it? > + #:phases > + (modify-phases %standard-phases > + (add-after 'unpack 'change-compilation-flags > + (lambda _ > + (substitute* "cmake/functions.cmake" > + (("-Werror") "")) > + #t))))) Why do you need to do this? > + ;; See https://iroha.readthedocs.io/en/latest/build/index.html. > + (native-inputs > + `(("googletest" ,googletest))) > + (inputs > + `(("boost" ,boost-1.69) > + ("fmt" ,fmt) > + ("gflags" ,gflags) > + ("grpc" ,grpc) > + ("hyperledger-iroha-ed25519" ,hyperledger-iroha-ed25519) > + ("postgresql" ,postgresql) > + ("protobuf" ,protobuf) > + ("rapidjson" ,rapidjson) > + ("rxcpp" ,rxcpp) > + ("soci" ,soci) > + ("spdlog" ,spdlog) > + ("tbb" ,tbb))) > + (synopsis "Simple, decentralized ledger") > + (description "Iroha is a distributed ledger technology (DLT). Iroha = has Double spacing. Thanks! Cheers! =2D-=20 Pierre Neidhardt https://ambrevar.xyz/ --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEUPM+LlsMPZAEJKvom9z0l6S7zH8FAl5o8gUACgkQm9z0l6S7 zH/+Ngf/bBRW/d8gKGVwxx4URNaWz9S8p2rfBnanOY0GjPibBNIlNyCpnSqvhFKl AZX5HuGYRjRc0xZy5JsG6DhPGVYVtKXgMf5nEFKVuEOJb3rZUj3cf3GlHHUg7EO3 9k9f8YsZhu5o7olhWjlaciYWR9Hb83f4jaiaT8+hgrF+iZsc/WFbxpP+o5UJqA+Z I3AkuxCg2DSXBjBsSipHE+rEVT/1rlS6EAQVw7iSRj2pTheC67jDOb+a+0GXUtKa a8jQpYJoUpkEtdxby5W1+hmS07YfoLOSosfWbkCP9fOTtsRZw7HqSbeMk8leWB1m lYJZ9ikK3VNqcgKGR6EZPg9toVtuzw== =ukCy -----END PGP SIGNATURE----- --=-=-=--