From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= Subject: Re: [EXTERNAL]Re: Modifying squashfs usage for `guix pack` for supporting singularity Date: Fri, 13 Mar 2020 17:38:51 +0100 Message-ID: <87r1xwnrac.fsf@inria.fr> References: <87v9n9smtp.fsf@gnu.org> <87ftedr0hz.fsf@inria.fr> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:470:142:3::10]:38872) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jCnKr-0006ei-7d for guix-devel@gnu.org; Fri, 13 Mar 2020 12:38:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jCnKp-0001Av-Lb for guix-devel@gnu.org; Fri, 13 Mar 2020 12:38:56 -0400 Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]:21238) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jCnKp-00011U-Ah for guix-devel@gnu.org; Fri, 13 Mar 2020 12:38:55 -0400 In-Reply-To: (Josh Marshall's message of "Thu, 12 Mar 2020 17:58:59 +0000") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane-mx.org@gnu.org Sender: "Guix-devel" To: Josh Marshall Cc: "guix-devel@gnu.org" Hi Josh, Josh Marshall skribis: > While the images seem to work well in most cases, removing ways for bits = to change seems to be in the spirit of guix, and so the "-all-time" and "-m= kfs-time" options remove one source of change. Additionally, without the "= --no-recovery" an extra file is made which is not useful to the process, an= d for my manual testing seemed to cause write or permission issues which co= uld cause failures. Guix already handles the failure cases in mksquashfs w= hich the recovery file is for and so the redundant work is not helpful, can= cause problems, slows down the process, and requires more resources. Oh, I hadn=E2=80=99t understood that there were reproducibility issues with =E2=80=98guix pack -f squashfs=E2=80=99, sorry about that! Commits 24fb0dc0ab34ebb49509a3d5b4d84d8488670807 and b829864d747b3b24ef37cafe36e889527b060d4d implement what you suggest. I can confirm that now something like: guix pack -f squashfs sed --rounds=3D2 passes, which was not the case before. Thanks! > As for the information given by `guix pack --list-formats`, I'd change to= something like the following: > > ``` > tarball Self-contained tarball, ready to run directly on any Linu= x machine > squashfs Container suitable for Singularity 2.x and 3.x > OCI OCI compliant tarball ready for 'docker load' and usable by S= ingularity 3.x > sif Unsupported; container preferred by Singularity 3.x We cannot change the format name, for compatibility reasons, but I=E2=80=99= ll double-check that what =E2=80=98-f docker=E2=80=99 produces is indeed OCI, = and if so, add it to the description. > For more information, refer to https://guix.gnu.org/manual/en/html_node/I= nvoking-guix-pack.html I don=E2=80=99t think we=E2=80=99re going to add references to the manual i= n --help and similar: it=E2=80=99s always implicit that documentation is in the manual. However, perhaps we could add terminal hyperlinks to make it more discoverable. Thanks, Ludo=E2=80=99.