From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id eDdJEW493161fAAA0tVLHw (envelope-from ) for ; Tue, 09 Jun 2020 07:42:38 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id 0N8LDW49314OcAAAB5/wlQ (envelope-from ) for ; Tue, 09 Jun 2020 07:42:38 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id DF9099400E1 for ; Tue, 9 Jun 2020 07:42:37 +0000 (UTC) Received: from localhost ([::1]:55998 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jiYu4-0002ya-Rl for larch@yhetil.org; Tue, 09 Jun 2020 03:42:36 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40776) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jiYpe-0004LG-Ai for guix-patches@gnu.org; Tue, 09 Jun 2020 03:38:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:47190) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jiYpd-0008In-VU for guix-patches@gnu.org; Tue, 09 Jun 2020 03:38:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jiYpd-0004DR-SE for guix-patches@gnu.org; Tue, 09 Jun 2020 03:38:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#41756] [PATCH] gnome: gnome-desktop: Add bubblewrap as an input. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 09 Jun 2020 07:38:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41756 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Christopher Baines Cc: 41756@debbugs.gnu.org Received: via spool by 41756-submit@debbugs.gnu.org id=B41756.159168823216146 (code B ref 41756); Tue, 09 Jun 2020 07:38:01 +0000 Received: (at 41756) by debbugs.gnu.org; 9 Jun 2020 07:37:12 +0000 Received: from localhost ([127.0.0.1]:58736 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jiYop-0004CL-TO for submit@debbugs.gnu.org; Tue, 09 Jun 2020 03:37:12 -0400 Received: from eggs.gnu.org ([209.51.188.92]:60788) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jiYoo-0004C8-2r for 41756@debbugs.gnu.org; Tue, 09 Jun 2020 03:37:10 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:36517) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jiYoi-00083t-Ft; Tue, 09 Jun 2020 03:37:04 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=58634 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jiYoe-0006XD-QK; Tue, 09 Jun 2020 03:37:03 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20200607202226.15637-1-mail@cbaines.net> Date: Tue, 09 Jun 2020 09:36:59 +0200 In-Reply-To: <20200607202226.15637-1-mail@cbaines.net> (Christopher Baines's message of "Sun, 7 Jun 2020 21:22:26 +0100") Message-ID: <87r1uoofl0.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -3.3 (---) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -1.01 X-TUID: gRMVNrZ9YXhI Hi! (There=E2=80=99s a typo in the subject prefix.) Christopher Baines skribis: > This is expected to be available, oddly as libseccomp is available. These > changes fix thumbnails for Nautilus. > > * gnu/packages/gnome.scm (gnome-desktop)[arguments]: Add 'patch-bubblewrap > phase. > [inputs]: Add bubblewrap. Nice, I didn=E2=80=99t know the thumbnailer would do that. > + (add-before 'configure 'patch-bubblewrap > + (lambda* (#:key inputs #:allow-other-keys) > + (substitute* "libgnome-desktop/gnome-desktop-thumbnail-scri= pt.c" > + (("\"bwrap\",") > + (string-append "\"" (which "bwrap") "\",")) > + (("\"--ro-bind\", \"/usr\", \"/usr\",") > + (string-append "\"--ro-bind\", \"" > + (%store-directory) > + "\", \"" > + (%store-directory) > + "\",")) > + (("\"--ro-bind\", \"/etc/ld.so.cache\", \"/etc/ld.so.cach= e\",") > + "\"--ro-bind\", \"/run/current-system\", \"/run/current-= system\",")) Perhaps we can replace this second --ro-bind with the empty string? Otherwise LGTM! Ludo=E2=80=99.