From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id 5m8vEuWy5F4iGAAA0tVLHw (envelope-from ) for ; Sat, 13 Jun 2020 11:05:09 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id CK/bDeWy5F4zMgAAB5/wlQ (envelope-from ) for ; Sat, 13 Jun 2020 11:05:09 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 84C82940655 for ; Sat, 13 Jun 2020 11:05:08 +0000 (UTC) Received: from localhost ([::1]:58772 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jk3yF-0005D4-HJ for larch@yhetil.org; Sat, 13 Jun 2020 07:05:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48274) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jk3yA-0005BM-H5 for guix-patches@gnu.org; Sat, 13 Jun 2020 07:05:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:57621) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jk3yA-0002P6-7F for guix-patches@gnu.org; Sat, 13 Jun 2020 07:05:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jk3yA-0003Yg-2n for guix-patches@gnu.org; Sat, 13 Jun 2020 07:05:02 -0400 Subject: bug#41756: [PATCH] gnome: gnome-desktop: Add bubblewrap as an input. Resent-From: Christopher Baines Original-Sender: "Debbugs-submit" Resent-To: guix-patches@gnu.org Resent-Date: Sat, 13 Jun 2020 11:05:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 41756 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 41756-done@debbugs.gnu.org Mail-Followup-To: 41756@debbugs.gnu.org, mail@cbaines.net, mail@cbaines.net Received: via spool by 41756-done@debbugs.gnu.org id=D41756.159204628313641 (code D ref 41756); Sat, 13 Jun 2020 11:05:01 +0000 Received: (at 41756-done) by debbugs.gnu.org; 13 Jun 2020 11:04:43 +0000 Received: from localhost ([127.0.0.1]:40932 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jk3xr-0003Xx-5P for submit@debbugs.gnu.org; Sat, 13 Jun 2020 07:04:43 -0400 Received: from mira.cbaines.net ([212.71.252.8]:51690) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jk3xp-0003Xq-Un for 41756-done@debbugs.gnu.org; Sat, 13 Jun 2020 07:04:42 -0400 Received: from localhost (unknown [46.237.175.96]) by mira.cbaines.net (Postfix) with ESMTPSA id 5571327BBE1; Sat, 13 Jun 2020 12:04:41 +0100 (BST) Received: from localhost (localhost [local]) by localhost (OpenSMTPD) with ESMTPA id 8007812c; Sat, 13 Jun 2020 11:04:39 +0000 (UTC) References: <20200607202226.15637-1-mail@cbaines.net> <87r1uoofl0.fsf@gnu.org> User-agent: mu4e 1.2.0; emacs 26.3 From: Christopher Baines In-reply-to: <87r1uoofl0.fsf@gnu.org> Date: Sat, 13 Jun 2020 12:04:38 +0100 Message-ID: <87r1uj8bw9.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -1.0 (-) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -3.11 X-TUID: DzAtwjQw4Jhc --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Ludovic Court=C3=A8s writes: > Hi! > > (There=E2=80=99s a typo in the subject prefix.) > > Christopher Baines skribis: > >> This is expected to be available, oddly as libseccomp is available. The= se >> changes fix thumbnails for Nautilus. >> >> * gnu/packages/gnome.scm (gnome-desktop)[arguments]: Add 'patch-bubblewr= ap >> phase. >> [inputs]: Add bubblewrap. > > Nice, I didn=E2=80=99t know the thumbnailer would do that. > >> + (add-before 'configure 'patch-bubblewrap >> + (lambda* (#:key inputs #:allow-other-keys) >> + (substitute* "libgnome-desktop/gnome-desktop-thumbnail-scr= ipt.c" >> + (("\"bwrap\",") >> + (string-append "\"" (which "bwrap") "\",")) >> + (("\"--ro-bind\", \"/usr\", \"/usr\",") >> + (string-append "\"--ro-bind\", \"" >> + (%store-directory) >> + "\", \"" >> + (%store-directory) >> + "\",")) >> + (("\"--ro-bind\", \"/etc/ld.so.cache\", \"/etc/ld.so.cac= he\",") >> + "\"--ro-bind\", \"/run/current-system\", \"/run/current= -system\",")) > > Perhaps we can replace this second --ro-bind with the empty string? > > Otherwise LGTM! Great, I've replaced the second --ro-bind as you suggested, that seems not to be necessary. I've pushed as 3857aba7ab25c50d64a6d7468d2b5b09bc4f5d60. Thanks, Chris --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKTBAEBCgB9FiEEPonu50WOcg2XVOCyXiijOwuE9XcFAl7kssZfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcACgkQXiijOwuE 9XdYMw/7BA1FB/HwTxiDW/t71BEeDjcMMsgRoc9m9sYc2tjPZny524ay8GT3y0hD AX7ozd/S4KXJIhwMLVTZVr2WNCL2m2vcoI0QK7koVbYemyEqsRT14+5wj9OmfUpt JDubZzBYOglr8tdFDrX/fAdvKZTWZiCUCFo9+CZX+Kcj/pCrt4jVnIXc48GbHHRu MS3SdUChetBylgQAV2zd/xsSZliUzRGN19cwJbSYRrTuAHJnHupn0SDfEUJylkFI rAucdoQ6w4GqLvHfHzoUtaRmRUlqBhpO+IHHSqC4XuboeNhNxfthcq+mGst5wxE8 J9vIbYxQEqnlGcgphv1GngP0t9N64gjH8zQN2sIamlY9i15uPzXRFuwZlOjTh2Ru /EcsjOIfHzsSX5ns9kKU//qPqxVrjUfDXzCp+9XF7CQNq/HsmpGTAZHqCUxRfxhL ZyLhe+REumtKW3Yyy5++VNZWfxuN2/YgKsOtxIMp4GPw/6ClqALa01PUHqRjSnkq KUsHKJpGE5KtTslhmjnbyueaPW4yiIwk8lCmgQ3HXMB0uN1odhTX32jegwX9MjqW IjnrXJLkGAuZY+ItLs6NggDzC4I+FRU7cwzCGyfAPKN0UpbV2oH9h05DLv3S8vUZ hzkYu3fn4pe81VjwWughIoR8RtrqSc1zOdEGqvmHQjCXc0+g0kM= =ns+d -----END PGP SIGNATURE----- --=-=-=--