From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id mPAiGCWs816AVQAA0tVLHw (envelope-from ) for ; Wed, 24 Jun 2020 19:40:21 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id UL7xEyWs8174VwAA1q6Kng (envelope-from ) for ; Wed, 24 Jun 2020 19:40:21 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id C8DC6940145 for ; Wed, 24 Jun 2020 19:40:20 +0000 (UTC) Received: from localhost ([::1]:45272 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1joBFq-00042I-O4 for larch@yhetil.org; Wed, 24 Jun 2020 15:40:18 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44046) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1joBFa-000417-Ux for guix-patches@gnu.org; Wed, 24 Jun 2020 15:40:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:55839) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1joBFa-000688-Jd for guix-patches@gnu.org; Wed, 24 Jun 2020 15:40:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1joBFa-0003jj-Gb for guix-patches@gnu.org; Wed, 24 Jun 2020 15:40:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#41293] [PATCH 1/3] gnu: Add sideload. Resent-From: Marius Bakke Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 24 Jun 2020 19:40:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41293 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: Ryan Prior Cc: 41293@debbugs.gnu.org Received: via spool by 41293-submit@debbugs.gnu.org id=B41293.159302756614314 (code B ref 41293); Wed, 24 Jun 2020 19:40:02 +0000 Received: (at 41293) by debbugs.gnu.org; 24 Jun 2020 19:39:26 +0000 Received: from localhost ([127.0.0.1]:39152 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1joBF0-0003in-DP for submit@debbugs.gnu.org; Wed, 24 Jun 2020 15:39:26 -0400 Received: from eggs.gnu.org ([209.51.188.92]:57754) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1joBEy-0003ia-Qf for 41293@debbugs.gnu.org; Wed, 24 Jun 2020 15:39:25 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:54353) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1joBEt-0005fR-ET; Wed, 24 Jun 2020 15:39:19 -0400 Received: from ti0006q161-3115.bb.online.no ([88.95.106.80]:48974 helo=localhost) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1joBEs-0006AW-Ss; Wed, 24 Jun 2020 15:39:19 -0400 From: Marius Bakke In-Reply-To: References: <20200602012736.4292-1-rprior@protonmail.com> <20200602012736.4292-2-rprior@protonmail.com> <87d05qdi6x.fsf@gnu.org> Date: Wed, 24 Jun 2020 21:39:16 +0200 Message-ID: <87r1u46yor.fsf@gnu.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -3.3 (---) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -3.11 X-TUID: 0Kss5Z1TI2Z8 --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi Ryan, (+ debbugs, please keep it in CC) Ryan Prior writes: > =E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90 Original = Message =E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90 > On Monday, June 22, 2020 7:16 PM, Marius Bakke wrote: > > >> That's an unorthodox workaround :-) does the build system ignore it when >> DESTDIR is set, or do they just end up in a different location? > > This is a common pattern in build systems for Pantheon software, one you'= ll see come up again and again as I add more Pantheon packages. The post-in= stall script runs extra steps unless the DESTDIR env variable is set. For e= xample: https://github.com/elementary/sideload/blob/master/meson/post_insta= ll.py#L9 OK. Weird, but works. :-) >> Is the "glib:bin" input still needed? > > Yes, for glib-compile-resources, which is invoked here as it is with many= other GNOME packages in Guix. Right. >> > - (propagated-inputs >> > - `(("glib-networking" ,glib-networking))) >> > >> > >> >> Can you add a comment about why this needs to be propagated? > > I didn't take good notes, it was basically "it didn't work without this."= And now that I try it again, it seems what I really need to propagate is g= pgme and not glib-networking. I will add a note. (I want to get good at pat= ching packages to remove the need for propagation but I don't know where to= begin with this one.) At least for GnuPG, substituting all references to 'gpg' with (string-append gnupg "/bin/gpg") should work. I guess something similar will work for GPGME. >> >> > - (native-inputs >> > - `(("cmake" ,cmake) >> > >> > >> >> Use 'cmake-minimal' if CMake is required (is it?). > > Nope was never needed, removed. (I think I was adding cmake to a lot of M= eson packages for a while because they complain about not having it in thei= r build output, but it's really just a warning.) Yes, learning to ignore useless warnings is an important packaging skill. :-) >> > - (license license:gpl3))) >> >> This should be 'gpl3+' because no source files say "GPL 3 only" (in fact >> they explicitly mention GPL 3 or any later version). > > Fixed & updated patch follows. Applied! I moved 'glib', 'libgee', and 'libxml2' to inputs because they were referenced by the io.elementary.sideload binary. Let me know if you think this was wrong. Will you submit updated patches for the other two in this series too? Thanks! --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAl7zq+QACgkQoqBt8qM6 VPqCXQgAngCbZexrCdw/RR1FvSI3gnH7LBNcq68SGqhtuj1WRzOIxTTns6TsRbNU C4YafZEhAplaoHTUwzmCIKGdH8RXwUChVnp2aN4ynYE30IwoIXQZNdyGxK2r6pRX KeOOb4uzGfizTTNkXG/xULcyB+83FWNl/klMnxISeaT1YAbuEP6PEB0NVD4E0XTK +kbsVMAwLCPOOiUnRnrW0zIXlKm6SOQZtqdW9qvQFMvlJ19siqFWvlijvgvXProU Jj7O8qx1nTvSkm0NJwjv7tz8pyStWUXbqHarh0RUjqVUPR+2koVij6Tn3lp8IQ6n A1AL7KAnY7grFDIL3mE99mUKkAGo9Q== =h8VR -----END PGP SIGNATURE----- --=-=-=--