From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id GH9kBFDLCV/WNgAA0tVLHw (envelope-from ) for ; Sat, 11 Jul 2020 14:23:12 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id OL8rAFDLCV9SbAAAB5/wlQ (envelope-from ) for ; Sat, 11 Jul 2020 14:23:12 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 628999403AD for ; Sat, 11 Jul 2020 14:23:11 +0000 (UTC) Received: from localhost ([::1]:51594 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1juGPG-0000HW-0p for larch@yhetil.org; Sat, 11 Jul 2020 10:23:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35042) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1juGP8-0000GA-Ka for bug-guix@gnu.org; Sat, 11 Jul 2020 10:23:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:33217) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1juGP8-0003pO-Bk for bug-guix@gnu.org; Sat, 11 Jul 2020 10:23:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1juGP8-0005Se-6C for bug-guix@gnu.org; Sat, 11 Jul 2020 10:23:02 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#42151: [PATCH v3 2/2] image: Do not set journal_model=WAL for the Hurd. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Sat, 11 Jul 2020 14:23:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42151 X-GNU-PR-Package: guix X-GNU-PR-Keywords: patch To: "Jan \(janneke\) Nieuwenhuizen" Received: via spool by 42151-submit@debbugs.gnu.org id=B42151.159447735220941 (code B ref 42151); Sat, 11 Jul 2020 14:23:02 +0000 Received: (at 42151) by debbugs.gnu.org; 11 Jul 2020 14:22:32 +0000 Received: from localhost ([127.0.0.1]:44763 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1juGOd-0005Rh-Ov for submit@debbugs.gnu.org; Sat, 11 Jul 2020 10:22:31 -0400 Received: from eggs.gnu.org ([209.51.188.92]:49314) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1juGOc-0005RS-5A for 42151@debbugs.gnu.org; Sat, 11 Jul 2020 10:22:30 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:56046) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1juGOW-0003mh-68; Sat, 11 Jul 2020 10:22:24 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=57508 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1juGOS-0004BN-14; Sat, 11 Jul 2020 10:22:23 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20200710183551.12807-1-janneke@gnu.org> <20200710183551.12807-2-janneke@gnu.org> Date: Sat, 11 Jul 2020 16:22:18 +0200 In-Reply-To: <20200710183551.12807-2-janneke@gnu.org> (Jan Nieuwenhuizen's message of "Fri, 10 Jul 2020 20:35:51 +0200") Message-ID: <87r1tiw2qt.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -3.3 (---) X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 42151@debbugs.gnu.org Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Spam-Score: -1.01 X-TUID: vTLMdl1g3XJG "Jan (janneke) Nieuwenhuizen" skribis: > This fixes . > > * gnu/system/images/hurd.scm (hurd-initialize-root-partition): Use #:wal-= mode #f > in call to ... > * gnu/build/image.scm (initialize-root-partition): ... this, add #:wal-mo= de? > parameter, pass it to ... > (register-closure): ... this, add #:wal-mode? parameter, pass it to ... > * guix/store/database.scm (with-database): ... this, add #:wal-mode? > parameter, pass it to ... > (call-with-database): ... this, add #:wal-mode? parameter; when > set to #f, do not set journal_model=3DWAL. [...] > +++ b/gnu/system/images/hurd.scm > @@ -61,8 +61,8 @@ > #~(lambda* (#:rest args) > (apply initialize-root-partition > (append args > - (list #:make-device-nodes > - make-hurd-device-nodes))))) > + (list #:make-device-nodes make-hurd-device-nodes > + #:wal-mode? #f))))) IWBN to have an XXX comment here stating why we disable WAL mode on GNU/Hurd, possibly referencing this issue. That way, we can eventually revisit the issue and hopefully get rid of this workaround. Apart from that the patch LGTM, thanks! Ludo=E2=80=99.