From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id IElFBrqvql8BLAAA0tVLHw (envelope-from ) for ; Tue, 10 Nov 2020 15:20:26 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id eLolArqvql9VUQAAB5/wlQ (envelope-from ) for ; Tue, 10 Nov 2020 15:20:26 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id BD4709402B4 for ; Tue, 10 Nov 2020 15:20:25 +0000 (UTC) Received: from localhost ([::1]:44298 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kcVRY-0006l8-MX for larch@yhetil.org; Tue, 10 Nov 2020 10:20:24 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:48510) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kcVQE-00059u-Cg for bug-guix@gnu.org; Tue, 10 Nov 2020 10:19:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:55320) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kcVQD-0004zi-Vf for bug-guix@gnu.org; Tue, 10 Nov 2020 10:19:01 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kcVQD-0005dB-QU for bug-guix@gnu.org; Tue, 10 Nov 2020 10:19:01 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#43893: [PATCH] maint: update-guix-package: Optionally add sources to store. Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Tue, 10 Nov 2020 15:19:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43893 X-GNU-PR-Package: guix X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Received: via spool by 43893-submit@debbugs.gnu.org id=B43893.160502150521595 (code B ref 43893); Tue, 10 Nov 2020 15:19:01 +0000 Received: (at 43893) by debbugs.gnu.org; 10 Nov 2020 15:18:25 +0000 Received: from localhost ([127.0.0.1]:38633 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kcVPd-0005cE-Ap for submit@debbugs.gnu.org; Tue, 10 Nov 2020 10:18:25 -0500 Received: from mail-qk1-f195.google.com ([209.85.222.195]:42563) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kcVPc-0005c0-AN for 43893@debbugs.gnu.org; Tue, 10 Nov 2020 10:18:24 -0500 Received: by mail-qk1-f195.google.com with SMTP id 199so2545873qkg.9 for <43893@debbugs.gnu.org>; Tue, 10 Nov 2020 07:18:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=fNY6WgEXJU14VWH1ea4oFZR4aASq9prJRlUyXyae0zs=; b=MsKzUYX3eKm176wMUFlXp/Rrh3wUySyAFCd2y3JQxZlH8je0AYmQmKQcUcVhf0D5Tl 9umAjV+hX8A0QsH+M7LcJrRg080SiuK4ok3nFxwW5AV4pPasXtGBMYTc87pteBqbjXvt SDFZahrDVrbai2mVemeAQofEmqVG709SmfbrZJWVsYIT1RHpuNYZdxId1qpOV1ylHqef Gw7JEjvzQfeDNEC3jdY6RqUx1cyOzdCJqUgpzxDzkoH4e3qqwJo6HeV9MUCADLrPB8yf VzlbLvrAQWzlNIvPMgflD+SFnP5wZimZaPt/Gst/m6hvPgsHvn0B9JgI1dLY6GBsZNrj iSxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=fNY6WgEXJU14VWH1ea4oFZR4aASq9prJRlUyXyae0zs=; b=AbTj2bAelEVNsUPAHnw4gArZaTCUUwENhPOOr8U7oE2AdcX1RKrtNpHQw/PtTUE4Kj XxXerXNAJlJqhU5UPD/I4sXTdUu7/DASAOxIniu8PW8WJTZ7/sHZ9LZQPfhaYxGi0MLO kSlh+M2nvBV5zLIYB++A9GdMFhph7UOR6rq2aKInZsSA58UC/2jjefiGeIWUGX3JnGfM mFdztmnesu+/ylgxPyGg7DhcELdnjZfwkBHEbBhki8TsBz8D6FAUlDG2F9hRX9NXP7lU upFxy6NczKQAejf7/hhpV1XrPRLXwqu9Q5k2skSoBooHd2FDVjeSbQdagOt2FtpbxBgt cF/A== X-Gm-Message-State: AOAM532dX1Sc96/9qwohlC9B/Mx//sW6nknp/OLTz2YAtfEsQobl5CGK 2FWBZs+JU6GzqtDP/hfoPr+PWrsi36o= X-Google-Smtp-Source: ABdhPJyPAltBW5UjUh9q0pkAFnVDMWbCHv+Rb959V/SG1FHEESlMfCXSUOxZMuK+Iu9YF1MKiBQOhw== X-Received: by 2002:a05:620a:13d8:: with SMTP id g24mr6560767qkl.162.1605021498636; Tue, 10 Nov 2020 07:18:18 -0800 (PST) Received: from hurd (dsl-10-133-153.b2b2c.ca. [72.10.133.153]) by smtp.gmail.com with ESMTPSA id y44sm5269951qtb.50.2020.11.10.07.18.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Nov 2020 07:18:17 -0800 (PST) From: Maxim Cournoyer References: <871rhevfpp.fsf@gnu.org> <20201109192923.29580-1-maxim.cournoyer@gmail.com> <87pn4mqime.fsf@gnu.org> <87zh3pgvhp.fsf@gmail.com> <87y2j9nu8f.fsf@gnu.org> Date: Tue, 10 Nov 2020 10:18:15 -0500 In-Reply-To: <87y2j9nu8f.fsf@gnu.org> ("Ludovic =?UTF-8?Q?Court=C3=A8s?="'s message of "Tue, 10 Nov 2020 15:48:16 +0100") Message-ID: <87r1p1gs08.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -1.0 (-) X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 43893@debbugs.gnu.org Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Scanner: ns3122888.ip-94-23-21.eu Authentication-Results: aspmx1.migadu.com; dkim=fail (headers rsa verify failed) header.d=gmail.com header.s=20161025 header.b=MsKzUYX3; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Spam-Score: 0.09 X-TUID: q7Xbf7lbkdk4 Hi again! Ludovic Court=C3=A8s writes: > Hi, > > Maxim Cournoyer skribis: > >>> Thanks for the patch, that should break the deadlock and allow us to >>> proceed with the release! >>> >>> Next we need to update the =E2=80=98release=E2=80=99 target so >>> GUIX_ALLOW_ME_TO_USE_PRIVATE_COMMIT is set. >> >> Done! > > Thanks! > >>> the extra dependency on Git, >> >> To me, this script (update-guix-package), is an extension of the >> Make-based build system (that's currently it's sole entry-point). There >> are already calls to git in this build system (for example, to get the >> commit corresponding to HEAD), so I don't perceive it as nasty in this >> context. It can also be used as a reminder of things that are missing >> in (guile git), for the purists ;-). > > I think we had everything needed in Guile-Git. Not for the current implementation, that uses git worktrees and search for the presence of the commit corresponding to HEAD in the upstream remote. If my (summary) analysis of the current state of (guile git) is wrong, I'd be happy to migrate the bits shelling out to git to actual library calls via (guile git). [...] > I hope this discussion can at least help improve mutual understanding on > future patches and review processes. > > Thanks again for your time and patience! I am equally grateful for yours. This is a long thread! Thanks, Maxim