bug#29824: Meson 0.44.0 is broken with guix.

bug#29824: Meson 0.44.0 is broken with guix.

[Fis Trivial]

I installed meson with command `guix package -i meson`

* Error:
$ meson --version

Traceback (most recent call last):
   File 
"/gnu/store/n53zdnl4l3gm9sg15bfwxp0wdrwrvhg4-meson-0.44.0/bin/.meson-real", 
line 17, in <module>
     from mesonbuild import mesonmain, mesonlib
   File 
"/gnu/store/n53zdnl4l3gm9sg15bfwxp0wdrwrvhg4-meson-0.44.0/lib/python3.5/site-packages/mesonbuild/mesonmain.py", 
line 18, in <module>
     from . import environment, interpreter, mesonlib
   File 
"/gnu/store/n53zdnl4l3gm9sg15bfwxp0wdrwrvhg4-meson-0.44.0/lib/python3.5/site-packages/mesonbuild/environment.py", 
line 17, in <module>
     from . import coredata
   File 
"/gnu/store/n53zdnl4l3gm9sg15bfwxp0wdrwrvhg4-meson-0.44.0/lib/python3.5/site-packages/mesonbuild/coredata.py", 
line 20, in <module>
     from .mesonlib import MesonException, commonpath
   File 
"/gnu/store/n53zdnl4l3gm9sg15bfwxp0wdrwrvhg4-meson-0.44.0/lib/python3.5/site-packages/mesonbuild/mesonlib.py", 
line 60, in <module>
     meson_command = python_command + [detect_meson_py_location()]
   File 
"/gnu/store/n53zdnl4l3gm9sg15bfwxp0wdrwrvhg4-meson-0.44.0/lib/python3.5/site-packages/mesonbuild/mesonlib.py", 
line 51, in detect_meson_py_location
     raise RuntimeError('Could not determine how to run Meson. Please 
file a bug with details.')
RuntimeError: Could not determine how to run Meson. Please file a bug 
with details.


I'm currently using Guix on top of Fedora 26. The installed version of 
meson is 0.44.0.


* Possible cause:
 From /mesonlib.py/: line 47~51, we have:
#+BEGIN_BLOCK python
     # The only thing remaining is to try to find the bundled executable and
     # pray distro packagers have not moved it.
     fname = os.path.join(os.path.dirname(__file__), '..', 'meson.py')
     if not os.path.exists(fname):
         raise RuntimeError('Could not determine how to run Meson. 
Please file a bug with details.')
#+END_BLOCK
which means meson will try to find the meson.py script at startup, but 
it seems Guix has renamed the this file with the new file name 
*.meson-real* and warp it with a shell script /meson/ in bin.

bug#29824: Meson 0.44.0 is broken with guix.

[Hartmut Goebel]

[-- Attachment #1: Type: text/plain, Size: 957 bytes --]

We need to have a look at the whole `detect_meson_py_location()`, not
only on lines 47 to 51.

detect_meson_py_location() assumes the executable to be called "meson"
or "meson.py", but in guix it currently is called ".meson-real" (see teh
first entry in the trace-back).

The solution would be to get rid of the wrapper-scripts, see
<https://lists.gnu.org/archive/html/guix-devel/2017-11/msg00041.html>

A work-around would be to substitute in file mesonbuild/mesonlib.py

meson_command = python_command + [detect_meson_py_location()]

by

meson_command = python_command + ["$OUT/bin/meson"]

(you got the idea, I assume). Of course we should verify
detect_meson_py_location() is not used elsewhere and consider renaming
that function to "disable" it.

-- 
Regards
Hartmut Goebel

| Hartmut Goebel          | h.goebel@crazy-compilers.com               |
| www.crazy-compilers.com | compilers which you thought are impossible |


[-- Attachment #2: Type: text/html, Size: 1767 bytes --]

bug#29824: Meson 0.44.0 is broken with guix.

[Ludovic Courtès]

Hi Hartmut,

Hartmut Goebel <h.goebel@crazy-compilers.com> skribis:

> We need to have a look at the whole `detect_meson_py_location()`, not
> only on lines 47 to 51.
>
> detect_meson_py_location() assumes the executable to be called "meson"
> or "meson.py", but in guix it currently is called ".meson-real" (see teh
> first entry in the trace-back).
>
> The solution would be to get rid of the wrapper-scripts, see
> <https://lists.gnu.org/archive/html/guix-devel/2017-11/msg00041.html>
>
> A work-around would be to substitute in file mesonbuild/mesonlib.py
>
> meson_command = python_command + [detect_meson_py_location()]
>
> by
>
> meson_command = python_command + ["$OUT/bin/meson"]

Sounds reasonable.  Does it work for you?  If so, could you provide a
patch?

Ludo’.

bug#29824: Meson 0.44.0 is broken with guix.

[Hartmut Goebel]

Am 09.01.2018 um 13:46 schrieb Ludovic Courtès:
> Sounds reasonable.  Does it work for you?  If so, could you provide a
> patch?

I don't have any cards in this game and not time for working on it ATM,
I just did the analysis.

@peter: What about you?

-- 
Regards
Hartmut Goebel

| Hartmut Goebel          | h.goebel@crazy-compilers.com               |
| www.crazy-compilers.com | compilers which you thought are impossible |

bug#29824: Meson 0.44.0 is broken with guix.

[Peter Mikkelsen]

[-- Attachment #1: Type: text/plain, Size: 647 bytes --]

Hi,

Den 9. jan. 2018 22.10 skrev "Hartmut Goebel" <h.goebel@crazy-compilers.com
>:

Am 09.01.2018 um 13:46 schrieb Ludovic Courtès:
> Sounds reasonable.  Does it work for you?  If so, could you provide a
> patch?

I don't have any cards in this game and not time for working on it ATM,
I just did the analysis.

@peter: What about you?




I am sorry to let you down, but I dont have any time for developing on guix
at the moment :/ and by the way, I am not, and have never considered myself
a user of meson, I just wanted the buildsystem in guix because I noticed
that gnome was starting to use it :)

-- Peter Mikkelsen

[-- Attachment #2: Type: text/html, Size: 1544 bytes --]

bug#29824: Meson 0.44.0 is broken with guix.

[Fis Trivial]

>>
>> detect_meson_py_location() assumes the executable to be called "meson"
>> or "meson.py", but in guix it currently is called ".meson-real" (see teh
>> first entry in the trace-back).
>>
>> The solution would be to get rid of the wrapper-scripts, see
>> <https://lists.gnu.org/archive/html/guix-devel/2017-11/msg00041.html>
>>
>> A work-around would be to substitute in file mesonbuild/mesonlib.py
>>
>> meson_command = python_command + [detect_meson_py_location()]
>>
>> by
>>
>> meson_command = python_command + ["$OUT/bin/meson"]
> 
> Sounds reasonable.  Does it work for you?  If so, could you provide a
> patch?
> 
> Ludo’.
> 

Or in this case, python script, we can change the wrapper script into something
like this:

#+BEGIN_SRC python
import os
os.environ['PYTHONPATH']="/gnu/store/.../site-packages${PYTHONPATH:+:}$PYTHONPATH"
exec(open("/gnu/store/n53zdnl4l3gm9sg15bfwxp0wdrwrvhg4-meson-0.44.0/bin/.meson-real").read())
#+END_SRC

or

#+BEGIN_SRC python
import os
os.environ['PYTHONPATH']="/gnu/store/.../site-packages${PYTHONPATH:+:}$PYTHONPATH"
exec(compile(
    open(
        "/gnu/store/n53zdnl4l3gm9sg15bfwxp0wdrwrvhg4-meson-0.44.0/bin/.meson-real".read(),
        "/gnu/store/n53zdnl4l3gm9sg15bfwxp0wdrwrvhg4-meson-0.44.0/bin/.meson-real",
        'exec'
    )))
#+END_SRC

bug#29824: Meson 0.44.0 is broken with guix.

[Fis Trivial]

> or
> 
> #+BEGIN_SRC python
> import os
> os.environ['PYTHONPATH']="/gnu/store/.../site-packages${PYTHONPATH:+:}$PYTHONPATH"
> exec(compile(
>     open(
>         "/gnu/store/n53zdnl4l3gm9sg15bfwxp0wdrwrvhg4-meson-0.44.0/bin/.meson-real".read(),
>         "/gnu/store/n53zdnl4l3gm9sg15bfwxp0wdrwrvhg4-meson-0.44.0/bin/.meson-real",
>         'exec'
>     )))
> #+END_SRC
> 
Sorry about that, this section is wrong. Here is the correct one. Be careful with the "..."
in the environ assignment. I omitted part of the path due to it's too long.

#+BEGIN_SRC python
#!/usr/bin/env python3
import os
os.environ['PYTHONPATH'] = "/gnu/store/.../site-packages${PYTHONPATH:+:}$PYTHONPATH"
# exec(open("/gnu/store/n53zdnl4l3gm9sg15bfwxp0wdrwrvhg4-meson-0.44.0/bin/.meson-real").read())
exec(compile(
    open(
        "/gnu/store/n53zdnl4l3gm9sg15bfwxp0wdrwrvhg4-meson-0.44.0/bin/.meson-real"
    ).read(),
    "/gnu/store/n53zdnl4l3gm9sg15bfwxp0wdrwrvhg4-meson-0.44.0/bin/.meson-real",
    'exec'
))

#+END_SRC

And the wrapper should be named as "meson", in this case.
The above code set the environment variables and execute the corresponding code
by loading it(not spawning a new process). Hence the argv will be preserved.

bug#29824: Meson 0.44.0 is broken with guix.

[Ludovic Courtès]

Hello,

Fis Trivial <ybbs.daans@hotmail.com> skribis:

> Sorry about that, this section is wrong. Here is the correct one. Be careful with the "..."
> in the environ assignment. I omitted part of the path due to it's too long.
>
> #+BEGIN_SRC python
> #!/usr/bin/env python3
> import os
> os.environ['PYTHONPATH'] = "/gnu/store/.../site-packages${PYTHONPATH:+:}$PYTHONPATH"
> # exec(open("/gnu/store/n53zdnl4l3gm9sg15bfwxp0wdrwrvhg4-meson-0.44.0/bin/.meson-real").read())
> exec(compile(
>     open(
>         "/gnu/store/n53zdnl4l3gm9sg15bfwxp0wdrwrvhg4-meson-0.44.0/bin/.meson-real"
>     ).read(),
>     "/gnu/store/n53zdnl4l3gm9sg15bfwxp0wdrwrvhg4-meson-0.44.0/bin/.meson-real",
>     'exec'
> ))
>
> #+END_SRC
>
> And the wrapper should be named as "meson", in this case.
> The above code set the environment variables and execute the corresponding code
> by loading it(not spawning a new process). Hence the argv will be preserved.

Sure, though Hartmut’s solution looked even simpler.

BTW, Ricardo has posted a patch on this topic here:

  https://bugs.gnu.org/29951

We could use it here (it won’t be merged until the next ‘core-updates’
cycle), but if there’s a simpler solution, we should probably go for
that.

Thanks,
Ludo’.

bug#29824: Meson 0.44.0 is broken with guix.

[zimoun]

Dear,

On Sat, 23 Dec 2017 at 19:18, Fis Trivial <ybbs.daans@hotmail.com> wrote:
> I installed meson with command `guix package -i meson`
>
> * Error:
> $ meson --version
>
> Traceback (most recent call last):
>    File 

[...]

> RuntimeError: Could not determine how to run Meson. Please file a bug 
> with details.

Using Guix on the top of Debian and running:

--8<---------------cut here---------------start------------->8---
guix environment -C --ad-hoc meson
meson --version
--8<---------------cut here---------------end--------------->8---

works for me with Guix 73e7a42.  Is it still an issue for you?

Since the commit 0fb9a8df429a7b9f40610ff15baaff0d8e31e8cf is merged on
master – if I read correctly – the issue should be fixed.

What is the status of this bug?


All the best,
simon

bug#29824: Meson 0.44.0 is broken with guix.

[Tobias Geerinckx-Rice via Bug reports for GNU Guix]

[-- Attachment #1: Type: text/plain, Size: 166 bytes --]

Meson 0.44.0 is long gone and 0.55 works fine:

  ~ λ guix environment --{ad-hoc,pure} meson -- meson --version
  0.55.1

Closing this fixed old bug,

T G-R

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 247 bytes --]