From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id MP0kEuUK8l/OJgAA0tVLHw (envelope-from ) for ; Sun, 03 Jan 2021 18:20:21 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id WKz8DeUK8l+xBQAAbx9fmQ (envelope-from ) for ; Sun, 03 Jan 2021 18:20:21 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id B10ED9404E4 for ; Sun, 3 Jan 2021 18:20:20 +0000 (UTC) Received: from localhost ([::1]:35988 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kw7zH-0001dt-LX for larch@yhetil.org; Sun, 03 Jan 2021 13:20:19 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:42286) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kw7z0-0001dn-5v for guix-patches@gnu.org; Sun, 03 Jan 2021 13:20:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:55274) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kw7yz-0004KN-U1 for guix-patches@gnu.org; Sun, 03 Jan 2021 13:20:01 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kw7yz-0000Ka-PN for guix-patches@gnu.org; Sun, 03 Jan 2021 13:20:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#45409] [PATCH 3/3] guix: Split (guix substitute) from (guix scripts substitute). Resent-From: Christopher Baines Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 03 Jan 2021 18:20:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45409 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Received: via spool by 45409-submit@debbugs.gnu.org id=B45409.16096979721229 (code B ref 45409); Sun, 03 Jan 2021 18:20:01 +0000 Received: (at 45409) by debbugs.gnu.org; 3 Jan 2021 18:19:32 +0000 Received: from localhost ([127.0.0.1]:38587 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kw7yW-0000Jl-7c for submit@debbugs.gnu.org; Sun, 03 Jan 2021 13:19:32 -0500 Received: from mira.cbaines.net ([212.71.252.8]:40472) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kw7yU-0000Jd-8q for 45409@debbugs.gnu.org; Sun, 03 Jan 2021 13:19:31 -0500 Received: from localhost (92.41.186.20.threembb.co.uk [92.41.186.20]) by mira.cbaines.net (Postfix) with ESMTPSA id BE55527BC0D; Sun, 3 Jan 2021 18:19:29 +0000 (GMT) Received: from capella (localhost [127.0.0.1]) by localhost (OpenSMTPD) with ESMTP id 74372971; Sun, 3 Jan 2021 18:19:27 +0000 (UTC) References: <20201224172221.21057-1-mail@cbaines.net> <20201224172221.21057-3-mail@cbaines.net> <87czym12j1.fsf@gnu.org> User-agent: mu4e 1.4.13; emacs 27.1 From: Christopher Baines In-reply-to: <87czym12j1.fsf@gnu.org> Date: Sun, 03 Jan 2021 18:19:26 +0000 Message-ID: <87r1n1993l.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 45409@debbugs.gnu.org Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -4.43 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: B10ED9404E4 X-Spam-Score: -4.43 X-Migadu-Scanner: scn0.migadu.com X-TUID: 1rsBAYCptHaB --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Ludovic Court=C3=A8s writes: > Hi, > > Christopher Baines skribis: > >> This means there's a module for working with substitutes, rather than al= l the >> code sitting in the script. The need for this can be seen with the weath= er and >> challenge scripts, that now don't have to use code from the substitute s= cript, >> but can instead use the substitute module. >> >> The separation here between the actual functionality of the substitute s= cript >> and the underlying functionality used both there and elsewhere should ma= ke >> maintenance easier moving forward. >> >> This commit just moves code, none of the code should have been changed >> significantly. > > It would still be nice to list the identifiers that were moved in the > commit log, it=E2=80=99s boring :-) but it can be helpful when browsing t= he > history. Sure, I've done that now, I'd got bored by this point before. > As for the split, I wouldn=E2=80=99t put as much into (guix substitutes) = (I=E2=80=99d > use =E2=80=9Csubstitutes=E2=80=9D, plural, for consistency with most othe= r modules.) Done. > As a rule of thumb, I would keep in (guix scripts substitute) anything > that=E2=80=99s very much biased towards a single short-lived process: con= nection > cache, host name resolution failure cache, etc. These things are a bit > hacky and not designed for use as a library. They=E2=80=99re also very m= uch > policy rather than mechanism, and as such they don=E2=80=99t belong in a = proper > library IMO. I think that's fine, but it's harder said than done. I think the connection caching and host name resolution failure caching code would need unpicking from the general substitute fetching code, and I haven't attempted to do that yet. >> -(define* (http-multiple-get base-uri proc seed requests >> - #:key port (verify-certificate? #t) >> - (open-connection guix:open-connection-for-u= ri) >> - (keep-alive? #t) >> - (batch-size 1000)) > > How about moving this one to (guix http-client), as a separate patch? > I think it=E2=80=99s a better fit and could be useful elsewhere. Sure, that sounds good, I'll look at it later with a separate patch. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKlBAEBCgCPFiEEPonu50WOcg2XVOCyXiijOwuE9XcFAl/yCq5fFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcRHG1haWxAY2Jh aW5lcy5uZXQACgkQXiijOwuE9Xfoig//S4ZjMTWa03WY4nJMp7mDcZyARD4fFm4c kv68rqYN5Ye011fQYZdTl3gGzUOc2/cR0da95OnRcM7j5P/8C6LBssMEVgJdiodu e6QYA8fo6GSBsg73AZ2PjnivQy5HTPwUOIJfsUQAWIYZPb1xpgQFN2CBO2EnjphO DEdwAHBpLua2Y63euLoteuLK1/pMA6yqMxXxz5BlYRNKsdVsfWkkBXOE8oFU339/ zlBh30AMYfXDhd+ty2988JaoCXYj1jiLfBH4yohV33v79UbLEoNQxKGbTGWQcG/l qWDNJy9sJDBlhqPOT70eSxm0/4VBbLaBOcRk1eG4zSMm/aikCB1MUnHfz9aZcwsV GIFwRo+vk7WJ3ZLpFQVHW9QoH3p4oXIKrL/SEkYabya50zLZqW8cPqQC9amvnruX JWImOtwQ1qikTufyVOp92970atxUGkID6P/kqDm+yNOVYHc6vI1p/xwpAaFIrv0L xZQmt13flLbt/ECFDTnEDFJBhjIxYAPCbwsgByEymEgngBTVWvLuum48x+74oI+I Th+v8+q3/AFg1744PS8cebY3Ao+xEz806kgqqT9B6dkKRdSM860znHQNF7ls/ugR aG2Otl6qj3aLDhqIH+4mrP0uhMGFAoPIv+ED3giJNWsmlv9R2rsYI/0cth+NP2FM CEKtZD/upj8= =TZRo -----END PGP SIGNATURE----- --=-=-=--