From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id aOIkO0xzN2EUXwEAgWs5BA (envelope-from ) for ; Tue, 07 Sep 2021 16:12:28 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id UGPANkxzN2E7GwAAB5/wlQ (envelope-from ) for ; Tue, 07 Sep 2021 14:12:28 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 43F8A2F930 for ; Tue, 7 Sep 2021 16:12:28 +0200 (CEST) Received: from localhost ([::1]:45088 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mNbpr-0000nK-Bq for larch@yhetil.org; Tue, 07 Sep 2021 10:12:27 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56002) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mNbkc-0005y4-QK for guix-patches@gnu.org; Tue, 07 Sep 2021 10:07:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:45695) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mNbkc-0002iB-H0 for guix-patches@gnu.org; Tue, 07 Sep 2021 10:07:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mNbkc-0004h3-Ay for guix-patches@gnu.org; Tue, 07 Sep 2021 10:07:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#50217] [PATCH] gnu: Add c2ffi-11.0.0. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 07 Sep 2021 14:07:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50217 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: muradm Cc: 50217@debbugs.gnu.org Received: via spool by 50217-submit@debbugs.gnu.org id=B50217.163102360017997 (code B ref 50217); Tue, 07 Sep 2021 14:07:02 +0000 Received: (at 50217) by debbugs.gnu.org; 7 Sep 2021 14:06:40 +0000 Received: from localhost ([127.0.0.1]:57238 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mNbkF-0004gB-Gg for submit@debbugs.gnu.org; Tue, 07 Sep 2021 10:06:40 -0400 Received: from eggs.gnu.org ([209.51.188.92]:39708) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mNbk2-0004ff-DI for 50217@debbugs.gnu.org; Tue, 07 Sep 2021 10:06:38 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:50494) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mNbjx-0002BA-7Q; Tue, 07 Sep 2021 10:06:21 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=35366 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mNbjw-0004gG-Uz; Tue, 07 Sep 2021 10:06:21 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20210826210712.31273-1-mail@muradm.net> <20210827001207.4105-1-mail@muradm.net> Date: Tue, 07 Sep 2021 16:06:18 +0200 In-Reply-To: <20210827001207.4105-1-mail@muradm.net> (muradm's message of "Fri, 27 Aug 2021 03:12:07 +0300") Message-ID: <87r1e04h0l.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1631023948; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=7yPXHlD3LZHX0GT3106ai6RpiMI/ycDJmqRd1Q1rKMk=; b=iHeDYYaQDZlGqxV9iw6d1MXxL1TPv3XJsFzSbR+jmO15TPZcEZAHrdO2q5ZCcl3HqmNPJd WPYDaPXIa8FSZwqv/ywIm4rSFAUPjcYsMhehB6HI/81qdQsvT+iLLDPa3SdRYYLV+tdOZp 2fyooFH2eErDMk/E1n4UMAZkl6aoAPyAnKi317a6Swrjb7W/I5MoouE79xd62btb7DyLAd Myj9QsCQ7rwYxUjFv/04bo1PqzRgbAGDp1dNys1eGrvrF6bNckvPW5DHL8ePNfq2ERzEPG AUcVOhb1NCFkedbO7cUAZzBMmgcQ9Nh0Mp8rCTMaHrA7u9S+d8thtcl6YTF6ug== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1631023948; a=rsa-sha256; cv=none; b=aJW32IKXvK3k47kdY6jEbXEkjgEhtID2/PWnUOKWOZWPEO6uV2p8QXKHfqUK4VHVYcCTp4 JBxVqwq+0enXUZcdab2AB2vTLqRO6KckyQAA51rnR8w4sdLdYC66wU0uUDr/HuL2c3qi4s pmlQz9KjyaUyYsWbBPEawkhuluvMLJDlcWAoJRhwA552LEuZetnxkEBC/4oZFQf06+0hbK 7zod8ui5sKnlpwKyppbdpvfRLIHBNCt7Dpf85z1lXKE22+iG1BMNBKXJ3CdNmGrv3HSnTK fwg1ogxsUSD/P8zLOJ6FXgZHaGdXcLbzj+jkFQ8hDbdruIKmxOBH72GrrMSlEA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -1.41 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 43F8A2F930 X-Spam-Score: -1.41 X-Migadu-Scanner: scn0.migadu.com X-TUID: +V7tfY/insWI Hello, muradm skribis: > * gnu/packages/cpp.scm (c2ffi): New variable. Overall LGTM, modulo the following minor issues: [...] > +(define-public c2ffi > + (let ((commit "f50243926a0afb589de1078a073ac08910599582") > + (revision "1") > + (c2ffi-sha256 "17j73yb6v3lfvwwicl2f3yg141iz2dk1rf874qzqs5bkq64ld= jsj")) Normally, we only provide upstream releases. If you think we need this specific commit, could you add a comment explaining why? Please leave the base32 sha256 string where it=E2=80=99s used, within the (base32 =E2=80=A6) expression (it=E2=80=99s a macro that decodes base32 at compile-time.) > + #:tests? #f)) It would be best to run tests. Alternatively, if this is not feasible, please add a comment explaining why we=E2=80=99re skipping them. > + (synopsis "Clang-based FFI wrapper generator") > + (description "tool for extracting definitions from C, C++, and > +Objective C headers for use with foreign function call interfaces.") Please write full sentences, as per . > + (license license:gpl2)))) Is it GPLv2-only? Unless it=E2=80=99s explicitly stated, it=E2=80=99s prob= ably GPLv2-or-later (=E2=80=98license:gpl2+=E2=80=99). Could you send an updated patch? Thanks! Ludo=E2=80=99.