[bug#52721] [PATCH] gnu: python-pydata-sphinx-theme: Fix build.

[bug#52721] [PATCH] gnu: python-pydata-sphinx-theme: Fix build.

[Aleksandr Vityazev]

Hi,

the build fails because a package is required python-docutils < 0.17.


--8<---------------cut here---------------start------------->8---
ERROR: Could not find a version that satisfies the requirement docutils<0.17 (from versions: none)
ERROR: No matching distribution found for docutils<0.17
error: Command '['/gnu/store/3282r97il61j9jkv2aaifa3nwdylzfsv-python-wrapper-3.9.6/bin/python', '-m', 'pip', '--disable-pip-version-check', 'wheel', '--no-deps', '-w', '/tmp/guix-build-python-pydata-sphinx-theme-0.6.3.drv-0/tmpqhg_sgru', '--quiet', 'docutils<0.17']' returned non-zero exit status 1.
--8<---------------cut here---------------end--------------->8---



* gnu/packages/sphinx (python-pydata-sphinx-theme):
[native-inputs]: Replace python-docutils with python-docutils-0.15.
---
 gnu/packages/sphinx.scm | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/sphinx.scm b/gnu/packages/sphinx.scm
index 3ac5b5e22c..957c4dc9c4 100644
--- a/gnu/packages/sphinx.scm
+++ b/gnu/packages/sphinx.scm
@@ -18,6 +18,7 @@
 ;;; Copyright © 2021 Vinicius Monego <monego@posteo.net>
 ;;; Copyright © 2021 Hugo Lecomte <hugo.lecomte@inria.fr>
 ;;; Copyright © 2021 Maxim Cournoyer <maxim.cournoyer@gmail.com>
+;;; Copyright © 2021 Aleksandr Vityazev <avityazev@posteo.org>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -919,7 +920,7 @@ (define-public python-pydata-sphinx-theme
      (list python-beautifulsoup4))
     (native-inputs
      (list python-beautifulsoup4
-           python-docutils
+           python-docutils-0.15
            python-jupyter-sphinx
            python-numpy
            python-numpydoc
-- 
2.34.0



-- 

Aleksandr Vityazev

[bug#52721] [PATCH] gnu: python-pydata-sphinx-theme: Fix build.

[Maxime Devos]

Hi,

> the build fails because a package is required python-docutils < 0.17.

Is python-docutils<0.17 truly required, or are the version requirements
in the source code overly strict? If it's the latter, you could patch
the source code to relax the requirements.

The latter happens often, because library developers often don't know
in advance whether the library is compatible with future versions of
the dependencies.

Greetings,
Maxime.

[bug#52721] [PATCH]v2 gnu: python-pydata-sphinx-theme: Fix build.

[Aleksandr Vityazev]

[-- Attachment #1: Type: text/plain, Size: 781 bytes --]

Hi,
On 2021-12-22, 10:53 +0000, Maxime Devos <maximedevos@telenet.be> wrote:

>> the build fails because a package is required python-docutils < 0.17.
>
> Is python-docutils<0.17 truly required, or are the version requirements
> in the source code overly strict? If it's the latter, you could patch
> the source code to relax the requirements.
>
> The latter happens often, because library developers often don't know
> in advance whether the library is compatible with future versions of
> the dependencies.

For version 0.6.3 there is a file
pydata-sphinx-theme-0.6.3/docs/requirements.txt where the last line
contains:

docutils==0.16 # temporary pin (0.17 broken captions).

Also, the master version requires "docutils!=0.17.0.

So I created a patch that adds an extra phase.


[-- Attachment #2: pydata-sphinx-theme --]
[-- Type: text/x-patch, Size: 1536 bytes --]

From 7301a82b07e73c3bdbeef0d1375094d625336766 Mon Sep 17 00:00:00 2001
Message-Id: <7301a82b07e73c3bdbeef0d1375094d625336766.1640196453.git.avityazev@posteo.org>
From: Aleksandr Vityazev <avityazev@posteo.org>
Date: Wed, 22 Dec 2021 17:25:18 +0300
Subject: [PATCH] gnu: python-pydata-sphinx-theme: Fix build.

* gnu/packages/sphinx (python-pydata-sphinx-theme):
[arguments]: add phase "relax-dependency-requirements".
---
 gnu/packages/sphinx.scm | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/gnu/packages/sphinx.scm b/gnu/packages/sphinx.scm
index 3ac5b5e22c..c9a9a2efbb 100644
--- a/gnu/packages/sphinx.scm
+++ b/gnu/packages/sphinx.scm
@@ -18,6 +18,7 @@
 ;;; Copyright © 2021 Vinicius Monego <monego@posteo.net>
 ;;; Copyright © 2021 Hugo Lecomte <hugo.lecomte@inria.fr>
 ;;; Copyright © 2021 Maxim Cournoyer <maxim.cournoyer@gmail.com>
+;;; Copyright © 2021 Aleksandr Vityazev <avityazev@posteo.org>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -915,6 +916,13 @@ (define-public python-pydata-sphinx-theme
         (base32
          "055bh3hyh72pafiylvgpsjlk18wm15gg4azc5rjlsww5z475iq1j"))))
     (build-system python-build-system)
+    (arguments
+     `(#:phases
+       (modify-phases %standard-phases
+         (add-before 'build 'relax-dependency-requirements
+           (lambda _
+             (substitute* "setup.py"
+               (("docutils<0.17") "docutils")))))))
     (propagated-inputs
      (list python-beautifulsoup4))
     (native-inputs
-- 
2.34.0


[-- Attachment #3: Type: text/plain, Size: 38 bytes --]


-- 
Best regards,
Aleksandr Vityazev

[bug#52721] [PATCH]v2 gnu: python-pydata-sphinx-theme: Fix build.

[Maxime Devos]

Aleksandr Vityazev schreef op wo 22-12-2021 om 18:17 [+0000]:
> 
> > > the build fails because a package is required python-docutils <
> > > 0.17.
> > 
> > Is python-docutils<0.17 truly required, or are the version
> > requirements
> > in the source code overly strict? If it's the latter, you could
> > patch
> > the source code to relax the requirements.
> > 
> > The latter happens often, because library developers often don't
> > know
> > in advance whether the library is compatible with future versions
> > of
> > the dependencies.
> 
> For version 0.6.3 there is a file
> pydata-sphinx-theme-0.6.3/docs/requirements.txt where the last line
> contains:
> 
> docutils==0.16 # temporary pin (0.17 broken captions).
> 
> Also, the master version requires "docutils!=0.17.0.
> 
> So I created a patch that adds an extra phase.

In that case, docutil<0.17 appears to be actually required, so the
solution would be to use docutils=0.15 as you did originally, I think?
Preferably with a comment ; captions are broken in 0.17..

Greetings,
Maxime.

[bug#52721] [PATCH] gnu: python-pydata-sphinx-theme: Fix build.

[Aleksandr Vityazev]

Hi,

On 2021-12-22, 18:25 +0000, Maxime Devos <maximedevos@telenet.be> wrote:

>> For version 0.6.3 there is a file
>> pydata-sphinx-theme-0.6.3/docs/requirements.txt where the last line
>> contains:
>> 
>> docutils==0.16 # temporary pin (0.17 broken captions).
>> 
>> Also, the master version requires "docutils!=0.17.0.
>> 
>> So I created a patch that adds an extra phase.
>
> In that case, docutil<0.17 appears to be actually required, so the
> solution would be to use docutils=0.15 as you did originally, I think?
> Preferably with a comment ; captions are broken in 0.17..
>

These were pushed by Efraim Flashner with
8efa775653f78dad8b254e719677e663be8f3240.

-- 
Best regards,
Aleksandr Vityazev

bug#52721: [PATCH] gnu: python-pydata-sphinx-theme: Fix build.

[Efraim Flashner]

[-- Attachment #1: Type: text/plain, Size: 1083 bytes --]

On Thu, Dec 23, 2021 at 10:54:27PM +0000, Aleksandr Vityazev wrote:
> Hi,
> 
> On 2021-12-22, 18:25 +0000, Maxime Devos <maximedevos@telenet.be> wrote:
> 
> >> For version 0.6.3 there is a file
> >> pydata-sphinx-theme-0.6.3/docs/requirements.txt where the last line
> >> contains:
> >> 
> >> docutils==0.16 # temporary pin (0.17 broken captions).
> >> 
> >> Also, the master version requires "docutils!=0.17.0.
> >> 
> >> So I created a patch that adds an extra phase.
> >
> > In that case, docutil<0.17 appears to be actually required, so the
> > solution would be to use docutils=0.15 as you did originally, I think?
> > Preferably with a comment ; captions are broken in 0.17..
> >
> 
> These were pushed by Efraim Flashner with
> 8efa775653f78dad8b254e719677e663be8f3240.
> 

Sorry, I didn't check for patches before working on this patch.

-- 
Efraim Flashner   <efraim@flashner.co.il>   רנשלפ םירפא
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]