From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id qNVKKBXrE2LwewEAgWs5BA (envelope-from ) for ; Mon, 21 Feb 2022 20:42:13 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id 8FU0IRXrE2LgyAAAG6o9tA (envelope-from ) for ; Mon, 21 Feb 2022 20:42:13 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 06965193D5 for ; Mon, 21 Feb 2022 20:42:08 +0100 (CET) Received: from localhost ([::1]:51676 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nMEZQ-00005s-SC for larch@yhetil.org; Mon, 21 Feb 2022 14:42:04 -0500 Received: from eggs.gnu.org ([209.51.188.92]:34130) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nMEYQ-0007uN-Cg for guix-patches@gnu.org; Mon, 21 Feb 2022 14:41:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:45319) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nMEYQ-0005kj-3I for guix-patches@gnu.org; Mon, 21 Feb 2022 14:41:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nMEYP-00040Y-SM for guix-patches@gnu.org; Mon, 21 Feb 2022 14:41:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#54069] [PATCH 0/2] gnu: pciutils: Unbundle pci.ids and use latest. Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 21 Feb 2022 19:41:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54069 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Brendan Tildesley Cc: 54069@debbugs.gnu.org Received: via spool by 54069-submit@debbugs.gnu.org id=B54069.164547244915380 (code B ref 54069); Mon, 21 Feb 2022 19:41:01 +0000 Received: (at 54069) by debbugs.gnu.org; 21 Feb 2022 19:40:49 +0000 Received: from localhost ([127.0.0.1]:39216 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nMEYC-0003zz-En for submit@debbugs.gnu.org; Mon, 21 Feb 2022 14:40:48 -0500 Received: from mail-qv1-f47.google.com ([209.85.219.47]:41815) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nMEYA-0003zl-Au for 54069@debbugs.gnu.org; Mon, 21 Feb 2022 14:40:46 -0500 Received: by mail-qv1-f47.google.com with SMTP id x3so34577297qvd.8 for <54069@debbugs.gnu.org>; Mon, 21 Feb 2022 11:40:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=7W4Seb7EZqKZhN2AGFouzZOMDG9QJDwVNJ2JOoO/dHA=; b=hiFeZY4JuzvB8afZKx8RNxLij/JzjJA2V0F5wqz/ugGGfOdacJP+nGfZqmn147p6u/ rGYtUwui+/o3GqUMGLYw+3y0blJNPqVWs4J802/hU+gxUyQll81mdZFidzF5XVLRyuDH /FE98VESf0iFOuHVIomHkGE+06fPN1/r6Tg9a9aCq4lzD3+Zyc1rBtOOK8+PH3uxRRvj JUiuzJXOfwKz5cbklshUnFhKHANvO72hkD7Ck88fD8LMo+/L0rtxIMeTcfBeC/pzs1vH vfRurO8tf2BDWMccZiTA0ThX7SnCtVGs+tSD+u8HraYoI3bEkRabVlAWS9Cl3oR04Vkb skqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=7W4Seb7EZqKZhN2AGFouzZOMDG9QJDwVNJ2JOoO/dHA=; b=1u8F0YOxXCmjV1afteUHQegzwtyKchFUC6oAXt+sO4GGQFqmuPARvwOW0hzDSnzDw+ k42AYYjX5i5WIlUIZP2ChgSS3WVJ7n+ZhmBy+0uMHpEdyvTHJZbzDO8vps/vt3LisoZ3 6zvuM7sTXdwNGeZLed01cBKq5+Rsq8rmT8gwGdktvqJOy4vRHMapShRbVnn5lOPHDIFY qWORSE/513EAIxIPDHiXc6UJkefd2ZzVG7RAFBKh/LIyAzdjNBZFarolODGMgX8W7pIe ILsnj0rbYZ76i8KKDSh8X8bTP7vyAxp37+RTOPtoJSCGreFrfkuaOa9IABjkjgaKheZo Ojvg== X-Gm-Message-State: AOAM530hD5QxmSZEhjT7K8JjQ2GcgT99DJl28Mkhflvc81F4XEubrkYO 9Rzlq0Ad0lBKemHvKJw5DdjVp5q98I4= X-Google-Smtp-Source: ABdhPJy8rfKk8TO9T6yyz2dfsQBd6RDSXxtJ25BBlLpZF5t4qpVYpR7BVEUwRIgxVkfKwTplV3hTMw== X-Received: by 2002:ad4:5cad:0:b0:42c:308:2b3 with SMTP id q13-20020ad45cad000000b0042c030802b3mr16256544qvh.59.1645472440268; Mon, 21 Feb 2022 11:40:40 -0800 (PST) Received: from hurd (dsl-10-149-208.b2b2c.ca. [72.10.149.208]) by smtp.gmail.com with ESMTPSA id d11sm31861499qte.10.2022.02.21.11.40.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Feb 2022 11:40:39 -0800 (PST) From: Maxim Cournoyer References: <20220220095557.1497-1-mail@brendan.scot> <20220220095557.1497-2-mail@brendan.scot> Date: Mon, 21 Feb 2022 14:40:38 -0500 In-Reply-To: <20220220095557.1497-2-mail@brendan.scot> (Brendan Tildesley's message of "Sun, 20 Feb 2022 20:55:57 +1100") Message-ID: <87r17wnh3d.fsf_-_@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1645472529; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=7W4Seb7EZqKZhN2AGFouzZOMDG9QJDwVNJ2JOoO/dHA=; b=RDCj0Q2jbAI5ekiQWXCfnw844s/zkVFwXTL6jCmz0dG6CQwxdK9W9MW7Jd4+/lG5ZjsPzt DJbWuMXG9olcFi4A4oPttFouxe8XSmP+EvcwAzb3toRijTslKjiKTJ1LvUGVjm8dYt1GL1 z17798EiRRvsZF/oiYbz8Nf38542ensZjUSyTMoznVsZzGG7m1HKDszjNH0CkwLm9vuI5x imJyOfFqGmI00LrPfu9sU9LQ6CAgZQ5VRmDWVBk7JZsnV1s8Bym/pjFY1cjKJZVI+MQuhU owlq5ZN5k7aowNRKvvMuuBA6tIJFCP9XL7mencjEKDW0MODimt3Suusypm41kw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1645472529; a=rsa-sha256; cv=none; b=jeVpzveOujBxCr03w1HpK4PZxl3AqZvAtszSy04QW7B4D9ySZojHkbc0e7UtXIrwKxwsSb YVb6gtteQ6QCyUzaWcqbFtm2YBqhjh1ATz4QfZu6XHlkac/j7xJNGg+AKP9966De/fFrm0 wp8I9mY4tX6auUJz04HxuQyk5r//9FVAQoYNtgd3FOZwle0x0ra9MRG0+RFAW8xRtd50ph XtsoTUlK+rsDi19yZN0g+ZzNwv4cmf8Cb2Fkp0g+VSUTbS4XeO0d7V5a6661nQxAZ0uoPp fMur8+ZEOFcU3IQGKlwUcL7TBlujrZKbgVlvfNUWJsqKkyMJG96wfog873gW3g== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=hiFeZY4J; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -2.03 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=hiFeZY4J; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 06965193D5 X-Spam-Score: -2.03 X-Migadu-Scanner: scn1.migadu.com X-TUID: LRv6KkKqbot1 Hi, Brendan Tildesley writes: > * gnu/packages/pciutils.scm (pciutils): > [inputs]: Remove zlib. Add hwdata. pci.ids was never gzip'd anyway. > [arguments]: Don't install update-pciids script or it's man page. Don't > install bundled old pci.ids file. Copy pci.ids file from latest hwdata package. > --- > gnu/packages/pciutils.scm | 25 ++++++++++++++++++------- > 1 file changed, 18 insertions(+), 7 deletions(-) > > diff --git a/gnu/packages/pciutils.scm b/gnu/packages/pciutils.scm > index 416328bda2..3975854f84 100644 > --- a/gnu/packages/pciutils.scm > +++ b/gnu/packages/pciutils.scm > @@ -110,17 +110,28 @@ (define-public pciutils > (("^SHARED=.*$") > ;; Build libpciutils.so. > "SHARED := yes\n") > - (("^ZLIB=.*$") > - ;; Ask for zlib support, for 'pci.ids.gz' decompression. > - "ZLIB := yes\n") It seems to me perhaps a more proper fix would be to have hwdata used as an input, replacing the bundled copy of the pci.ids file file, and then letting pciutils proceed as usual? Disabling compression makes the database about 4.3 times larger (1.2 MiB instead of 0.273 MiB). I feel like applications parsing pci.ids themselves should probably rely on the pciutils library API instead (libpci.so) to retrieve or filter PCI identifiers without being concerned with the actual format of the database. What do others think? Maxim