From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id WGIUE6P4PWKQywAAgWs5BA (envelope-from ) for ; Fri, 25 Mar 2022 18:15:15 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id +NibC6P4PWLLBwAAG6o9tA (envelope-from ) for ; Fri, 25 Mar 2022 18:15:15 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id D84D02EAF5 for ; Fri, 25 Mar 2022 18:15:14 +0100 (CET) Received: from localhost ([::1]:41244 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nXnWr-0001gz-UE for larch@yhetil.org; Fri, 25 Mar 2022 13:15:13 -0400 Received: from eggs.gnu.org ([209.51.188.92]:36968) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nXnWh-0001gg-8X for guix-patches@gnu.org; Fri, 25 Mar 2022 13:15:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:58447) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nXnWh-0000MP-0J for guix-patches@gnu.org; Fri, 25 Mar 2022 13:15:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nXnWg-0003tu-Ih for guix-patches@gnu.org; Fri, 25 Mar 2022 13:15:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#54090] [PATCH v3] gnu: Add tessen. Resent-From: Andrew Tropin Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 25 Mar 2022 17:15:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54090 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Tanguy LE CARROUR , 54090@debbugs.gnu.org Cc: ludo@gnu.org, maximedevos@telenet.be, mail@nicolasgoaziou.fr Received: via spool by 54090-submit@debbugs.gnu.org id=B54090.164822847014943 (code B ref 54090); Fri, 25 Mar 2022 17:15:02 +0000 Received: (at 54090) by debbugs.gnu.org; 25 Mar 2022 17:14:30 +0000 Received: from localhost ([127.0.0.1]:52344 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nXnW9-0003sw-UO for submit@debbugs.gnu.org; Fri, 25 Mar 2022 13:14:30 -0400 Received: from relay6-d.mail.gandi.net ([217.70.183.198]:38459) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nXnW8-0003sg-A3 for 54090@debbugs.gnu.org; Fri, 25 Mar 2022 13:14:28 -0400 Received: (Authenticated sender: andrew@trop.in) by mail.gandi.net (Postfix) with ESMTPSA id 000A9C000A; Fri, 25 Mar 2022 17:14:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=trop.in; s=gm1; t=1648228462; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=aAI/KqABefGZRS5PuO4Mi+EZjkeLjKtOseNI/gn4O5c=; b=f/pui7nkMOJInm6dmjnPr8o6NyOInRb04C8oX2AefXi2tTSMVWDWB2XWJoL3qkJKyKPqfR IP7oXu/N//n/78VhRvwp+V+HndBooptoXjQxIvbpeJ1wHM4TbP1bLZyWXRscbXtloxqtFI NMAgDW09TyUikVfu5rYvxTukErOvqeIbqMe3pVH/U0d30v1bI8r74YmEVCXJLGCs6oT4fj A8Xc2+bY9quYm6Rm1d+CceL6k7qY1K5UxvCaS74HjU5AZrCa5OZl8tNArPPDCriYtDkLis qFE+ZUMHEcgUk9uDzBVvpUKZXsATRCbd54kZTHOblkfhOL2EjWhqUAAVsLpbaQ== From: Andrew Tropin In-Reply-To: <164822534548.5280.15088787905790996561@localhost> References: <20220221174340.2287-1-tanguy@bioneland.org> <20220311075412.17869-1-tanguy@bioneland.org> <87y20y2hlq.fsf@trop.in> <164822534548.5280.15088787905790996561@localhost> Date: Fri, 25 Mar 2022 20:14:17 +0300 Message-ID: <87r16q2bva.fsf@trop.in> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1648228515; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=aAI/KqABefGZRS5PuO4Mi+EZjkeLjKtOseNI/gn4O5c=; b=AaOYwVUP9fn4KKhPPEtDGBueUs/StuhRQ42MURR2zG9L6naWWaOXeeLBDhRigb1ve8pGV4 M6JMXkZthP1mZKPysdbllg3yC+DibyqfjptI2Y58pfD2sZA0+RQTnA3raoXG+v/SbfWWDF vrOik52XB0bKqQ5K/XyagvnzM8IvdRJul8KidxyQ5mpybCZssPsiZ2+WeRo6liBjZI6FQt CPZpOKTZo/aaOnHxvsYoZraRn2GOIgk9emdpbI7jLbPcWCRW/rGy+B27eaOeUzffdZaoJU KkthKiNtR4UpMhDyO7gzUuLaEDoUTc9iCAKMRq05B3H3fLoqO515RS8k7aD7vA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1648228515; a=rsa-sha256; cv=none; b=q8ttFUd9xArC3k4GdtjjKyXhWrx5kVxXtuQLE1f7KIO8Y9AWJ3QwbDf/ZlV6IuI7TS+v/5 36Z/r2vwBW8fkU0DH1GA2cOKBv4vOl9KR1hWHUhQYrg+NeLYZvZ7DB5uEiy1EcBqE9YH7n MXrtePcM4astGzFERpuZMHtc0Zhjhv1GPSc6HAc0Rfhe8LE2gJfIsvREkmxqAHFb+qqLGr Ddo7KDBdyNjbkrg9KwJgNX1S9gX+C5/6CZaoV8j+jCy8c079qejkDg05h2MwiiHaLl1EcU 5pvkeqJE2wFzDzfkdvIgIWBk5qxA/ukREFUYizpkRXBb4U0lH3/xA1ak3WgFSQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=trop.in header.s=gm1 header.b="f/pui7nk"; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -1.28 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=trop.in header.s=gm1 header.b="f/pui7nk"; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: D84D02EAF5 X-Spam-Score: -1.28 X-Migadu-Scanner: scn1.migadu.com X-TUID: c2qo7fRwZgGM --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 2022-03-25 17:22, Tanguy LE CARROUR wrote: > Hi Andrew, > > > Quoting Andrew Tropin (2022-03-25 16:10:25) >> On 2022-03-11 08:54, Tanguy Le Carrour wrote: >>=20 >> > * gnu/packages/password-utils.scm (tessen): New variable. >> > [=E2=80=A6] >> > + (arguments >> > + (list #:tests? >> > + #f ;no tests >> > + #:phases >> > + #~(modify-phases %standard-phases >> > + (add-after 'unpack 'patch-wtype-path >> > + (lambda* (#:key inputs #:allow-other-keys) >> > + (substitute* "tessen" >> > + (("wtype") (search-input-file inputs "/bin/wtype= "))))) >> > + (delete 'configure)) ;no configure script >> > + #:make-flags >> > + #~(list (string-append "PREFIX=3D" >> > [=E2=80=A6] >>=20 >> Sorry, for comming up late, but the path to wl-copy binary should be >> hardcoded as well. >>=20 >> /gnu/store/f48prcjwpw8wrfz0srjf096a9s8fja2w-profile/bin/tessen: line 476= : wl-copy: command not found > > Oh, my bad! I'm not using the "copy to clipboard" feature. Fortunatly, > the patch is trivial. But, before submitting it, I have a question!=E2=80= =A6 > > Why not also add as inputs and substitute `pass`, `gopass`, `wofi`, We can't hardcode pass, because it's an optional dependency with explicit alternative and user can prefer gopass, so we keep tessen to use the first option available in $PATH and fail if there is no pass or gopass available. The same for rofi, fuzzel, bemenu, wofi, dmenu. Due to design of tessen we can't know "compile time", which one will be used. > `notify-send`, `xdg-open`=E2=80=A6 that are also used by tessen?! IMO, notify-send and xdg-open are good candidates for inclusion to inputs. =2D-=20 Best regards, Andrew Tropin --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJDBAEBCgAtFiEEKEGaxlA4dEDH6S/6IgjSCVjB3rAFAmI9+GkPHGFuZHJld0B0 cm9wLmluAAoJECII0glYwd6w4gcQAJMZYDBT4KAykdBo/sUwbsbvCCh1qbIzSzjY ixz87Y+Y3Q0AMqcxqNsr9emOincHDyHDFTbsF24SYH+Pr0QWm6bad2zYznTfSCr4 PiY+sh3fp0yOg019IdoDlHAV8eT8+NcA8kze7UlLIIqHhZpOk1WJRiMg3vQtZ8a7 eUFOQy0ro9gmRc3WPsS/A9I9vDMdI4KrFuVp5dBqtH7GMYccPMCAW7/S1hn7fAMI KM0XQzJbbJL8XxMdVNLQBLlF7kq2WH7Hi1XewUmJk3O5f6pLjkmvW0YplaGJCgkP jPFbUdfCs6IBrA/SUUUObegiT6DO8JmHwHMtCMyk1x1aERGBQnrYkdB5Wl9S17Ak p1Y5zdoM8zPjA25tL+GPK+5VxraxXEYtI0lDNKRyauegM/rOQqae0aTFz4YJ2CYf IS+41gzpiuXWnateBsovaGdvKHIQHqq4b5FzsjjE5ng7Rfw6u/bLk98ilHGSzoRv /cwNH+qncJqH7TvAZ6aWgz2bFXVgE47STuZQT4fKDCZcCvwEHelJRct7HCtzs7+x DnYUY0hRqAKj0Gf4xuDWiusC0ooe9BZrJ0qJYsXWmIqC2R6+8ovR0x2zN7hm2Mo3 zTAPGsWo9sFJBLurt9J1tkSrV6iS+1/5NIpjVymPvMXi6DEiEFNurf7JQKNEwKwP mjFaWY4s =7/wZ -----END PGP SIGNATURE----- --=-=-=--