From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id mEtZCRutiWKtIQAAbAwnHQ (envelope-from ) for ; Sun, 22 May 2022 05:25:15 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id 8K5NCRutiWIyfQEA9RJhRA (envelope-from ) for ; Sun, 22 May 2022 05:25:15 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id A2830246C5 for ; Sun, 22 May 2022 05:25:14 +0200 (CEST) Received: from localhost ([::1]:55244 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nscDQ-0003JQ-SK for larch@yhetil.org; Sat, 21 May 2022 23:25:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36616) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nscDG-0003Iv-3C for guix-patches@gnu.org; Sat, 21 May 2022 23:25:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:49442) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nscDF-000426-QE for guix-patches@gnu.org; Sat, 21 May 2022 23:25:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nscDF-0006TY-KK for guix-patches@gnu.org; Sat, 21 May 2022 23:25:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#46160] [PATCH] Add new plplot Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 22 May 2022 03:25:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46160 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Sharlatan Hellseher Cc: 46160@debbugs.gnu.org Received: via spool by 46160-submit@debbugs.gnu.org id=B46160.165318985324818 (code B ref 46160); Sun, 22 May 2022 03:25:01 +0000 Received: (at 46160) by debbugs.gnu.org; 22 May 2022 03:24:13 +0000 Received: from localhost ([127.0.0.1]:43336 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nscCS-0006SD-FB for submit@debbugs.gnu.org; Sat, 21 May 2022 23:24:13 -0400 Received: from mail-qt1-f182.google.com ([209.85.160.182]:39488) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nscCN-0006Rx-LL for 46160@debbugs.gnu.org; Sat, 21 May 2022 23:24:11 -0400 Received: by mail-qt1-f182.google.com with SMTP id x7so7346608qta.6 for <46160@debbugs.gnu.org>; Sat, 21 May 2022 20:24:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=AihvISlZJBuJ87JomuCBdDsyZHFoRxDTN4uxML89nic=; b=HfSeast67Ll13I3+ZPuqK6P4Ja8PDuNhR+DS2SDnLbiCa2MexXaQ/1H8aDE8A7Zci/ HzOcMMhEm0cbnJOz6Pw/XV5dMv2q6ae/U2kPiZ/9IElbDnDT6bwCsHzhau6Kj8tuik7E wxygUfgYWSmFqF+AFWC8mecDtRoeidyvHrjmWe6dmgBicknxL9ClPkojaE+3CUAmhuXG Wj5EvJ10fjlOasKRbmaZWl3Xgdr4U28yxnytwFKHw+R3xVnMnQl6fdCQo7H7lTwu8+jX xEiCG5wg0l5vNp6QVdBnrr1I0XN/lMqxsGrs+kZesCercOgwAoTwSD6G+zYCoUiuWNjb KuaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=AihvISlZJBuJ87JomuCBdDsyZHFoRxDTN4uxML89nic=; b=qpf+0L21UmmYPp5zSNvHHCGqV4X1HHosHONSe9Tjbwu4hxPPkh6KEz7DpJbzRN6XtE jOeaWQHNBjRqcumD1Cipd75rkLDUwE0hgiPFUMf78gmXVyN6iJqj9axlOUBZMySQjGOR jBZ1bBmuxHSZVTsEEl0oXRtbp5y7Mi91zTf6NVW/XCBo+Ge1+Ppu0bOwCashYxC1qkj5 FwEK6WGzf4vep+iSpj99MhKhuP6TIJWVBwrqAQ+/r9jFi33CjFIx2ljrBeDzcI1MonW2 /oVToFVyLZlonOBnzOh3pmqE7O8szNBnOlI3+kthtUR6iPtYQn0ry8B55EobwLOmVyXl cXgA== X-Gm-Message-State: AOAM530124hV6/Q/QIWc56pAA9Gi4e1QJCrAXlTdfwqD8f5BTSwoRJN4 rj1fMoyg8XG7gl4hMtJK0Oikb7rharii0VTj X-Google-Smtp-Source: ABdhPJyDTv5h3C7stbG+2yGNG/OpH21WOo4DCgIXdLOLwc20rVTz+ZjbaAZSDKxwrWpobvOTKA7XHA== X-Received: by 2002:a05:622a:1825:b0:2f9:3393:22fa with SMTP id t37-20020a05622a182500b002f9339322famr807704qtc.523.1653189841712; Sat, 21 May 2022 20:24:01 -0700 (PDT) Received: from hurd (dsl-152-80.b2b2c.ca. [66.158.152.80]) by smtp.gmail.com with ESMTPSA id m24-20020ac866d8000000b002f932d920ccsm736893qtp.64.2022.05.21.20.24.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 21 May 2022 20:24:01 -0700 (PDT) From: Maxim Cournoyer References: Date: Sat, 21 May 2022 23:24:00 -0400 In-Reply-To: (Sharlatan Hellseher's message of "Fri, 13 May 2022 16:30:39 +0100") Message-ID: <87r14m8d2n.fsf_-_@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1653189914; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=AihvISlZJBuJ87JomuCBdDsyZHFoRxDTN4uxML89nic=; b=k2cxbyXtlh7Mink6ovbHMpSt0hk+vkdDrmfXVD57QRvkcyT4I1d1H+0UN/avZLVTI70p5D nJNz063rEotRIwDCkDtBRVVlMFW8eTWFhjLO0l9QVVXBk7in3jKV3IUfNCNPK2wGR3fo7U WyVwu1lpkVPvPWG9UsQBLHb6gB77HR1BD/UFKcfz+eNGWRJuKyk5zB4RnghiWZYXqC40fc sgINzAOSap7xFUmZlH9QFla02Q8vo6HdZPFKg27neqYx42CHkL+aAC5Xoyx+Y17cKY/ddf sWhHgr6YON5zzkVqwDcgNkPfEyC7Y4KgyhTqozbWQnLC+8rytVRnwQTbuICX6Q== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1653189914; a=rsa-sha256; cv=none; b=cNgYRSnz3pKWkQ9adgCPBcVv5figWGVPew2FLEXjFfqwycI9WagE33WVTlpDjMWcqkSMBX IXZwxg7caphM076s0PfGBAA+Lz0jJi6q9IvtBsVk6lZ93t6PPaZXfMlsqi+YKJhMDfO3he sV4M14LnmZySFDJHqtMDsC/+bkOIZo2dm191UI5YHkk9S2EJe9/uDEyW24SYULmzKUIPbh +qBqJ70B+iAFBJyADJikDFveVTjEpF7NSV+t4AZXf2AQDZ26JhMpgfSrhC9DPogH0KXiCx 1ptdJw0/0Rr8P6lOfOf9jsh3kPFlIKAUY0WvQWpzKtDNUeu+VCDZhlNmP62jog== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=HfSeast6; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 4.65 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=HfSeast6; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: A2830246C5 X-Spam-Score: 4.65 X-Migadu-Scanner: scn0.migadu.com X-TUID: 58VRvU5XdOxV Hi, Sharlatan Hellseher writes: > Hi Guix team! > > This is fixed version of the patch adding plplot with all test enabled > and folowing new packge style fromat. > > > > --=20 > =E2=80=A6 =D0=BD=D0=B0=D1=88 =D1=80=D0=B0=D0=B7=D1=83=D0=BC - =D0=BF=D1= =80=D0=B5=D0=B2=D0=BE=D1=81=D1=85=D0=BE=D0=B4=D0=BD=D0=B0=D1=8F =D0=BE=D0= =B1=D1=8A=D1=8F=D1=81=D0=BD=D0=B8=D1=82=D0=B5=D0=BB=D1=8C=D0=BD=D0=B0=D1=8F= =D0=BC=D0=B0=D1=88=D0=B8=D0=BD=D0=B0 =D0=BA=D0=BE=D1=82=D0=BE=D1=80=D0=B0= =D1=8F =D1=81=D0=BF=D0=BE=D1=81=D0=BE=D0=B1=D0=BD=D0=B0 > =D0=BD=D0=B0=D0=B9=D1=82=D0=B8 =D1=81=D0=BC=D1=8B=D1=81=D0=BB =D0=BF=D0= =BE=D1=87=D1=82=D0=B8 =D0=B2 =D1=87=D0=B5=D0=BC =D1=83=D0=B3=D0=BE=D0=B4=D0= =BD=D0=BE, =D0=B8=D1=81=D1=82=D0=BE=D0=BB=D0=BA=D0=BE=D0=B2=D0=B0=D1=82=D1= =8C =D0=BB=D1=8E=D0=B1=D0=BE=D0=B9 =D1=84=D0=B5=D0=BD=D0=BE=D0=BC=D0=B5=D0= =BD, =D0=BD=D0=BE > =D1=81=D0=BE=D0=B2=D0=B5=D1=80=D1=88=D0=B5=D0=BD=D0=BD=D0=BE =D0=BD=D0=B5= =D0=B2 =D1=81=D0=BE=D1=81=D1=82=D0=BE=D1=8F=D0=BD=D0=B8=D0=B8 =D0=BF=D1=80= =D0=B8=D0=BD=D1=8F=D1=82=D1=8C =D0=BC=D1=8B=D1=81=D0=BB=D1=8C =D0=BE =D0=BD= =D0=B5=D0=BF=D1=80=D0=B5=D0=B4=D1=81=D0=BA=D0=B0=D0=B7=D1=83=D0=B5=D0=BC=D0= =BE=D1=81=D1=82=D0=B8. > > From f190a7f646d8f1d7d212663a629adeb33414eb6a Mon Sep 17 00:00:00 2001 > From: Sharlatan Hellseher > Date: Fri, 13 May 2022 16:13:57 +0100 > Subject: [PATCH] gnu: Add plplot > > * gnu/packages/maths.scm (plplot): New variable. > --- > gnu/packages/maths.scm | 55 ++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 55 insertions(+) > > diff --git a/gnu/packages/maths.scm b/gnu/packages/maths.scm > index 98e239d5bd..641b80f572 100644 > --- a/gnu/packages/maths.scm > +++ b/gnu/packages/maths.scm > @@ -50,6 +50,7 @@ > ;;; Copyright =C2=A9 2021 Jean-Baptiste Volatier > ;;; Copyright =C2=A9 2021 Guillaume Le Vaillant > ;;; Copyright =C2=A9 2021 Pierre-Antoine Bouttier > +;;; Copyright =C2=A9 2022 Sharlatan Hellseher > ;;; > ;;; This file is part of GNU Guix. > ;;; > @@ -123,6 +124,7 @@ (define-module (gnu packages maths) > #:use-module (gnu packages llvm) > #:use-module (gnu packages logging) > #:use-module (gnu packages lua) > + #:use-module (gnu packages geo) > #:use-module (gnu packages gnome) > #:use-module (gnu packages guile) > #:use-module (gnu packages xorg) > @@ -152,6 +154,7 @@ (define-module (gnu packages maths) > #:use-module (gnu packages serialization) > #:use-module (gnu packages shells) > #:use-module (gnu packages sphinx) > + #:use-module (gnu packages swig) > #:use-module (gnu packages tcl) > #:use-module (gnu packages texinfo) > #:use-module (gnu packages tex) > @@ -1123,6 +1126,58 @@ (define-public gnuplot > (license (license:fsf-free > "http://gnuplot.cvs.sourceforge.net/gnuplot/gnuplot/Copyri= ght")))) >=20=20 > +(define-public plplot > + (package > + (name "plplot") > + (version "5.15.0") > + (source > + (origin > + (method git-fetch) > + (uri (git-reference > + ;; Mirror: https://github.com/PLplot/PLplot > + (url "https://git.code.sf.net/p/plplot/plplot") > + (commit (string-append name "-" version)))) > + (sha256 > + (base32 > + "0fn9j251zv9pwlqy30yv4flwcd0cbyxd1nn388n1k158jycw2i91")) > + (file-name (git-file-name name version)))) > + (build-system cmake-build-system) > + (arguments > + (list > + #:configure-flags > + #~(list > + "-DBUILD_TEST=3DON" > + (string-append "-DCMAKE_INSTALL_LIBDIR=3D" #$output "/lib") > + (string-append "-DCMAKE_INSTALL_PREFIX=3D" #$output)))) > + (native-inputs > + (list perl > + python-wrapper > + pkg-config > + swig)) > + (inputs > + (list freetype > + camlidl > + gfortran > + libltdl > + lua > + ocaml > + octave > + pango > + perl-xml-dom > + perl-xml-parser Are you sure the Perl XML modules are needed at runtime and not at build time (to build doc, for example?). > + python-numpy If python-numpy is refered at runtime, you'd need to also add python-wrapper as an 'input' I believe, since numpy is a Python library. One good way to verify if the dependencies are correct is to run the package in a container with: $ ./pre-inst-env guix shell -C plplot and see if something fail. Another telling data point to shake extraneous dependencies is looking at the output of 'guix gc -R $(./pre-inst-env guix build plplot)'; if python-numpy is not there (probably it isn't), but really needed at runtime, then it'd need to be wrapper in the plplot command script. Could you verify that the package works in a container, adding a wrap phase if needed or removing the unneeded inputs? Thanks! Maxim