From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id yKe/EbhSx2J/SQEAbAwnHQ (envelope-from ) for ; Thu, 07 Jul 2022 23:40:08 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id SJWOEbhSx2JuVAAAauVa8A (envelope-from ) for ; Thu, 07 Jul 2022 23:40:08 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 0AC50DC36 for ; Thu, 7 Jul 2022 23:40:08 +0200 (CEST) Received: from localhost ([::1]:36156 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o9ZEF-00018m-3x for larch@yhetil.org; Thu, 07 Jul 2022 17:40:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57418) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o9ZEA-00018U-BD for guix-patches@gnu.org; Thu, 07 Jul 2022 17:40:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:36069) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o9ZEA-0001Ml-1z for guix-patches@gnu.org; Thu, 07 Jul 2022 17:40:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1o9ZEA-0008P4-0G for guix-patches@gnu.org; Thu, 07 Jul 2022 17:40:02 -0400 Subject: bug#56387: [PATCH] computed-file: Clarify comment about guile record field. Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-To: guix-patches@gnu.org Resent-Date: Thu, 07 Jul 2022 21:40:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 56387 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: jgart Cc: 56387-done@debbugs.gnu.org Mail-Followup-To: 56387@debbugs.gnu.org, maxim.cournoyer@gmail.com, jgart@dismail.de Received: via spool by 56387-done@debbugs.gnu.org id=D56387.165722998132264 (code D ref 56387); Thu, 07 Jul 2022 21:40:01 +0000 Received: (at 56387-done) by debbugs.gnu.org; 7 Jul 2022 21:39:41 +0000 Received: from localhost ([127.0.0.1]:58197 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o9ZDp-0008OK-5w for submit@debbugs.gnu.org; Thu, 07 Jul 2022 17:39:41 -0400 Received: from mail-qt1-f179.google.com ([209.85.160.179]:33592) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o9ZDm-0008O5-Et for 56387-done@debbugs.gnu.org; Thu, 07 Jul 2022 17:39:39 -0400 Received: by mail-qt1-f179.google.com with SMTP id r2so24741652qta.0 for <56387-done@debbugs.gnu.org>; Thu, 07 Jul 2022 14:39:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=eOZ6AItGE9Zvx7ISD4L0G/yz627X51sbDaHXhNythFQ=; b=J2V8/2eStQW+E5UBQEO39y2u3GXIdP8+WbHUpdItWZuf3hJDsHVv6No/o4KdQWIYWD pg+3BtdNzLdZoVJvhF7Uli0kxKbkIJRvqtH01elmLKHnn7HA+WAeEv7AqjpSeCtzzTRU Ylik8mLzNxs1EQP2iLJHattNZo8cZ5rqXwU+euX9ZtmAdKWTKLCNXppwjnXU/lhlMh+z ifOKUsi8P9cU1w7JEsfXZy47BDLw0j5qWzRk3iaRs5FFu5JVTeAbHDgiZbVQlMC0VTtG dtrlnZyqVqlOJXblZtpmz+zEEL+D2Jg4iS0r7q1WpAr7l1void5De4YkQZ0dJpndVkpn MaRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=eOZ6AItGE9Zvx7ISD4L0G/yz627X51sbDaHXhNythFQ=; b=1SY+PUp/0gHvQ1haohmUh/R7XSSwdsUuvo0Azx0AtQeIYvNHme13CEL49zcqRnxd6b 2mRoKT6OyijxNglP9YEmPlvey+mJP20pgA77Kuw3bOl6OSNX+7YaLdCrSKVdvQttZSeX 1fgFDUyqmQIIhThzPSv9dsFgw1zW2ez8qiEZ8stSsxSZud+AEbwgxi90UTWIG2omSJMF r04Wrr9LmYimGzh9oQd6POlGphCjB1B1f/pJRtXP/O6/BK0fgbaIBtMxgX7mdWR1sF4C mLLw2wKIZlrcKj9xN/qQ4nDVsEVQDt5+moZwQTbrsNCc+Cnx8XtgPgiVDJGgcpL5QorA cq7A== X-Gm-Message-State: AJIora+ynfzthQJbD8dbDwoDQKDNonvLJhvYMwS87tfgQTL6oIqpXJ4H a84G2r+lpxF2s+tMhbyOjlrWl21QAJ0wPMt4 X-Google-Smtp-Source: AGRyM1sKTps4VeE7QgjhkqvDVOEMjFiSBKFz5y7Rcg4eSxA6JBVTX9PEpSyEfRKHa/kIN7ZTKCyvQA== X-Received: by 2002:a0c:ab8f:0:b0:473:2937:a05f with SMTP id j15-20020a0cab8f000000b004732937a05fmr155306qvb.90.1657229972585; Thu, 07 Jul 2022 14:39:32 -0700 (PDT) Received: from hurd (dsl-153-127.b2b2c.ca. [66.158.153.127]) by smtp.gmail.com with ESMTPSA id y11-20020a05620a44cb00b006a37eb728cfsm29088313qkp.1.2022.07.07.14.39.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 Jul 2022 14:39:32 -0700 (PDT) From: Maxim Cournoyer References: <20220704200228.17157-1-jgart@dismail.de> Date: Thu, 07 Jul 2022 17:39:31 -0400 In-Reply-To: <20220704200228.17157-1-jgart@dismail.de> (jgart@dismail.de's message of "Mon, 4 Jul 2022 15:02:28 -0500") Message-ID: <87r12wvbzg.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1657230008; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-to:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=eOZ6AItGE9Zvx7ISD4L0G/yz627X51sbDaHXhNythFQ=; b=tpZqk0JzPsEhvCfhDMLVgjvazPyUNbJnZPv/5USfHIc8r7dozPRipJ5rHrxIs3LwI0SczJ iOBG9rhCCr/oN3LTKqW9q0Lr7q62WEjxd8xDKz72eTFEFF8Q1Q4huKZ6+t5EHQkTfVODY4 fc936vH36qKu5ythOm6jfraz0oaNqfkBUteZ/bkXaCKe7i57s4tAlrsjgzS6pRTx5cjvID sr/+N/47QnVRf9DseQ2klMApPHodtqkkwI1Qg+q9aNBJllAMA3gdRdkmaV7d/62+T05yy4 xNbeYqBJZVwJYEY85mv4Q1XTrL79ztP9PJBms/CdYV2yQBOZp/6Ku4BpmTIa1w== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1657230008; a=rsa-sha256; cv=none; b=ZcV54zC5UiphJh+2Nqeep3cUPR4N9yo4/t/LVJhX6GACcLWMThtFuwjt2CUjEShbYxFKKq QaZCFffWLseiyJQcJ6i3bvSYtFCOrbePeLkeVl6rmXq0K1Y5vzrnyn8NlmKK5faO3gKcVu B0/P31CvhPLzsIaNusHse0/o4hp/2CabbugvWutUwr3ZthZpxz1Yrz+8tGP7cf3DFkTJvg 3laZe2sUmMi5zVhiIVKxMc0gotnKMv0jNIj9BucE6n/S+tuKWqxKMuW+RGZJmUTckhdYpr 9tLmms0gVhPEG6puKmRkrM1QwLy6UBmTGcMydJT7AJ3Le4snU5rjtG1n6QZI9w== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b="J2V8/2eS"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 7.05 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b="J2V8/2eS"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 0AC50DC36 X-Spam-Score: 7.05 X-Migadu-Scanner: scn0.migadu.com X-TUID: pJJJObTdsffQ Hi jgart, jgart writes: > * guix/gexp.scm (): Clarify that what goes in the guile > record field is any variant of a guile package record instance. > --- > guix/gexp.scm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/guix/gexp.scm b/guix/gexp.scm > index ef92223048..eba65e92cf 100644 > --- a/guix/gexp.scm > +++ b/guix/gexp.scm > @@ -581,7 +581,7 @@ (define-record-type > computed-file? > (name computed-file-name) ;string > (gexp computed-file-gexp) ;gexp > - (guile computed-file-guile) ; > + (guile computed-file-guile) ; > (options computed-file-options)) ;list of arguments If this was a statically typed language, the proper type of the argument accepted would be , not , so I'm inclined to leave it the way it is (also, we'd have to survey the whole code base to adjust for our current convention, which is to use ). Closing, Thanks, Maxim