From: "Ludovic Courtès" <ludo@gnu.org>
To: itd <itd@net.in.tum.de>
Cc: 58250@debbugs.gnu.org
Subject: bug#58250: guix import json: GUIX_PACKAGE_PATH -- no code for module
Date: Fri, 23 Dec 2022 14:49:40 +0100 [thread overview]
Message-ID: <87r0wqz0uj.fsf_-_@gnu.org> (raw)
In-Reply-To: <87y1tye1je.fsf@localhost> (itd@net.in.tum.de's message of "Sun, 02 Oct 2022 16:35:33 +0200")
Hi,
itd <itd@net.in.tum.de> skribis:
> * guix/modules.scm (file-name->module-name): Ignore load path prefix
> when building module name.
> ---
> It was mentioned on IRC, that (guix modules)'s file-name->module-name
> might be function to be used by the JSON importer (and fixed if needed).
> This patch attempts to implement the idea from the bug report.
At first sight I believe the fix should be in ‘package->code’, not in
(guix modules).
(guix modules) is quite sensitive so in general we should refrain from
changing the semantics of its procedures. In this case,
‘file-name->module-name’ expects a file name relative to a search path
entry.
HTH,
Ludo’.
next prev parent reply other threads:[~2022-12-23 13:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-02 14:26 bug#58250: guix import json: GUIX_PACKAGE_PATH -- no code for module itd
[not found] ` <handler.58250.B.16647208196976.ack@debbugs.gnu.org>
2022-10-02 14:35 ` bug#58250: [PATCH 1/2] modules: Remove load path prefix from module name itd
2022-12-23 13:49 ` Ludovic Courtès [this message]
2022-10-02 14:38 ` bug#58250: [PATCH 2/2] import: print: Use file-name->module-name itd
2022-12-23 13:50 ` bug#58250: guix import json: GUIX_PACKAGE_PATH -- no code for module Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r0wqz0uj.fsf_-_@gnu.org \
--to=ludo@gnu.org \
--cc=58250@debbugs.gnu.org \
--cc=itd@net.in.tum.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.