From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id 2Kq/ErywrGNwfgEAbAwnHQ (envelope-from ) for ; Wed, 28 Dec 2022 22:10:20 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id kAyIErywrGMadQEAauVa8A (envelope-from ) for ; Wed, 28 Dec 2022 22:10:20 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 0C8BE3C2AD for ; Wed, 28 Dec 2022 22:10:19 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pAdgS-0000Hs-Ml; Wed, 28 Dec 2022 16:09:56 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pAdgR-0000Hk-6l for guix-devel@gnu.org; Wed, 28 Dec 2022 16:09:55 -0500 Received: from cascadia.aikidev.net ([173.255.214.101]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pAdgP-0000TU-9n for guix-devel@gnu.org; Wed, 28 Dec 2022 16:09:54 -0500 Received: from localhost (unknown [IPv6:2600:3c01:e000:21:7:77:0:40]) (Authenticated sender: vagrant@cascadia.debian.net) by cascadia.aikidev.net (Postfix) with ESMTPSA id 01AF71AC6E; Wed, 28 Dec 2022 13:09:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=debian.org; s=1.vagrant.user; t=1672261784; bh=nzLXUV4PnFYFmyd5IZzrV2zyBOVMxkun1tDhlO97b3o=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=AKpKrk6M9SozE1ntBNs7V7/ULwyAXbH634aed1d1qQRTRvW+XWzGQvHwYqHAcZmOn 12FpNrTJB0u4gkXdsS+i14/MRxI7UPzrEITL9m2CZJIYYXw0mQtl66HV9icUCVpQwJ QRvDNT7OB+bcEaAg7NsKDYbKM3O6cGe+/qvnt+tV3bywQLbT8U76OufC6xuDoHGi0O YkTl6AlHnA2k43vBJxLI9b9D/Q7v61QfK1Y6Rf5lMwWvSaHsoFKRxc8xjIUlvjBbeb 2ZH/GTb3jv89CZsaIIJeUsfpp2V3Y+RXXBYKEPIZYa6Cn4JA3GDfVApREc29Do7Tt3 6dMh1/Tdh5Sng== From: Vagrant Cascadian To: Maxim Cournoyer Cc: guix-devel@gnu.org Subject: Re: [PATCH] gnu: u-boot-am335x-boneblack: Revert to old name. In-Reply-To: <20221228204008.31853-1-maxim.cournoyer@gmail.com> References: <87a638rdu6.fsf@contorta> <20221228204008.31853-1-maxim.cournoyer@gmail.com> Date: Wed, 28 Dec 2022 13:09:40 -0800 Message-ID: <87r0wjnskr.fsf@yucca> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Received-SPF: none client-ip=173.255.214.101; envelope-from=vagrant@debian.org; helo=cascadia.aikidev.net X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: guix-devel-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Seal: i=1; s=key1; d=yhetil.org; t=1672261820; a=rsa-sha256; cv=none; b=Ba9Qlk5L22TjC3xhGzri2aBLHaXcVsm6slGqsoQWRx4XBOh4FKstf0VaJ84uPHTSgMNiwu 07B6B2gr1rnEeDv7ecD5S4RbPSqZ65wpSOuvkKsikxGImnOLAg5U4XL3ADa2MAHUGwiJWZ NMgh57lATM9nopgNUZ2BIiVgEJU3djkGWdsz3wt0pxr7eSocn0gZZg/RnQTamNUXV/U4i5 oGVpVh1ClHQeaWIC9Z1tO/8fVzwoa/BxrSkSsHw76dANJz5f0dHM3zEcFuSNv/RWBGcXzh 64zXrK6r7MjaVIKy+/8tfUQKdjfhz5QuUk0t9XAGRZpHB4S+mf5yLhbul08H1A== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=debian.org header.s=1.vagrant.user header.b=AKpKrk6M; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org"; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1672261820; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=PPeNq6p2O0f218xWkGLY/rCiSYmAyGZFpjF3DiOrjeU=; b=Q2s2UXD90Sx2REeQPxeMw8uvoxiOHoS9f3qjc2jk5+1p1wrZoQnMymxC+Q48GoY2rnqdAb RupOYcVL54SkyQCE2wvBFc3COMcTBX4XaNH3+tbPxrKMcopC/pVzUoVbfRhF+HHOh438SO crYv5wJpLq0XJQgntjOoYS2Aa9cS0F++r6WyW99Qn7ZimHowLWtzXqHIgjrF7YbQ+DBx42 WAAZzM2FDv3dQ07/alHQzJgnf7rmvjDy85t8s+ob8HDV1MpBrFbfzJBRZFg6fKlnN20mW9 34llrm1VPhZyUmbI+uM1wf4xa/2zaD+GsqwHUPYApokxyjObZxq9+d8/pnorBg== X-Spam-Score: -10.41 X-Migadu-Queue-Id: 0C8BE3C2AD Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=debian.org header.s=1.vagrant.user header.b=AKpKrk6M; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org"; dmarc=none X-Migadu-Scanner: scn0.migadu.com X-Migadu-Spam-Score: -10.41 X-TUID: dD/8TVSj4uKg --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable On 2022-12-28, Maxim Cournoyer wrote: > This reverts to the name this package had previous to commit > c2c1dfdf5760873f1db86d14873f725a105f7feb ("gnu: bootloader: Add U-Boot > packages for Raspberry Pi models."), which caused the package name to be > derived from the board name. > > * gnu/packages/bootloaders.scm (u-boot-am335x-evm-boneblack): Remove the > NAME-SUFFIX keyword argument. Specify the full name via the name field. > * gnu/bootloader/u-boot.scm (u-boot-beaglebone-black-bootloader): Adjust = to > the renamed package. > > Reported-by: Vagrant Cascadian I haven't tested that it builds, but it looks good to me; thanks for sorting that out! live well, vagrant > --- > gnu/bootloader/u-boot.scm | 2 +- > gnu/packages/bootloaders.scm | 28 +++++++++++++++++----------- > 2 files changed, 18 insertions(+), 12 deletions(-) > > diff --git a/gnu/bootloader/u-boot.scm b/gnu/bootloader/u-boot.scm > index de3a43ed70..6cad33b741 100644 > --- a/gnu/bootloader/u-boot.scm > +++ b/gnu/bootloader/u-boot.scm > @@ -144,7 +144,7 @@ (define u-boot-bootloader > (define u-boot-beaglebone-black-bootloader > (bootloader > (inherit u-boot-bootloader) > - (package u-boot-am335x-evm-boneblack) > + (package u-boot-am335x-boneblack) > (disk-image-installer install-beaglebone-black-u-boot))) >=20=20 > (define u-boot-allwinner-bootloader > diff --git a/gnu/packages/bootloaders.scm b/gnu/packages/bootloaders.scm > index 89f051f337..e379a38127 100644 > --- a/gnu/packages/bootloaders.scm > +++ b/gnu/packages/bootloaders.scm > @@ -890,17 +890,23 @@ (define*-public (make-u-boot-package board triplet > (define-public u-boot-malta > (make-u-boot-package "malta" "mips64el-linux-gnuabi64")) >=20=20 > -(define-public u-boot-am335x-evm-boneblack > - (make-u-boot-package > - "am335x_evm" "arm-linux-gnueabihf" > - ;; Patch out other device trees to build an image small enough to fit > - ;; within typical partitioning schemes where the first partition begi= ns at > - ;; sector 2048. > - #:configs '("CONFIG_OF_LIST=3D\"am335x-evm am335x-boneblack\"") > - #:name-suffix "-boneblack" > - #:append-description "This U-Boot is built for the BeagleBone Black, = which > -was removed upstream, adjusted from the am335x_evm build with several de= vice > -trees removed so that it fits within common partitioning schemes.")) > +(define-public u-boot-am335x-boneblack > + (let ((base (make-u-boot-package > + "am335x_evm" "arm-linux-gnueabihf" > + ;; Patch out other device trees to build an image small e= nough > + ;; to fit within typical partitioning schemes where the f= irst > + ;; partition begins at sector 2048. > + #:configs '("CONFIG_OF_LIST=3D\"am335x-evm am335x-bonebla= ck\"") > + #:append-description > + "This U-Boot is built for the BeagleBone Black, which was > +removed upstream, adjusted from the am335x_evm build with several device= trees > +removed so that it fits within common partitioning schemes."))) > + (package > + (inherit base) > + ;; The name is not derived from the board name on purpose, as the = config > + ;; is modified per the comment above, parting from the default > + ;; am335x_evm configuration. > + (name "u-boot-am335x-boneblack")))) >=20=20 > (define-public u-boot-am335x-evm > (make-u-boot-package "am335x_evm" "arm-linux-gnueabihf")) > > base-commit: fde5af3962c8fafc5d20e5d742cc7aea907f3563 > --=20 > 2.38.1 --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEARYKAB0WIQRlgHNhO/zFx+LkXUXcUY/If5cWqgUCY6ywlAAKCRDcUY/If5cW qrjYAQD/pMIPgftTWodGavoTwBdTUmSvv07R3A6cuQNDF+Kt5QEAjt3JZSPuEdA2 VzAQLHGB0NagdcEBey9hVZcjDgtLyQA= =yMBa -----END PGP SIGNATURE----- --=-=-=--