From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id eT2JE9+iCGSuKAAASxT56A (envelope-from ) for ; Wed, 08 Mar 2023 15:59:43 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id wHZ7Ed+iCGTRygAA9RJhRA (envelope-from ) for ; Wed, 08 Mar 2023 15:59:43 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 066CE1DA8A for ; Wed, 8 Mar 2023 15:59:43 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pZvFx-00063t-IN; Wed, 08 Mar 2023 09:59:05 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pZvFu-00063Z-LU for guix-patches@gnu.org; Wed, 08 Mar 2023 09:59:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pZvFu-0000Ky-DZ for guix-patches@gnu.org; Wed, 08 Mar 2023 09:59:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pZvFu-0006iX-9j for guix-patches@gnu.org; Wed, 08 Mar 2023 09:59:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#61941] [PATCH 1/2] gnu: emacs-helpful: Update to 0.20.1c98f6f. Resent-From: Nicolas Goaziou Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 08 Mar 2023 14:59:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61941 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: conses Cc: 61941@debbugs.gnu.org Received: via spool by 61941-submit@debbugs.gnu.org id=B61941.167828749025757 (code B ref 61941); Wed, 08 Mar 2023 14:59:02 +0000 Received: (at 61941) by debbugs.gnu.org; 8 Mar 2023 14:58:10 +0000 Received: from localhost ([127.0.0.1]:49872 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pZvF3-0006hN-TL for submit@debbugs.gnu.org; Wed, 08 Mar 2023 09:58:10 -0500 Received: from relay3-d.mail.gandi.net ([217.70.183.195]:44815) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pZvF1-0006gs-NA for 61941@debbugs.gnu.org; Wed, 08 Mar 2023 09:58:08 -0500 Received: (Authenticated sender: admin@nicolasgoaziou.fr) by mail.gandi.net (Postfix) with ESMTPSA id B89FE60004; Wed, 8 Mar 2023 14:57:58 +0000 (UTC) From: Nicolas Goaziou References: Date: Wed, 08 Mar 2023 15:57:51 +0100 In-Reply-To: (conses's message of "Fri, 03 Mar 2023 17:58:26 +0100") Message-ID: <87r0tz8f4g.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1678287583; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post; bh=PuI7TfnxRH2ZQWe8dRiaswfJrhxGBmFTPU4p4TIxC0o=; b=rXU4ppuua7A5uFTEc/8bEbPYxE1SlrvaTR0L/iYLtVMmkYU1h/01hPtLgP+V5a27gGwIq+ K2kyBvKRSM0Pzlmivq/lmnj0O6mOhg+sCX0x4O1z7Ns8zrMHCESn8TfHiMRrSsy7IQ6CBa +gu31vsjtue+5CYEc2lJTmhQ0gKR01zgFnr522Tsl84QQs/1wF38HxyphBGu3CnW0i8MSX TdxYrEUzVDyLHCqzTvwG3xQ1T5QaM2S+yJ+Jt/3CGHD1hVa7M0PeLjz6Pdzve0bNyc4fGz hWYOe7RutJ/uOfWRmL/oqCTaGrmq0wzAmYiHqn7FP4SAwb814qkCyOXLDdq4TA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=none ARC-Seal: i=1; s=key1; d=yhetil.org; t=1678287583; a=rsa-sha256; cv=none; b=b2+pgj6uMpvS68hFFxrVkqlEeBKH8RpeBJ+KH3/OElii4TrBnX8qiD9Z9yL8wCFhqyT+Z3 Zyeghxo9wjUDIBQ2KEb2NILYUHs7S1GXIPWFUZj4YgM4bUscE2ZgtVFgHsUG5ILgJTvEVn A3bAMmlzURR7Py6DN2rHdauFdRGYF/1BYOBhdbbSmHYUUaagTOJaDkcqTV5GMKtuRTTmmu bJuaI+KdaDICwQwNqcgugCCVkjoa2VtC1xNQqlN1L1/qbUcjkIFry155v39HcmINPdLEtq dNOPxi+jS/1cYvhi+9LOMjN7iJ020B3HldAxjKzHLBCduaYNwLDzK+Yj1iIZjQ== Authentication-Results: aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=none X-Migadu-Spam-Score: -3.30 X-Spam-Score: -3.30 X-Migadu-Queue-Id: 066CE1DA8A X-Migadu-Scanner: scn1.migadu.com X-TUID: hwTtR0EDdWgw Hello, conses writes: > * gnu/packages/emacs-xyz.scm (emacs-helpful): Update to 0.20.1c98f6f. > [source]: Remove fix-docstring-test.patch. > [propagated-inputs]: Remove emacs-shut-up. Thank you. Some comments follow. > + (let ((commit "1c98f6f06a85def5d34c735f8cd407f20cebddf9") > + (revision "0")) Is there a particular reason to use an unreleased version? > + (package > + (name "emacs-helpful") > + (version (git-version "0.20" revision commit)) Base version is actually still 0.19. Upstream bumped Version keyword, but the README mentions there is no official 0.20 yet. I suggest to stick to 0.19. > + (source > + (origin > + (method git-fetch) > + (uri (git-reference > + (url "https://github.com/Wilfred/helpful") > + (commit commit))) > + (file-name (git-file-name name version)) > + (sha256 > + (base32 "18b5hjfji51zxjrxhkklxx3j9svk295awmxv8n95mp8ilas2kd3l")))) > + (build-system emacs-build-system) > + (propagated-inputs > + (list emacs-elisp-refs emacs-dash emacs-s emacs-f)) While you're at it, could you re-order inputs alphabetically? You can also merge both patches. Regards, -- Nicolas Goaziou