From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id WH09AUXqV2QAXQAASxT56A (envelope-from ) for ; Sun, 07 May 2023 20:13:25 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id mI9aAEXqV2T4iQAAG6o9tA (envelope-from ) for ; Sun, 07 May 2023 20:13:25 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 9569D1C7A7 for ; Sun, 7 May 2023 20:13:24 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pvisa-0000p0-7C; Sun, 07 May 2023 14:13:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pvisY-0000oR-MX for bug-guix@gnu.org; Sun, 07 May 2023 14:13:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pvisY-0007Jb-D1 for bug-guix@gnu.org; Sun, 07 May 2023 14:13:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pvisX-0007mv-PL for bug-guix@gnu.org; Sun, 07 May 2023 14:13:01 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#63082: [PATCH v3 05/16] services: mpd: Obsolete the 'group' field. Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Sun, 07 May 2023 18:13:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63082 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Liliana Marie Prikler Cc: 63082@debbugs.gnu.org Received: via spool by 63082-submit@debbugs.gnu.org id=B63082.168348317729927 (code B ref 63082); Sun, 07 May 2023 18:13:01 +0000 Received: (at 63082) by debbugs.gnu.org; 7 May 2023 18:12:57 +0000 Received: from localhost ([127.0.0.1]:38423 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pvisS-0007mc-OE for submit@debbugs.gnu.org; Sun, 07 May 2023 14:12:57 -0400 Received: from mail-qt1-f179.google.com ([209.85.160.179]:55773) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pvisO-0007mN-7A for 63082@debbugs.gnu.org; Sun, 07 May 2023 14:12:56 -0400 Received: by mail-qt1-f179.google.com with SMTP id d75a77b69052e-3f0b30f240eso32470631cf.3 for <63082@debbugs.gnu.org>; Sun, 07 May 2023 11:12:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1683483166; x=1686075166; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=ZF/hL/VkYlB+NmwNLe6pkLrAknMxg0sIOQz2j77gJz0=; b=fK2El4o75tsAo+15ES6Ic+3P1I+eHQcoMnSD1RL91QMW7vVYppVE5fIb8HCC5Et2Dj ceG1JFM7xR6g3KYClRIaEujSJCNjrdyYYIH3JHROyu9Brz6TSSQ/hywURQ+8CPZQRGmq 0AFdvNfjgBFDZOV1T7MEZ90u1OVEItK7hnTXNOjk7Qv6BJZuBIirZOsREgY22xnccSyh aCv9J1Tz2UslC1m+fkalD+qaJWnar8Xw2UoUzQX+Mm34C84wZQWW+e9H0I0oWGEMaUb1 PKctbh2j+LTp+rjunKt/WRqt4tZFTctJe8cKFyJBJCKc6NiCLtIcU4FdBc9wvg/Ahm64 Ioog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683483166; x=1686075166; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=ZF/hL/VkYlB+NmwNLe6pkLrAknMxg0sIOQz2j77gJz0=; b=cE2Z6hV0b5ufToI1QwyNSZPFnU9TW6Ap4eZJFYU8I9YIhqLhXUDFj/8zkyhygSzuwK zozg3rwGcMW07qi+9ZL9tZykzC/wgcYkNxQW9qe3GoxOLlaBBzIveuqqcAnIPR8wIr3D hUIo7OIepT8ByltLzT7gv3oxMAo9G7sMmqGDagwrZIv4NKVSmzUlW5NG02ZOOsmtdB9C umoqtRAymkSrHN3CM+t57i0xhFlbJvb189TBchl3Yz3nR8+Bc1zsFUCymK5sux6ymL7n hudps5WFMEc7QI58xXqvZNVAXpOfYHaD8GFu8uvqGrfyIJbYtmqAxF0+PT3NcrzBJEEb eOSw== X-Gm-Message-State: AC+VfDw/MDQkP/bK7GjRBH2CP1kNa9b6ncy3xs34w+lX8Z/NUmVpc64N DcKIxw2qlIO/irtvhYtz6QerKEaMOUSNCQ== X-Google-Smtp-Source: ACHHUZ7EnnzXKBlhq57NrcxR2Jh9pF2aeXR4y+OCvHFlRRsivsl14xRK10MPPjhZk7EQHZNgs/D3OA== X-Received: by 2002:ac8:5b03:0:b0:3ef:2fbd:90cd with SMTP id m3-20020ac85b03000000b003ef2fbd90cdmr10779123qtw.46.1683483166027; Sun, 07 May 2023 11:12:46 -0700 (PDT) Received: from hurd (dsl-10-131-119.b2b2c.ca. [72.10.131.119]) by smtp.gmail.com with ESMTPSA id s29-20020a05620a031d00b0074c438db55asm2050691qkm.74.2023.05.07.11.12.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 07 May 2023 11:12:45 -0700 (PDT) From: Maxim Cournoyer References: <40db40a2bbfe5e0586d8b8c9694607bc0d66e340.1683299529.git.maxim.cournoyer@gmail.com> <7ba0cf980bf4ad3766c6c0ae30b069ed2891128e.camel@gmail.com> <875y943l6c.fsf@gmail.com> <69a7c685bb22add38026990a91f099db44eb80ec.camel@gmail.com> Date: Sun, 07 May 2023 14:12:44 -0400 In-Reply-To: <69a7c685bb22add38026990a91f099db44eb80ec.camel@gmail.com> (Liliana Marie Prikler's message of "Sun, 07 May 2023 07:35:21 +0200") Message-ID: <87r0rsxb6r.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: bug-guix-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Seal: i=1; s=key1; d=yhetil.org; t=1683483204; a=rsa-sha256; cv=none; b=FjuB0akx3cycoKEhLiW8TjInGaY7HfzpG+zgiCIMgOx/3J1ff7qQWtlBfAsdVSXRicUnl+ 3k7xLRpcsNZqscVokIICDfMlrgNxjYwsqELw+Wt9Prp4jn6YmY3mqjeuR+EV5ScAB/EoOT CTBYbRjKzVodbQr76qdmPl6DszB7xjulRwGISyQH4J/VC/02JW179M+o++T5wtOgGFqBgI 8cLsLHpFuOyIsKnazOVEtOcAagNhQ2I5NSM5DCgS/vbaQO6YBbXpA9A43kyTcDsi3W+oXF ELYNFg6hcU4qQS/jXrOFyFQkPQXsZvz7qRL50JfUNDOVQ+aoAOiaFkZBRCeUWw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20221208 header.b=fK2El4o7; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1683483204; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=ZF/hL/VkYlB+NmwNLe6pkLrAknMxg0sIOQz2j77gJz0=; b=XcSmwFW7WR9oGNnOHFqTxqDwgrhzwbMXdMMJQ8c1oG464P1QbuM6UNXDKmqQWnmDLotm0f gqkObDzUkHmCRc64UNUuu3uH03nZzF+91Xte+pBBMpDClTMHvWnX9AsRLcNcPDGVOnszh1 GCPry+VzQAOzPH7Nn1FytMteck8pc0DLjrEs65ClaS8k739v6Uki+k8/hVQ/VZ9X9pVJdx XDRGB2ISJ2Jp2tx4iOfKVqntMsz2E4dT4ZcKmYHZB1h+xiWrOEXpa+At8CU4tuFLJD4BD6 Ov389xwFLSYOcPuYZhX9xyTbIzj9RkphG+BRgqTSUAPv4YcmJtdwOznCnYbD1Q== X-Migadu-Spam-Score: 0.69 X-Spam-Score: 0.69 X-Migadu-Queue-Id: 9569D1C7A7 X-Migadu-Scanner: scn0.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20221208 header.b=fK2El4o7; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-TUID: jNddEn3WqPhc Hi Liliana, Liliana Marie Prikler writes: > Am Samstag, dem 06.05.2023 um 22:55 -0400 schrieb Maxim Cournoyer: >> Hi! >>=20 >> Liliana Marie Prikler writes: >>=20 >> > Am Freitag, dem 05.05.2023 um 14:29 -0400 schrieb Maxim Cournoyer: >> > Didn't we agree in v2 that we want to address this on the account- >> > service level?=C2=A0 Unless the rest of this series somehow depends on >> > this patch, I'd rather delay it until we have a proper solution. >>=20 >> I think we agreed the idea to have support > group> objects for its group field was a good idea that should be >> implemented, but I declined doing this new work as part of this >> series :-). > Indeed, that's how I understood it. However, I also thought that > addressing this issue in a later series means we can keep the current > behaviour until that is done. My focus on this series was making sure the configuration is easy(er) to reason with and that it works out of the box for the most part. >> > > Synchronizing both is not practical, as it can easily lead to >> > > slightly different objects conflicting, again >> > > causing problems. >> > It might not be practical to do so inside the service, but note how >> > this has already become an effort in defensive programming.=C2=A0 There >> > are easier ways to not make this a problem on the configuration >> > level, namely by specifying the same group for both user and group >> > fields.=C2=A0 As far as I see this is even the default state of being = if >> > the user is supplied as a string. >>=20 >> I really don't like the group information being duplicated in both >> the user and a distinct field; it's an awkward API that raises more >> questions than it provides answers, in my opinion (non-intuitive). > And I agree that it's awkward, but I don't agree that this patch solves > the underlying issue. It puts the issue aside; if you can't configure a mismatched group, you can't shoot yourself in the foot. >> One of the reasons I came think this way is because a >> can differ by being a system group or not, which would make it easy >> to introduce unexpected, subtle variants. > Is that a serious issue, though? Yes, two configuration files, one > with (system? #t) and one without will produce different results in > that GIDs are allocated differently, but the same applies to the user > as well. The only real issue I can think about here goes back to the > handling of duplicate accounts and groups; and again, we both agree > that those ought to be hard errors rather than warnings. I think it's a serious issue because the permissions configured in the start slot may be wrong, and the service could fail to run because of it. --=20 Thanks, Maxim