all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Simon Tournier <zimon.toutoune@gmail.com>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: Guillaume Le Vaillant <glv@posteo.net>, 66305@debbugs.gnu.org
Subject: bug#66305: Error with recursive git checkout
Date: Wed, 04 Oct 2023 20:16:06 +0200	[thread overview]
Message-ID: <87r0maz21l.fsf@gmail.com> (raw)
In-Reply-To: <87v8bm9wx7.fsf@gnu.org>

Hi Ludo,

On Wed, 04 Oct 2023 at 18:25, Ludovic Courtès <ludo@gnu.org> wrote:

> diff --git a/guix/scripts/perform-download.scm b/guix/scripts/perform-download.scm
> index 045dd84ad6..c869f19502 100644
> --- a/guix/scripts/perform-download.scm
> +++ b/guix/scripts/perform-download.scm
> @@ -108,6 +108,10 @@ (define* (perform-git-download drv output
>             (drv-output (assoc-ref (derivation-outputs drv) "out"))
>             (algo       (derivation-output-hash-algo drv-output))
>             (hash       (derivation-output-hash drv-output)))
> +      ;; Commands such as 'git submodule' expect Coreutils and sed (among
> +      ;; others) to be in $PATH.
> +      (setenv "PATH" "/run/current-system/profile/bin:/bin:/usr/bin")
> +
>        (git-fetch-with-fallback url commit output
>                                 #:recursive? recursive?
>                                 #:git-command %git))))

LGTM.

Well, I would add a comment explicitly mentioning that’s a temporary fix
pointing this issue #66305.

And I have tested with:

--8<---------------cut here---------------start------------->8---
$ guix build  ocaml-ansiterminal -S --no-substitutes
$ guix build volk --no-substitutes --check -S
--8<---------------cut here---------------end--------------->8---


Cheers,
simon




  reply	other threads:[~2023-10-04 18:18 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-02 11:17 bug#66305: Error with recursive git checkout Guillaume Le Vaillant
2023-10-02 17:37 ` Guillaume Le Vaillant
2023-10-03 19:26 ` Simon Tournier
2023-10-04 16:25   ` Ludovic Courtès
2023-10-04 18:16     ` Simon Tournier [this message]
2023-10-04 18:18       ` Simon Tournier
2023-10-05  9:28       ` Ludovic Courtès
2023-10-05 21:31         ` Ludovic Courtès
2023-10-12 14:42           ` Ludovic Courtès
2023-10-25  4:53 ` Alexis Simon via Bug reports for GNU Guix
2023-10-25 16:51 ` Alexis Simon via Bug reports for GNU Guix
2023-10-25 17:47 ` Alexis Simon via Bug reports for GNU Guix

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87r0maz21l.fsf@gmail.com \
    --to=zimon.toutoune@gmail.com \
    --cc=66305@debbugs.gnu.org \
    --cc=glv@posteo.net \
    --cc=ludo@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.