From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id YAoqGxw4qGVlLQAAqHPOHw:P1 (envelope-from ) for ; Wed, 17 Jan 2024 21:27:08 +0100 Received: from aspmx1.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0.migadu.com with LMTPS id YAoqGxw4qGVlLQAAqHPOHw (envelope-from ) for ; Wed, 17 Jan 2024 21:27:08 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Wr3cnVWB; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1705523228; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=+zL82iwU5CI39Gw8OIR1i1yBOFsEaTBLk/A8xDTFSWo=; b=oVnYJ4FiPPHu4fb9acJudi3NB3MiRnS2CP6pK31iLUepezWkoo7p+4Gy1+wGMUx154JfB8 GHV6GziFeCv2FzzyenS5+pXxQKH286WmCMl1BgkcipSP2bORRfTaB6lR7xl73tK/73Trnu t1+/13vvySHvnahb2ICczJVm/VnZ4jtwViR45Nk+D6vt0c3TtvtDnh22vOALtRNJLPNJrT EmyzT8BlRZxPBjVm4qlDqR2PBb+itFg5xzV+n+hKdRoQ1g98L5/QWkuet0ie9Co57H1so4 8AHlUSvY1yMihEorbKTtg06ZbiHdsZmV1rf2pIK0Ypxv8L58J/MZ/x5yNCs+kg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Wr3cnVWB; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=key1; d=yhetil.org; t=1705523228; a=rsa-sha256; cv=none; b=QFm2+IYy3+4Ly8t8HcmjtoJsYEvbYrs2k/QJNeKU+Vw2eZOM7cGkCoXSfhsiVPrGluNT+s Knd7D0EkjVeauNAADNr1NNUhy37PwKLodHuNTIEykW/sHAKBPwfXZp3+KfrXzYASpnGOa+ gwAh82BnXcA3LIqqmYVx9e7r0gqO4Fy1lPJHY6ektYHQTfRkRQ6dWzOX3n53k3MEcRWztk wl4HwuU7DFJlQEkoumhDb52JpmMzGwn4Wq5hZK0JNnuWJ0C+gV2jN6jbKsGRiO2uVxjOsD QWB7jU3fevG570v5R8bHa5BrKlbreaBil62WS0Cg1ZGhZlk8eZoKgXaShJfPhg== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 582AB680E3 for ; Wed, 17 Jan 2024 21:27:08 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rQCU7-0000ff-VZ; Wed, 17 Jan 2024 15:26:05 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rQCU0-0000cb-L3 for guix-devel@gnu.org; Wed, 17 Jan 2024 15:25:58 -0500 Received: from mail-wm1-x32b.google.com ([2a00:1450:4864:20::32b]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rQCTy-0004qO-HN for guix-devel@gnu.org; Wed, 17 Jan 2024 15:25:56 -0500 Received: by mail-wm1-x32b.google.com with SMTP id 5b1f17b1804b1-40e705d1527so5874165e9.0 for ; Wed, 17 Jan 2024 12:25:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1705523153; x=1706127953; darn=gnu.org; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=+zL82iwU5CI39Gw8OIR1i1yBOFsEaTBLk/A8xDTFSWo=; b=Wr3cnVWBxJsLeNIj77+N6eACph5eofu4xW1zE41Q8V9LtkwlDWj3SpVmy7ARmjdMfo ts3bmOBKc2F4qo+GVB04pHBDmM9K0HIYbwxHLwIAuBbfYpLScVQcGspJg0YPKtIpzbVn nL9MHs8jUG5tI1tXsVk4LW0Dpmr+QlUGvSHSN4+9PNK0T6IjKXbHiQZZVwYQpSB+fyiC FKqGvyONYrJM48ZbbigvsbKKfhkcFcV9ZTU0QGiburExI/PbRPRBA7sB6kLEOeUqNkp8 3ZZhehABJWZCShHpuBdTcWSYkDmxoM5sBvV0tjx3Kt8Wr2RBdauWztthE93+WlJkOlih dDQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705523153; x=1706127953; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+zL82iwU5CI39Gw8OIR1i1yBOFsEaTBLk/A8xDTFSWo=; b=hWTsKGkqKtxJVPzvM1a49XnJRWaKHirZLysCjSjf+iS/539uNc7uYqMQBiqHUaupG/ ZPyMosisJqzFbUl4JfK+hhJ+ZHdRAla68EaFY+4lU6C8Nei4dG314OdoIEgWnh6IsPut yBnSbIaBZ81IjVVWkl9wC0GoR3xzWJ2zS3CvjO/2tnziwHtVcBXAP1Z5CQFgiI58Hnf0 UkW50QnxagSKCwLXJYqQUpBKDuBAFKADvT8usazjWO7pdCGd+rShzvA19jCWw8Zp3t1N +llETG7cqNRvCHM+jv6hqjKvAvL4IF8eUANSHeHMO1j2Z+WawdF2gP5nVNHlz94uBsgw lHHg== X-Gm-Message-State: AOJu0YzPtKNjFB8dIA52msX2XxUgkzyu0OjFvPTKo7DnvcJ5too6J4n+ Vq8DoixlnmfvF8gHC6eiZFM= X-Google-Smtp-Source: AGHT+IH20q3Qc86CeMvetGFcu4WRC4K0Sa3K3QWaH7CAMpve+KUj0irs80RD866BLgiNWYtgejjT3Q== X-Received: by 2002:a05:600c:1c10:b0:40e:88ac:9edf with SMTP id j16-20020a05600c1c1000b0040e88ac9edfmr2376097wms.1.1705523152636; Wed, 17 Jan 2024 12:25:52 -0800 (PST) Received: from pfiuh07 ([193.48.40.241]) by smtp.gmail.com with ESMTPSA id v21-20020a05600c445500b0040e3bdff98asm27175533wmn.23.2024.01.17.12.25.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Jan 2024 12:25:52 -0800 (PST) From: Simon Tournier To: Troy Figiel , guix-devel@gnu.org Cc: Katherine Cox-Buday , Sharlatan Hellseher Subject: Re: Golang check phase skipping some tests? In-Reply-To: <65b75d58-e27b-4d02-80be-d87b86bf0342@troyfigiel.com> References: <65b75d58-e27b-4d02-80be-d87b86bf0342@troyfigiel.com> Date: Wed, 17 Jan 2024 16:53:14 +0100 Message-ID: <87r0igt0r9.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2a00:1450:4864:20::32b; envelope-from=zimon.toutoune@gmail.com; helo=mail-wm1-x32b.google.com X-Spam_score_int: -4 X-Spam_score: -0.5 X-Spam_bar: / X-Spam_report: (-0.5 / 5.0 requ) BAYES_00=-1.9, DATE_IN_PAST_03_06=1.592, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: guix-devel-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -7.50 X-Migadu-Queue-Id: 582AB680E3 X-Spam-Score: -7.50 X-Migadu-Scanner: mx11.migadu.com X-TUID: QBKLxttmnyOD Hi, CC: $ ./etc/teams.scm list-members go Katherine Cox-Buday Sharlatan Hellseher On Sun, 14 Jan 2024 at 22:12, Troy Figiel wrote: > --8<---------------cut here---------------start------------->8--- > (define* (check #:key tests? import-path #:allow-other-keys) > "Run the tests for the package named by IMPORT-PATH." > (when tests? > (invoke "go" "test" (string-append import-path "/..."))) > #t) > --8<---------------cut here---------------end--------------->8--- > > For example, if the -v flag is added (which might be a better default?) > to the check phase of go-github-stretchr-testify, it can be seen that > only `TestImports' runs, none of the tests in assert, http, etc. > However, the source code in these subdirectories is still recursively > copied to out during the install phase. > > Is this desired behaviour? I assumed it isn't, because it looks like we > are skipping a lot of tests during the check phase. However, I might > also simply be overlooking something here as I am new to packaging > Golang with Guix. >From your description, it seems a good idea. What do Go =E2=80=9Cexperts= =E2=80=9C think? Cheers, simon