[bug#68386] [PATCH] gnu: Add emacs-vhdl-mode.

[bug#68386] [PATCH] gnu: Add emacs-vhdl-mode.

[Cayetano Santos via Guix-patches via]

* gnu/packages/emacs-xyz.scm (emacs-vhdl-mode): New variable.

Signed-off-by: Cayetano Santos <csantosb@inventati.org>
---
 gnu/packages/emacs-xyz.scm | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 1d99fb30ff..6684b4496a 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -7999,6 +7999,24 @@ (define-public emacs-rspec
 snippets for yasnippet.")
       (license license:gpl3+))))
 
+(define-public emacs-vhdl-mode
+  (package
+    (name "emacs-vhdl-mode")
+    (version "3.39.3")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "https://iis-people.ee.ethz.ch/~zimmi/emacs/vhdl-mode-"
+                           version ".tar.gz"))
+       (sha256
+        (base32 "1yvh4gyig8hgf5pahajjgsgp4jpzwgmlprwzsfybqxrcfza6f3yq"))))
+    (build-system emacs-build-system)
+    (home-page "https://www.emacswiki.org/emacs/EmacsWget")
+    (synopsis "Major mode for VHDL")
+    (description
+     "This Emacs package provides a mode for the VHDL programming language.")
+    (license license:gpl3+)))
+
 (define-public emacs-mode-line-bell
   (package
     (name "emacs-mode-line-bell")

base-commit: 3dd8bf94a9d1a2eddb6eda9da7d4a3d422b9dfe9
-- 
2.41.0

[bug#68386] [PATCH v1] gnu: Add emacs-vhdl-mode.

[Cayetano Santos via Guix-patches via]

* gnu/packages/emacs-xyz.scm (emacs-vhdl-mode): New variable.

Signed-off-by: Cayetano Santos <csantosb@inventati.org>
---
 gnu/packages/emacs-xyz.scm | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 1d99fb30ff..dcd16caaa9 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -7999,6 +7999,24 @@ (define-public emacs-rspec
 snippets for yasnippet.")
       (license license:gpl3+))))
 
+(define-public emacs-vhdl-mode
+  (package
+    (name "emacs-vhdl-mode")
+    (version "3.39.3")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "https://iis-people.ee.ethz.ch/~zimmi/emacs/vhdl-mode-"
+                           version ".tar.gz"))
+       (sha256
+        (base32 "1yvh4gyig8hgf5pahajjgsgp4jpzwgmlprwzsfybqxrcfza6f3yq"))))
+    (build-system emacs-build-system)
+    (home-page "https://iis-people.ee.ethz.ch/~zimmi/emacs/vhdl-mode.html")
+    (synopsis "Major mode for VHDL")
+    (description
+     "This Emacs package provides a mode for the VHDL programming language.")
+    (license license:gpl3+)))
+
 (define-public emacs-mode-line-bell
   (package
     (name "emacs-mode-line-bell")

base-commit: 3dd8bf94a9d1a2eddb6eda9da7d4a3d422b9dfe9
-- 
2.41.0

[bug#68386] [PATCH v1] gnu: Add emacs-vhdl-mode.

[Maxim Cournoyer]

Hi,

Cayetano Santos <csantosb@inventati.org> writes:

> * gnu/packages/emacs-xyz.scm (emacs-vhdl-mode): New variable.
>
> Signed-off-by: Cayetano Santos <csantosb@inventati.org>
> ---
>  gnu/packages/emacs-xyz.scm | 18 ++++++++++++++++++
>  1 file changed, 18 insertions(+)
>
> diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
> index 1d99fb30ff..dcd16caaa9 100644
> --- a/gnu/packages/emacs-xyz.scm
> +++ b/gnu/packages/emacs-xyz.scm
> @@ -7999,6 +7999,24 @@ (define-public emacs-rspec
>  snippets for yasnippet.")
>        (license license:gpl3+))))
>  
> +(define-public emacs-vhdl-mode
> +  (package
> +    (name "emacs-vhdl-mode")
> +    (version "3.39.3")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append "https://iis-people.ee.ethz.ch/~zimmi/emacs/vhdl-mode-"
> +                           version ".tar.gz"))
> +       (sha256
> +        (base32 "1yvh4gyig8hgf5pahajjgsgp4jpzwgmlprwzsfybqxrcfza6f3yq"))))
> +    (build-system emacs-build-system)
> +    (home-page "https://iis-people.ee.ethz.ch/~zimmi/emacs/vhdl-mode.html")
> +    (synopsis "Major mode for VHDL")
> +    (description
> +     "This Emacs package provides a mode for the VHDL programming language.")
> +    (license license:gpl3+)))

Since there already is a 'vhdl-mode' package shipped with Emacs, I think
it's important to describe how this one differs (what improvements, features,
refinements, etc. does it provide that would make it worth considering
it instead of the default Emacs-provided option?).

-- 
Thanks,
Maxim

[bug#68386] [PATCH v1] gnu: Add emacs-vhdl-mode.

[Cayetano Santos via Guix-patches via]

>dim. 14 janv. 2024 at 21:46, Maxim Cournoyer <maxim.cournoyer@gmail.com> wrote:

> Since there already is a 'vhdl-mode' package shipped with Emacs, I think
> it's important to describe how this one differs (what improvements, features,
> refinements, etc. does it provide that would make it worth considering
> it instead of the default Emacs-provided option?).

There are also many other packages (org, modus-themes, etc.) shipped with
Emacs that we package in its most recent versions (and many others that
pull these as propagated inputs, for some reason, even when already
available with Emacs). Do we also describe how they differ ?

Anyway, the release notes, update history, bug fixes and enhancements of
every single version of vhdl-mode are given in the project home page,
already included along with the package. Where do we need to replicate
this information exactly for the patch to be accepted ?

Thanks,

Cayetano Santos

[bug#68386] [PATCH v1] gnu: Add emacs-vhdl-mode.

[Maxim Cournoyer]

Hi,

Cayetano Santos <csantosb@inventati.org> writes:

>>dim. 14 janv. 2024 at 21:46, Maxim Cournoyer <maxim.cournoyer@gmail.com> wrote:
>
>> Since there already is a 'vhdl-mode' package shipped with Emacs, I think
>> it's important to describe how this one differs (what improvements, features,
>> refinements, etc. does it provide that would make it worth considering
>> it instead of the default Emacs-provided option?).
>
> There are also many other packages (org, modus-themes, etc.) shipped with
> Emacs that we package in its most recent versions (and many others that
> pull these as propagated inputs, for some reason, even when already
> available with Emacs). Do we also describe how they differ ?
>
> Anyway, the release notes, update history, bug fixes and enhancements of
> every single version of vhdl-mode are given in the project home page,
> already included along with the package. Where do we need to replicate
> this information exactly for the patch to be accepted ?

Oh, I hadn't noticed that this was the very same package that comes with
Emacs.  I guess it's fine then, but to avoid any misunderstanding,
perhaps the description text could mention it explicitly ("This is the
same @code{vhdl-mode} that comes with Emacs, albeit it may be newer") or
similar wording.

-- 
Thanks,
Maxim

[bug#68386] [PATCH v2] gnu: Add emacs-vhdl-mode.

[Cayetano Santos via Guix-patches via]

* gnu/packages/emacs-xyz.scm (emacs-vhdl-mode): New variable.

Signed-off-by: Cayetano Santos <csantosb@inventati.org>
---
 gnu/packages/emacs-xyz.scm | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 1d99fb30ff..b7c5fbdf21 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -7999,6 +7999,24 @@ (define-public emacs-rspec
 snippets for yasnippet.")
       (license license:gpl3+))))
 
+(define-public emacs-vhdl-mode
+  (package
+    (name "emacs-vhdl-mode")
+    (version "3.39.3")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "https://iis-people.ee.ethz.ch/~zimmi/emacs/vhdl-mode-"
+                           version ".tar.gz"))
+       (sha256
+        (base32 "1yvh4gyig8hgf5pahajjgsgp4jpzwgmlprwzsfybqxrcfza6f3yq"))))
+    (build-system emacs-build-system)
+    (home-page "https://iis-people.ee.ethz.ch/~zimmi/emacs/vhdl-mode.html")
+    (synopsis "Major mode for VHDL programming language")
+    (description
+     "This package provides an update of @code{vhdl-mode} included in Emacs.")
+    (license license:gpl3+)))
+
 (define-public emacs-mode-line-bell
   (package
     (name "emacs-mode-line-bell")

base-commit: 3dd8bf94a9d1a2eddb6eda9da7d4a3d422b9dfe9
--
2.41.0

[bug#68386] [PATCH v1] gnu: Add emacs-vhdl-mode.

[Cayetano Santos via Guix-patches via]

>mer. 17 janv. 2024 at 09:08, Maxim Cournoyer <maxim.cournoyer@gmail.com> wrote:

> Hi,
>
> Cayetano Santos <csantosb@inventati.org> writes:
>
>>>dim. 14 janv. 2024 at 21:46, Maxim Cournoyer <maxim.cournoyer@gmail.com> wrote:
>>
>>> Since there already is a 'vhdl-mode' package shipped with Emacs, I think
>>> it's important to describe how this one differs (what improvements, features,
>>> refinements, etc. does it provide that would make it worth considering
>>> it instead of the default Emacs-provided option?).
>>
>> There are also many other packages (org, modus-themes, etc.) shipped with
>> Emacs that we package in its most recent versions (and many others that
>> pull these as propagated inputs, for some reason, even when already
>> available with Emacs). Do we also describe how they differ ?
>>
>> Anyway, the release notes, update history, bug fixes and enhancements of
>> every single version of vhdl-mode are given in the project home page,
>> already included along with the package. Where do we need to replicate
>> this information exactly for the patch to be accepted ?
>
> Oh, I hadn't noticed that this was the very same package that comes with
> Emacs.  I guess it's fine then, but to avoid any misunderstanding,
> perhaps the description text could mention it explicitly ("This is the
> same @code{vhdl-mode} that comes with Emacs, albeit it may be newer") or
> similar wording.

Done.

As an aside note, at some point, it should be decided how do we handle newest
releases of packages already included with emacs: do we need to mention
it explicitly or something else ?

C.

[bug#68386] [PATCH v1] gnu: Add emacs-vhdl-mode.

[Maxim Cournoyer]

Hi Cayetano,

Cayetano Santos <csantosb@inventati.org> writes:

>>mer. 17 janv. 2024 at 09:08, Maxim Cournoyer <maxim.cournoyer@gmail.com> wrote:
>
>> Hi,
>>
>> Cayetano Santos <csantosb@inventati.org> writes:
>>
>>>>dim. 14 janv. 2024 at 21:46, Maxim Cournoyer <maxim.cournoyer@gmail.com> wrote:
>>>
>>>> Since there already is a 'vhdl-mode' package shipped with Emacs, I think
>>>> it's important to describe how this one differs (what improvements, features,
>>>> refinements, etc. does it provide that would make it worth considering
>>>> it instead of the default Emacs-provided option?).
>>>
>>> There are also many other packages (org, modus-themes, etc.) shipped with
>>> Emacs that we package in its most recent versions (and many others that
>>> pull these as propagated inputs, for some reason, even when already
>>> available with Emacs). Do we also describe how they differ ?
>>>
>>> Anyway, the release notes, update history, bug fixes and enhancements of
>>> every single version of vhdl-mode are given in the project home page,
>>> already included along with the package. Where do we need to replicate
>>> this information exactly for the patch to be accepted ?
>>
>> Oh, I hadn't noticed that this was the very same package that comes with
>> Emacs.  I guess it's fine then, but to avoid any misunderstanding,
>> perhaps the description text could mention it explicitly ("This is the
>> same @code{vhdl-mode} that comes with Emacs, albeit it may be newer") or
>> similar wording.
>
> Done.
>
> As an aside note, at some point, it should be decided how do we handle newest
> releases of packages already included with emacs: do we need to mention
> it explicitly or something else ?

I think explicit doesn't hurt.

-- 
Thanks,
Maxim

bug#68386: [PATCH v2] gnu: Add emacs-vhdl-mode.

[Maxim Cournoyer]

Hi,

Cayetano Santos <csantosb@inventati.org> writes:

> * gnu/packages/emacs-xyz.scm (emacs-vhdl-mode): New variable.
>
> Signed-off-by: Cayetano Santos <csantosb@inventati.org>

We do not 'Signed-off-by' in Guix unless we apply patches of someone
else.  It's a different convention than for the kernel Linux
development and other projects.

I've applied it with small adjustments.

-- 
Thanks,
Maxim

[bug#68386] [PATCH v2] gnu: Add emacs-vhdl-mode.

[Cayetano Santos via Guix-patches via]

>jeu. 18 janv. 2024 at 22:47, Maxim Cournoyer <maxim.cournoyer@gmail.com> wrote:

> Hi,
>
> Cayetano Santos <csantosb@inventati.org> writes:
>
>> * gnu/packages/emacs-xyz.scm (emacs-vhdl-mode): New variable.
>>
>> Signed-off-by: Cayetano Santos <csantosb@inventati.org>
>
> We do not 'Signed-off-by' in Guix unless we apply patches of someone
> else.  It's a different convention than for the kernel Linux
> development and other projects.

You mean, it is optional, or do I better remove it next time ?

[bug#68386] [PATCH v2] gnu: Add emacs-vhdl-mode.

[Maxim Cournoyer]

Hi,

Cayetano Santos <csantosb@inventati.org> writes:

>>jeu. 18 janv. 2024 at 22:47, Maxim Cournoyer <maxim.cournoyer@gmail.com> wrote:
>
>> Hi,
>>
>> Cayetano Santos <csantosb@inventati.org> writes:
>>
>>> * gnu/packages/emacs-xyz.scm (emacs-vhdl-mode): New variable.
>>>
>>> Signed-off-by: Cayetano Santos <csantosb@inventati.org>
>>
>> We do not 'Signed-off-by' in Guix unless we apply patches of someone
>> else.  It's a different convention than for the kernel Linux
>> development and other projects.
>
> You mean, it is optional, or do I better remove it next time ?

It's better to remove it next time.

-- 
Thanks,
Maxim