From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id QD4mH3/fzWVLCAEA62LTzQ:P1 (envelope-from ) for ; Thu, 15 Feb 2024 10:55:11 +0100 Received: from aspmx1.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1.migadu.com with LMTPS id QD4mH3/fzWVLCAEA62LTzQ (envelope-from ) for ; Thu, 15 Feb 2024 10:55:11 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=VJDtz9HX; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1707990911; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=pKltCffwnVJw6A6bu9avV3uWWNiH82B0DUxEW1YzcbM=; b=s8+jUSwq2Hd+Prsw8I8q2Wtwt/v6fLNqUaqrFp54uOxqyZQCZOZsdAMzxM1M2ex+QTFGbn DCkOPFRAzkzuZGXmgWqiSYIirs0JfaS5x5kZWx8NYcg0BTfMpf766b2D3QTbRPmE+ckM3L ZGkp4k5lPbTTUF169ceTFWRARlCqOdxaO2KLo6mBi3ehdDEITI86xnMJHUDVBbKs3mrd/b Y9ZlISlUaZvKhCPLSGc64V8TW0Q1FBL+2+CZ9P8YJH+C+hlQ52EYdoG1VdZBFipoO3VllV qNurkhi2b/swVqjmxkM2RRXro8Fbhwp7B/NzAFIkBJ+ECPxFmN2k9cmUXy+pQw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=VJDtz9HX; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Seal: i=1; s=key1; d=yhetil.org; t=1707990911; a=rsa-sha256; cv=none; b=h4BbU2owKmh+Y0YDG40Xj8eDuXhs2McU7l7y408cq0MXn4/2FFes2OvanHVGv9cpmWtShL iTkAGe8mvtFeqyKvBnDGiRiEaoBNGtK8NSKD855SA3FahkADSrNRXzhyij3JIqjw6zq/fC F06D8dFFw8PoJVm6nthhtuqar1PiJH9fDs/iN4N9XRe0BZaiY+wFEOBp8E7RSH1TkqBji4 N25kMR/IIKOX0vYh6KM3jNw5WptYMD+UPTCgkI9HgMXDc+tp9jrxyFuUvSv+4WufSDUC1h CXOPP2DEUm/I/ha+Ma0xIUKRq7GaWPzpLWJGQqrpwDAJZTah4xoAyrpspkKWlg== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 5593E24587 for ; Thu, 15 Feb 2024 10:55:11 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1raYS6-0003S5-1L; Thu, 15 Feb 2024 04:54:46 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1raYS4-0003MQ-KZ for guix-patches@gnu.org; Thu, 15 Feb 2024 04:54:44 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1raYS4-0001Uk-7X for guix-patches@gnu.org; Thu, 15 Feb 2024 04:54:44 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1raYSM-00030j-CJ for guix-patches@gnu.org; Thu, 15 Feb 2024 04:55:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#68412] [PATCH v2] scripts: edit: Accept generic formatting parameter. Resent-From: Simon Tournier Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 15 Feb 2024 09:55:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 68412 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Liliana Marie Prikler , Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 68412@debbugs.gnu.org Received: via spool by 68412-submit@debbugs.gnu.org id=B68412.170799088111487 (code B ref 68412); Thu, 15 Feb 2024 09:55:02 +0000 Received: (at 68412) by debbugs.gnu.org; 15 Feb 2024 09:54:41 +0000 Received: from localhost ([127.0.0.1]:54114 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1raYS0-0002zD-Lv for submit@debbugs.gnu.org; Thu, 15 Feb 2024 04:54:41 -0500 Received: from mail-wr1-f49.google.com ([209.85.221.49]:41217) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1raYRy-0002yw-VS for 68412@debbugs.gnu.org; Thu, 15 Feb 2024 04:54:39 -0500 Received: by mail-wr1-f49.google.com with SMTP id ffacd0b85a97d-33d0a82685dso50491f8f.1 for <68412@debbugs.gnu.org>; Thu, 15 Feb 2024 01:54:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1707990794; x=1708595594; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=pKltCffwnVJw6A6bu9avV3uWWNiH82B0DUxEW1YzcbM=; b=VJDtz9HX7AdNHp7z0YReqNCHGDFZ71kDrho0Xvck/IteOM4/ri6eOcGiyQ0l4eq10b aSfGGSzna04/HhJgnBLWoSdd3+k5E9qm/BN5QhiDrn8z9YkHDg1gq8BUIgzIGvrIlm8K kGCMEPLdr0KSjQT4uOmcHlh5cUTG+GzbOGp+M6/xKu56MCNBSXFauwc5wp9l650isxjt CsFiIjTvCLmItXefQhl9LlEL5MR/vyhJfH8bVkeNjzF2r+baM8x8igorqLGIe3tlzS5l XKpX55OGVosokCgT0YXltsxQDRGB5D0r6nJC/UQHDBe2AEqC6/dMHiOgGmDZQ/8LbDCV YgGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707990794; x=1708595594; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=pKltCffwnVJw6A6bu9avV3uWWNiH82B0DUxEW1YzcbM=; b=O+4RBENsQLcIJQeyDoNdEqHtFBSsXVGY1GU+V9YyYU8skGfR3Zn10YXQddMQ4GZBs8 oq2JvyFg35TdqBQy2fF3oLOcrZ4Mp0ZDGAHpDBImX/kWZrAQbXV6vtQxvL+HaInUmE3c T5wEXxJD1WlSjjX6C8Q3XRLLo+1+auOzxN3JQUwV6tPOuMUAcn/xYk7JoC6ODrYVRdJL bCohrnQdS+IWOHS62FIS3iQ0+8V1COvt659vSFyCC/2MhlVPaLLATio1rhgIM7QRTZ0v vCxghqM535bSdEqrJJ5ydt+dd+obdL3TkCoziB+s1QvTid7+j2iaOtlPRYPg2C0vP/QN 1zbA== X-Gm-Message-State: AOJu0YzXTI1TkwEt0Urpji0hPlhF+uSsbcrMpJNqF05WtMzYC5wjhawF KHE4LVmHBwp0+VD6ocMdm0o5RgMOHXK0GF5ZaHsJCuf5yZR9XOfk2XYxZAW8 X-Google-Smtp-Source: AGHT+IF2eWr6Lkdb/BXJRVCFGRS3eKUTxBi19EN6LWntiS0cLjE8bEWoLXt3Pld06czv3gViTETh0A== X-Received: by 2002:a05:6000:783:b0:33d:1122:ec6f with SMTP id bu3-20020a056000078300b0033d1122ec6fmr37781wrb.5.1707990794279; Thu, 15 Feb 2024 01:53:14 -0800 (PST) Received: from lili ([2a01:e0a:59b:9120:7d85:9c0b:111:5112]) by smtp.gmail.com with ESMTPSA id bq3-20020a5d5a03000000b0033cf29a67c7sm1282113wrb.7.2024.02.15.01.53.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Feb 2024 01:53:13 -0800 (PST) From: Simon Tournier In-Reply-To: References: <9a666abbf1cb4b7548c1a117eaa04b0de02145ae.1705103171.git.liliana.prikler@gmail.com> <86b13fd4916ffecb1947d0879805a6d0c32542bf.1706386650.git.liliana.prikler@gmail.com> <87v87ciedd.fsf@gmail.com> <8422a68ebc6545a4587232c404efcfee86337df3.camel@gmail.com> <87h6ij3of4.fsf@gnu.org> <15c08b6053676777c8457ff247b0ab214465cedc.camel@gmail.com> <87eddkk5do.fsf@gnu.org> Date: Wed, 14 Feb 2024 12:19:43 +0100 Message-ID: <87r0hfmgxc.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Scanner: mx12.migadu.com X-Migadu-Spam-Score: 4.69 X-Spam-Score: 4.69 X-Migadu-Queue-Id: 5593E24587 X-TUID: w546pJ2aB9O7 Hi, On mar., 13 f=C3=A9vr. 2024 at 16:04, Liliana Marie Prikler wrote: >> 1. I think that the current placeholder can be confusing (quote vs >> double-quote). > > Is this something we can fix by pointing out the single quotes, or is > it better not to try that? Well, even if it would be using Gash, the issue quote/double-quote would be still there because it is too late =E2=80=93 it does not depend on Guix internals but only user Shell script. If you are envisioning the user Shell would be Gash, well for what it is worth, I am not convinced that =E2=80=93 as an user =E2=80=93 I would switc= h; I will still use Bash, almost surely. ;-) Therefore, GUIX_EDITOR_LOCATION_FORMAT needs to support Bash compatible syntax. And thus, the placeholder will stay =E2=80=93 at least for backward compatibility. I propose {LINE} because it seems familiar with ${LINE}. Or I proposed . Ludo proposes %LINE%. Last, I am not sure to understand the idea behind Gash. And if is something about Guix internals, then the best will be to have an internal replacement from =E2=80=99PLACEHOLDER=E2=80=99 to =E2=80=99${PLACE= HOLDER}=E2=80=99 and not to have something that the user Shell can interpret. All in all, IMHO, let pick one of them: {LINE} %LINE% :-) Cheers, simon