From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id wKlEOGlT2mUp+AAAe85BDQ:P1 (envelope-from ) for ; Sat, 24 Feb 2024 21:36:58 +0100 Received: from aspmx1.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2.migadu.com with LMTPS id wKlEOGlT2mUp+AAAe85BDQ (envelope-from ) for ; Sat, 24 Feb 2024 21:36:58 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=f2uuYSl7; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1708807017; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=+4juqqrRdhRf9yBWGXOptyFLPxZda+m3AwvEse3kf1k=; b=O+FRkq9ZlBJ7u21Jw1vUhkahth+KuEoU9wN+DJ+/fW7DyTTGluWAVcmlcKyf3sx+5EwXZD CWNOQI5NmMLh8UdjHNf+8B6/sXWqIrSOGtvXQCewFUnXRWRNvd5zkZv8lU0IocSqBzcTUv hFm+tT+Tikiau+qzQVFgVtl0d3WzCW8yzQGmR9rouPZ89Dlckni60q3Wapj2ETP7yvqVgA LzaFE7EYdEEIBstSzkcKgPKV21v2dQhuLDOhhb5RTBe9fxSxrWN1hS+VR7Q4pY5ug+BT9Z wB1qU2NlNOfuFSW+kkPUHix03Xn4/416oKZ/mNY/bvIqnk0wtn/hlgk9R32/XQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=f2uuYSl7; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1708807017; a=rsa-sha256; cv=none; b=l3mQT+23ipDBHvxjS8JXmGfGNW6GpG02LjCrgY4FNr+hWeV/DwJMeKFuylzakFCCUxzSlk oC7vIRLVPceUwrfioUNsGiM0FV6xNtlXgI7fEKjzERpA0FgqWaemaCpAqxo7xOXr/uFg7j B/Oqm5mkIWfs6RKZfurIRqpiN6zjWNkcDnOyoCfvrcgNZU+nb3bThlSgUwv9uB1j9o9Nlc K7NSnd+niJQOQ4plbCHa2pEkC4GnoFjNKB+1pVquzhCUB3s6+EIEcgkGqUMAUgqxMva+aA eB+dvhasepb1j9M7NDsDbYb3S8EwOuD10H8RGKpdEwZzhMTtFj+TSWqvymcM1g== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id A7BA43A7F2 for ; Sat, 24 Feb 2024 21:36:57 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rdylL-0007VI-CB; Sat, 24 Feb 2024 15:36:47 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rdylD-0007Uv-8o for guix-patches@gnu.org; Sat, 24 Feb 2024 15:36:40 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rdylB-00077F-Sp for guix-patches@gnu.org; Sat, 24 Feb 2024 15:36:38 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rdylZ-0002Ok-TC for guix-patches@gnu.org; Sat, 24 Feb 2024 15:37:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#68813] [core-updates PATCH 08/20] gnu: pkg-config: Alias to pkgconf-as-pkg-config. Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 24 Feb 2024 20:37:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 68813 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 68813@debbugs.gnu.org, Ekaitz Zarraga , Efraim Flashner Received: via spool by 68813-submit@debbugs.gnu.org id=B68813.17088069659109 (code B ref 68813); Sat, 24 Feb 2024 20:37:01 +0000 Received: (at 68813) by debbugs.gnu.org; 24 Feb 2024 20:36:05 +0000 Received: from localhost ([127.0.0.1]:56006 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rdykf-0002Mr-4H for submit@debbugs.gnu.org; Sat, 24 Feb 2024 15:36:05 -0500 Received: from mail-qt1-f173.google.com ([209.85.160.173]:52670) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rdykc-0002MB-Sc for 68813@debbugs.gnu.org; Sat, 24 Feb 2024 15:36:03 -0500 Received: by mail-qt1-f173.google.com with SMTP id d75a77b69052e-42a029c8e62so16045391cf.1 for <68813@debbugs.gnu.org>; Sat, 24 Feb 2024 12:35:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1708806873; x=1709411673; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=+4juqqrRdhRf9yBWGXOptyFLPxZda+m3AwvEse3kf1k=; b=f2uuYSl7xQrdVm5wS27bWgQje2rUIWGfw5qVJGra5nBXiUvN+zhddlQ4UYWx60qJAS NMTQTf1XDjWiIf2+REvwwvNDdFsCRQdsXP4Inkw26FuuufMJRgKMf6zyfuhHmpfJGo2m umSWr/AaUoLQR5tRdmvMMQid/dZA7H9d3qJW47PNJBIYAGWI/ESO5AowYRGOrOel6Noc T5jbSk3tdbsnEyfbttdfhLQcYcRTQ5Hd9Y6UH4tRKHi/R5U6XfakGNX7v0un4EDfoHSy qmF74H7WkhCdjYkZ5vi2DEGCv5tDM/CXA1AvmXMmr6AbeS/b2+Rx9Ld8wNi2s7YJ/om3 LFOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708806873; x=1709411673; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=+4juqqrRdhRf9yBWGXOptyFLPxZda+m3AwvEse3kf1k=; b=DcPxlnwxeJf3n5r2qj1nsDnaON/5vWawJfx+r295yz1fgDr98Qg8VyErrj01ydX5pY rOT4pUgVqLoIsZMEWG4PfxPwWROAunhDb03Yu2qv4EYAZ8PayiPgqCub8G+SeS21ELg7 C+1IJ30kp5Ld9xhB9KNGc+y/yMxf0F0VQUzXX7VMYT7o+l+MRnWNASfNrv2NdiL9Z/kM l6X26IRnn9BZycaj0kGKOI2cmgjZ/cely4KkbemGuIHz+VaH2wlfsfBMMr5iQSdIsAdw KiL0ARWJ7IuaJAOnxEhVPmDTeMc+eAgVQaDS+zkWQdbVTkIUKGeYXtg3Yimq5buSCrRC 8ogQ== X-Gm-Message-State: AOJu0YwX9jilcjFavRGQf/5bjU4iGmsJL/iRe1GpUERNr0IYNSBW8lGl jSXL4OqyL/ELbnZ6UHHwbUffGKm4g7kcntM/7X+oJghLL0CmBrPT X-Google-Smtp-Source: AGHT+IFs81rXScm8fDwQrUmFLDfjg5OrsDp0mGc+Hk9V/xzyXY0FB2V6Q7pegW/H+LRMAmoFlsr+MQ== X-Received: by 2002:ac8:4c83:0:b0:42e:4f6d:3ba0 with SMTP id j3-20020ac84c83000000b0042e4f6d3ba0mr2798626qtv.48.1708806872898; Sat, 24 Feb 2024 12:34:32 -0800 (PST) Received: from hurd (dsl-159-251.b2b2c.ca. [66.158.159.251]) by smtp.gmail.com with ESMTPSA id n11-20020ac85a0b000000b0042e6198372dsm879465qta.97.2024.02.24.12.34.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 24 Feb 2024 12:34:32 -0800 (PST) From: Maxim Cournoyer In-Reply-To: <87y1baay2p.fsf@gnu.org> ("Ludovic =?UTF-8?Q?Court=C3=A8s?="'s message of "Sat, 24 Feb 2024 12:41:50 +0100") References: <87y1baay2p.fsf@gnu.org> Date: Sat, 24 Feb 2024 15:34:31 -0500 Message-ID: <87r0h1mwiw.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: 2.73 X-Spam-Score: 2.73 X-Migadu-Queue-Id: A7BA43A7F2 X-Migadu-Scanner: mx13.migadu.com X-TUID: m7c/VeuwERJ9 Hi Ludovic, Ludovic Court=C3=A8s writes: > Hi! > > Maxim Cournoyer skribis: > >> This switches the default pkg-config implementation used in Guix to pkgc= onf. > > I didn=E2=80=99t follow discussions and I learned about =E2=80=98pkgconf= =E2=80=99 only recently. > I=E2=80=99m afraid that adding this to =E2=80=98core-updates=E2=80=99 wou= ld further postpone its > merger, which was already being discussed beginning of January. Was it in a good shape to be merged back then? It seems to me we are still ironing things fairly low in the tree such as a glibc upgrade by jpoiret (for security reasons), which leaves the opportunity to tackle well tested changes to it, which this one is. > Should it instead be done on a separate branch? I've manually rebuilt a good chunk of the world (mpv and plasmatube) using pkgconf, and haven't seen any breakage caused by it. You can try do build these patches on top of current core-updates on the hydra-guix-129 machine, which should still have it in its store. > (Aside: where should I read about the rationale of the pkg-config -> > pkgconf move?) It all started with f3fdb4e041cb5740ba0b38b9ad017571f8414d33 ("gnu: mpv: Propagate most libraries."), which was probably triggered by mpv newly using Requires.static fields in their pkg-config files (Meson knows to do that). Looking for nicer alternatives to propagating these, pkgconf picked my interested as it's supposed to fix some of the pkg-config long time "bugs" that upstream is not too keen to fix (for backward compatibility, I think), such as this Requires.static behavior: Current guix, with above f3fdb4e041cb5740ba0b38b9ad017571f8414d33 commit reverted: --8<---------------cut here---------------start------------->8--- $ ./pre-inst-env guix shell --pure pkg-config mpv \ -- pkg-config --print-errors --short-errors --exists mpv Package 'wayland-client', required by 'mpv', not found $ echo $? 1 --8<---------------cut here---------------end--------------->8--- Compare with: --8<---------------cut here---------------start------------->8--- $ ./pre-inst-env guix shell --pure pkg-config pkgconf mpv \ -- pkgconf --print-errors --short-errors --exists mpv $ echo $? 0 --8<---------------cut here---------------end--------------->8--- The above demonstrates that pkgconf's behavior is to consider *.private fields only when provided the --static option, which is what we want. I hope this helps understanding the rationale. --=20 Thanks, Maxim