From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms1.migadu.com with LMTPS id aNE+CjGzHWZdwQAAe85BDQ:P1 (envelope-from ) for ; Tue, 16 Apr 2024 01:07:29 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2.migadu.com with LMTPS id aNE+CjGzHWZdwQAAe85BDQ (envelope-from ) for ; Tue, 16 Apr 2024 01:07:29 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b="Dv6e/VvS"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1713222449; a=rsa-sha256; cv=none; b=KgJ97D+PwKtc9i8ovF6vbAbPX8Sdll2dv9SB182iVFCKB33fd2wbmrpvKh4qWkNz8nEKtb HmWccj2n2bYRc8vmOMzKAn7B+YKQ485PcZ+MkFUOathB+4OiBaPojhhKlnDpeglwlBr8Nr 9P8eZTyeXcSAISMgk3jZ5c+N4vz/T7ztVT2p/uVGNdEIUuZbCLMFITn4qkxuH8F/OGl+NW kDl+u06Ue2btE/Zh8dKz+MoDW7V7noS4wFd5EQVFsZI3FGyWI+YVrE26Poo6HJ6vWwZfzr ClCef1TEYci+xCUHolZ7uA8sHhDXqYqXi7hiCPMCM6+VCZfKCiMYY7LElvfYmA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b="Dv6e/VvS"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1713222449; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=d9nvPTwa7bJlNgH4lkLhFSLHyDOd5gjWYZDXF8ZIp58=; b=B4u1mX1bfX/hs5NcGUaBlR50Rue8WQVYb1Sqqkwky0dG6Ne1mPPpoIvQ3963LlOeAQSs47 QH93qYuFznUJNZPM9KQx+Pcu6/ytVIYGVdV8QKWEZ1oFgAC2ESS6493KvG2Z6OX3CKTt/K KJ5IJIFw1jRg8q4+FcytkvY4UojZRhy9vvkBgMEKukyYIxlR9Rjj8vzNg7CoI0tbUatvDo 8mMQD1RjfM1DmgfaYri8HBbWDH+QtYjDATEuZZyiBoJJqBedmkd1Z0Cud9gC5wXhJdOZrA k5Ji33nGMPPcbFBzhDdr2IHe6xNQ0N/N8a8VpaTQcZrsL0BLV50E+JjCwMG5uQ== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 15ADA74804 for ; Tue, 16 Apr 2024 01:07:29 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rwVPf-0004AY-Kg; Mon, 15 Apr 2024 19:06:59 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rwVPe-0004A2-55 for guix-patches@gnu.org; Mon, 15 Apr 2024 19:06:58 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rwVPa-0003Pd-0M for guix-patches@gnu.org; Mon, 15 Apr 2024 19:06:57 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rwVPl-0002UI-7y for guix-patches@gnu.org; Mon, 15 Apr 2024 19:07:05 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#70132] [PATCH 05/11] channels: Autoload (git =?UTF-8?Q?=E2=80=A6?=) modules. Resent-From: Simon Tournier Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 15 Apr 2024 23:07:05 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70132 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= , 70132@debbugs.gnu.org Cc: Josselin Poiret , Mathieu Othacehe , Ludovic =?UTF-8?Q?Court=C3=A8s?= , Tobias Geerinckx-Rice , Ricardo Wurmus , Christopher Baines Received: via spool by 70132-submit@debbugs.gnu.org id=B70132.17132224029393 (code B ref 70132); Mon, 15 Apr 2024 23:07:05 +0000 Received: (at 70132) by debbugs.gnu.org; 15 Apr 2024 23:06:42 +0000 Received: from localhost ([127.0.0.1]:40187 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rwVPN-0002RQ-Sf for submit@debbugs.gnu.org; Mon, 15 Apr 2024 19:06:42 -0400 Received: from mail-lf1-x129.google.com ([2a00:1450:4864:20::129]:39263) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rwVP5-0002Ng-Ec for 70132@debbugs.gnu.org; Mon, 15 Apr 2024 19:06:24 -0400 Received: by mail-lf1-x129.google.com with SMTP id 2adb3069b0e04-51788cbec59so1460859e87.1 for <70132@debbugs.gnu.org>; Mon, 15 Apr 2024 16:06:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1713222365; x=1713827165; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=d9nvPTwa7bJlNgH4lkLhFSLHyDOd5gjWYZDXF8ZIp58=; b=Dv6e/VvSRJ1DUGfXnNSN5bIC91Zh9tcOc1FHWk8NXZ72uSLIro8us5PW3WnouqGPN8 mO3EtfQORynb8vM5WaG0DiPIAXIDcmJm+DhSm/20mUePxqrgve3MEZLjl88SCn89N8c5 7q72tYmD2NopvpN0E69UF+q11F6HywwftsgqBG6uGerDB9PJmToex1Ll5I8MgqvawIEc rYBxSY0mf0QL2JWOlypooIn7Yzb4Az8X9F2pcekD6S0olz7LDnljapdtqKG+/3T+8yx/ dAyVX0iEaA4aXsiIbrQ2OAQjqpmM1+GBcL3kyCK8SR/9P+MLvsfYxNLhcYCEirXgvv63 6cZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713222365; x=1713827165; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=d9nvPTwa7bJlNgH4lkLhFSLHyDOd5gjWYZDXF8ZIp58=; b=TxcZY+UZKCou38DhtjM7rVMYrkF9Li5ujVgI0V4bvdwCZIe70YY0e3K4ZptxX3yp/b xCIshwFN0twp59iKq8tTCNngInugA/J+krY0+du4z+AeQXCERvumW8CzTypnk1AnpCYB 1xpXlhb2g6JKpxFGoTjQ/pZeda5/BvVmDOpiIAgZTk5Ui9oJEI28Iy734TEBQe5dvO/0 j/w/mktyE76h/bHxcHhgz2ThGF+2k5zvUV88uhZ2zR63K3ZvYKBPOSJczO+DTMgVrXpD nguZx8FlspoJduErAcy1UJoaqXc/uAQu4rVKbnYDLPYUbVrJA7vNVwKvwGHXRIs8Kdxf XBiw== X-Forwarded-Encrypted: i=1; AJvYcCVmBAhHlduZcjb4SQGbEtJC9ylLJKvrqr/vbd4MEILPpaqLq6lMshW5xg+6o+ooQJXr/qrYOYjeVpXpNyieq8mmoyUQLPY= X-Gm-Message-State: AOJu0Yw8CAp4VXNwyJYDuSd1gaD3JhudWBjKDddm3LuliIZptBFdtKXh u6ZeB8TvIvuG1pccUhSqHoy78JVrHNaLInP+idT/hV49/MB6Bptk X-Google-Smtp-Source: AGHT+IFQjgOct9dRxPyc9AXMdHhpcKdfNuBa9NeBbIHGvUiuHORBCNiX8GX5oQtBleVvH9YinKfkVQ== X-Received: by 2002:a2e:991a:0:b0:2d6:fe13:f9aa with SMTP id v26-20020a2e991a000000b002d6fe13f9aamr6783873lji.3.1713222364910; Mon, 15 Apr 2024 16:06:04 -0700 (PDT) Received: from lili ([2a01:e0a:59b:9120:8fb6:fef1:cfc0:b0f]) by smtp.gmail.com with ESMTPSA id v7-20020a05600c470700b00416b2cbad06sm20963028wmo.41.2024.04.15.16.06.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Apr 2024 16:06:04 -0700 (PDT) From: Simon Tournier In-Reply-To: References: Date: Tue, 16 Apr 2024 00:45:20 +0200 Message-ID: <87r0f6w8hr.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Spam-Score: -5.27 X-Migadu-Queue-Id: 15ADA74804 X-Migadu-Spam-Score: -5.27 X-Migadu-Scanner: mx10.migadu.com X-TUID: 4Uo8noiECplx Hi, On lun., 01 avril 2024 at 22:25, Ludovic Court=C3=A8s wrote: > Autoloading Guile-Git is important in cases where (guix channels) is > used for little more than the definition. This is the case, > for example, of =E2=80=98guix describe=E2=80=99 or =E2=80=98guix shell=E2= =80=99. > > This reduces from 177 to 121 the number of .go files loaded when > running: > > ./pre-inst-env strace -e openat -o /tmp/log.strace \ > guix describe -p /var/guix/profiles/per-user/$USER/current-guix > grep 'openat.*\.go.* =3D [0-9]' < /tmp/log.strace |wc -l > > Likewise, it reduces the max RSS (as measured by =E2=80=98time -f %M guix > describe -p =E2=80=A6=E2=80=99) from 54 to 37 MiB. > > * guix/channels.scm: Autoload (git =E2=80=A6) modules. > > Change-Id: Ia58a99c865bf0f6fe461a1e71390d075e760f8d6 > --- > guix/channels.scm | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/guix/channels.scm b/guix/channels.scm > index 70608561f9..51024dcad4 100644 > --- a/guix/channels.scm > +++ b/guix/channels.scm > @@ -20,7 +20,13 @@ > ;;; along with GNU Guix. If not, see . >=20=20 > (define-module (guix channels) > - #:use-module (git) ;TODO: autoload > + #:autoload (git commit) (commit-lookup > + commit-id) > + #:autoload (git oid) (oid->string > + string->oid) > + #:autoload (git object) (object-id) > + #:autoload (git errors) (GIT_ENOTFOUND) > + #:autoload (git structs) (git-error-code) > #:autoload (guix git) (update-cached-checkout > url+commit->name > commit-difference Oh! Awesome!! Thanks for the tricks. Cheers, simon