From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms1.migadu.com with LMTPS id EBf7IygwRmYN6gAAe85BDQ:P1 (envelope-from ) for ; Thu, 16 May 2024 18:11:20 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2.migadu.com with LMTPS id EBf7IygwRmYN6gAAe85BDQ (envelope-from ) for ; Thu, 16 May 2024 18:11:20 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1715875880; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post; bh=oK+5LMVA8UzOpCe3TTr2KZOvLJsHLJE9SQ/hJCSmHF4=; b=F204eRUZPIbecidA16N41CluZA2zHxI5ikfyA6Fgk+pnZQWgmmk9aj8OxQX3w0x8aAc5hW gTnazLblJIJTbL/A8+zAjYwnqy3ALE3UUOusw1MZG9CB8toMZvZqDtPsIm4mS6R2m27h0l BkJFBPo04RVRwVvAS3nEERS8t98HbumlEAxIzSTMhtFFhhUw+jJYcPnVV48Nx4sa+P6phS vrymvtdgUVGx8bbp6sI79av0exWjUlOP5iscFHrtUKgBMLFYER4RB1tW5kqxWvR1UbKBEH WZi7IFYuEl0k5Dhyw/oNCEgvQnJtSZI2VzXeSs0Tw55kAmQ3mY618bOkWUaGtw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=none ARC-Seal: i=1; s=key1; d=yhetil.org; t=1715875880; a=rsa-sha256; cv=none; b=OtajLqlgXi3T28eQgEOuNWvUZZZOvLtvpQ+ClSqPx15ruGjVISaYOE6mtuPgYt9eZA/Y/X gj8+mWygW95jRl5goh311BRxn07Uu11l5+1/I9Mm/PZI9lIa9c5CG2ZKsbnsgSTlL27zf0 hOay0ffLotNzRGCqNlVfCbEcsET3eUf/kLR49+rFlkUjmdJsfqK18ZCgAQfQcJKW+7XFwg JzCzeQTRoSNrHxbI7IQqXQuFxwwiIp9FlDpjB86lwY6SF8L51INrggsEN2tRzV/EhIuFR5 a3v3LVvK/63hegJMUXSm/Uqp40pSUSfAT3aoqTxbRv3LRHdTPEVhNawfd+3uAA== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 5A0F26AB77 for ; Thu, 16 May 2024 18:11:20 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1s7dhB-0007W0-Rp; Thu, 16 May 2024 12:11:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s7dh7-0007VT-RI for guix-patches@gnu.org; Thu, 16 May 2024 12:11:02 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1s7dh6-0000RZ-DH for guix-patches@gnu.org; Thu, 16 May 2024 12:11:00 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1s7dh8-0000Jl-Kx for guix-patches@gnu.org; Thu, 16 May 2024 12:11:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#70985] [PATCH 4/4] guix: build-system: meson: Don't error on unsupported targets. Resent-From: Christopher Baines Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 16 May 2024 16:11:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70985 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 70985@debbugs.gnu.org Received: via spool by 70985-submit@debbugs.gnu.org id=B70985.17158758411203 (code B ref 70985); Thu, 16 May 2024 16:11:02 +0000 Received: (at 70985) by debbugs.gnu.org; 16 May 2024 16:10:41 +0000 Received: from localhost ([127.0.0.1]:49578 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s7dgn-0000JL-2s for submit@debbugs.gnu.org; Thu, 16 May 2024 12:10:41 -0400 Received: from mira.cbaines.net ([212.71.252.8]:43542) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s7dgl-0000JD-4K for 70985@debbugs.gnu.org; Thu, 16 May 2024 12:10:40 -0400 Received: from localhost (unknown [45.67.83.153]) by mira.cbaines.net (Postfix) with ESMTPSA id C6CB427BBE2; Thu, 16 May 2024 17:10:35 +0100 (BST) Received: from felis (localhost [127.0.0.1]) by localhost (OpenSMTPD) with ESMTP id 5014c898; Thu, 16 May 2024 16:10:34 +0000 (UTC) From: Christopher Baines In-Reply-To: <87jzjtbxib.fsf@gnu.org> ("Ludovic =?UTF-8?Q?Court=C3=A8s?="'s message of "Thu, 16 May 2024 17:13:32 +0200") References: <3828bc238a8cc400f9686fe6856c665c31e927dd.1715871966.git.mail@cbaines.net> <1f217c47d4494a29035dd136c2672771990c0eb0.1715871966.git.mail@cbaines.net> <87jzjtbxib.fsf@gnu.org> User-Agent: mu4e 1.12.2; emacs 29.3 Date: Thu, 16 May 2024 17:10:16 +0100 Message-ID: <87r0e1n3fb.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Spam-Score: -8.47 X-Migadu-Queue-Id: 5A0F26AB77 X-Migadu-Scanner: mx10.migadu.com X-Migadu-Spam-Score: -8.47 X-TUID: l+Uck9Yk76GN --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Ludovic Court=C3=A8s writes: > Christopher Baines writes: > >> Rather than raising generic errors. >> >> * guix/build-system/meson.scm (make-machine-alist): Return #f if the tri= plet >> is unsupported. >> (lower): Return #f if the machine alist is #f. >> >> Change-Id: If6a1f8d1c2073e43107406ac186aa9c845005a95 > > [...] > >> + (and >> + (make-machine-alist target) > > I think this call is unnecessary (and kinda confusing because > =E2=80=98make-machine-alist=E2=80=99 is a pure function) because =E2=80= =98meson-cross-build=E2=80=99 > calls =E2=80=98make-cross-file=E2=80=99, which calls =E2=80=98make-machin= e-alist=E2=80=99. The situation here is that the meson build system does support cross builds, but make-machine-alist calls error for some targets which I'm treating as a bug here, because error isn't really machine readable. I think this line should actually be (or (not target) (make-machine-alist target)) to handle the case where the target is #f, but this is sort of helpful in that it changes the error to the usual error when the build system doesn't support cross builds. This is still far from perfect though as the UI would say that "build system `meson' does not support cross builds", which is obviously wrong, it just doesn't support cross builds for the given target. I'm not sure how to signal this though? --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKlBAEBCgCPFiEEPonu50WOcg2XVOCyXiijOwuE9XcFAmZGL+hfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcRHG1haWxAY2Jh aW5lcy5uZXQACgkQXiijOwuE9XeM9xAAgX33MTDVeDWUVmgzAkuIhcxuWiIC46lI Bm7F4xXBAP07gpXsyAr+fzjdlK68ETBzRHXVJFRaFZMQnrHQ6JFJiYpLFu+pyrAC c0vGVRAiJdBJOjdeUSiJ22F7eiMdeJktZ3ucvi90Cm7YcnlcPG8F+Wue0Pe011kH JmMQs6/4YmrG26m6HLI6KvLNik4W3xOf8Ch+oOgNHDMySqFK3OmwBNDOXnxSdGWM klh603MvRxwXoHXUNpbBN/JOq2ksEs99bqg1rD4C2P6C8G+PCXgaTt/YIZW99gai 2xtNEib/ouVqIQrnAtd9u2+KTVXktD0c4Bfg/h7rxmrrrzibTtNfqCyRx0lNLida KqZCDpRhsvCvXdWfCT/1TTYXb4OQzn6xHmLnsqRbSVTmBk9XCzEdePwfzIIdwdGl FIyqmtIQHpL7P4uVL1NL4yAliS2D9pt8hGMa4OSiibAWEMxceYu6NiXfYhtZ/NoX GWg8hiIxWq18AZmN+oBjde3oCQNSGkXoVTh10wNNhJdTG+Rywn+VFDcOHK47GIL6 Lu8KDo6yP+x62LtFAwNFdNEIC/sp2CdDSNIMK7szre3uWYvx84yrnj05osHwvmcG 66zQdQjEEsmIS919LtzwKI/2tHT9GT0Cn0v0Hc0axtKxuxJkeEvwpTvxXv3SHG4w gb3MBCXlSRM= =Q6Hk -----END PGP SIGNATURE----- --=-=-=--