From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1.migadu.com ([2001:41d0:1008:1e59::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms1.migadu.com with LMTPS id SOzzHYc5TWZZ8wAAA41jLg (envelope-from ) for ; Wed, 22 May 2024 02:17:11 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1.migadu.com with LMTPS id 2C9xGIc5TWYVLwAA62LTzQ (envelope-from ) for ; Wed, 22 May 2024 02:17:11 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=h8uQa3yW; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1716337031; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=wqGtuEYnO2wBZXhocr4chnr/1qI/HebSLvOvcX6Zd4Q=; b=ST6n2QWrUlGzxCKLLFJhB6s4t0ttCpm00TYY+WD8yEgaNDWCpChPO1RGdKI/HNeoLpDc7L NcQNHj+R7DZnC/lP/8se3dY6qnV0nzFpJlyO5FaVgflw/6P8CztsJzwJvTlEVp9J8z1XYu 6SdqHc/MENdfNThC9zzD/HutIHO5il3R5qGjI/EP4/LL9r1D20TUR4uSW7bQF+Zq+B2N4z Ehl2tbO4GbspE+7wEVbFYx5lSR1jXVdLd3SVgWFKT/TAU7Lk4LhtJqN0coj+ExthVR+mKk IocIgM2fGlqAz9AMO8yPgDXjNU2iwLWIttYTriv86lEypY9nHXarQKfe0v2jvA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1716337031; a=rsa-sha256; cv=none; b=o500qeGm9EP78Dc3RXTntHKMUrmfU02tS9ej+3vHin1kyQWtO9iZHR9LXQ7DEwrnN6y1Vr YsCCs1q+KCz4DgjrWmG5bjmFv82v2/8CbTJD4/POB/5j7hekxB77gCACgYaYQBqmwy7qzF 9s/oQ6Bl2UdBaWUYR/KItLNghreHcufCtbV6u40mncCo2UaostTFB+Loj1OYNs85OlRk3B +n2gTCPmXdjh4NwjwPH6W27MsuUYUMrPtj3x3N5PcKO0CZpNrh/zHHe9OFJO9LvRkq3WOk omqpB/w+xntC0fVJ5LSA9quMz2nvIk7suClmwLkg2HihrJOApv6f77oqNse90g== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=h8uQa3yW; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 37F127700 for ; Wed, 22 May 2024 02:17:11 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1s9ZfF-0002YD-RI; Tue, 21 May 2024 20:17:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s9Zf8-0002Vo-1D for guix-patches@gnu.org; Tue, 21 May 2024 20:17:00 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1s9Zf7-0007mG-4q for guix-patches@gnu.org; Tue, 21 May 2024 20:16:57 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1s9ZfC-0008KK-Hi for guix-patches@gnu.org; Tue, 21 May 2024 20:17:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#71022] [PATCH] configure.ac: Set default value for the 'prefix' variable. Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 22 May 2024 00:17:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71022 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ricardo Wurmus Cc: zimon.toutoune@gmail.com, vagrant@debian.org, ludo@gnu.org, efraim@flashner.co.il, andreas@enge.fr, attila@lendvai.name, richard@freakingpenguin.com, 71022@debbugs.gnu.org, janneke@gnu.org X-Debbugs-Original-Cc: Simon Tournier , Vagrant Cascadian , ludo@gnu.org, Efraim Flashner , Andreas Enge , Attila Lendvai , Richard Sent , guix-patches@gnu.org, Janneke Nieuwenhuizen Received: via spool by submit@debbugs.gnu.org id=B.171633700831999 (code B ref -1); Wed, 22 May 2024 00:17:02 +0000 Received: (at submit) by debbugs.gnu.org; 22 May 2024 00:16:48 +0000 Received: from localhost ([127.0.0.1]:52020 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s9Zey-0008K3-14 for submit@debbugs.gnu.org; Tue, 21 May 2024 20:16:48 -0400 Received: from lists.gnu.org ([209.51.188.17]:54322) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s9Zew-0008Jx-2z for submit@debbugs.gnu.org; Tue, 21 May 2024 20:16:47 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s9Zem-0002SZ-2W for guix-patches@gnu.org; Tue, 21 May 2024 20:16:38 -0400 Received: from mail-qk1-x72c.google.com ([2607:f8b0:4864:20::72c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1s9Zek-0007lf-Fx; Tue, 21 May 2024 20:16:35 -0400 Received: by mail-qk1-x72c.google.com with SMTP id af79cd13be357-792e4c2a002so55548885a.0; Tue, 21 May 2024 17:16:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1716336991; x=1716941791; darn=gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=wqGtuEYnO2wBZXhocr4chnr/1qI/HebSLvOvcX6Zd4Q=; b=h8uQa3yWBsXWNN7Zjc41c2GVu+XlhCwRBT4bu7n+uNgVezaWUlJrgRYQ5MEoN4g5hM aolYCVa7DCMjgvDjbJtM5drbGAvLZZTGkS6+rdOgnO0MipdZr+fIwYd+XLXLa0n6G43D 03KFe7lkXY/1mwqzUJRLm3YzL34DBFL5LUt7rnGbibgQh7YmVuCvBPY7nSSeHYOwSwjJ 5/ZqtFxfSMuCr8nRbzxFm64HvmSRptPlEJ7+qJ9xC6iDm6QTwtumrYDVkHG28BAy9Ijk i+20fAltqMl5jQDylTiZGn01R8xNXJ6ftFgDD/6vnsQhoHq6Y352HHXNy7vyn5udhhpp yz0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716336991; x=1716941791; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=wqGtuEYnO2wBZXhocr4chnr/1qI/HebSLvOvcX6Zd4Q=; b=kfMu2yFgSXBf40SR2dPRf2AA8++ybf0LWUZ6Ovah0ws/rmuWjWvvZzDDVWqrXfUgNs LAu2ZCZczzbK8Aq9+BeMPOVrgnDGsHDFAPR88kZB1X0UZCuXOG+x9lwLF+5AeCCPpDL1 CdnoCHgi/Bheq3Y8BzlkbkqlhpZeJ6NNsoTCZUip7MAXDD7DKmrBFSWEY6wFxMaepwpE dhRCEClMApAVppkqkEYgp1f7/chYw4EPGTT7I8yFdnS/JnsFuOiQLeiHUwl7xAKLUJe/ rGlKtxoU3DgfxlxFMyei1a/EthyB46MWImVd817zoWkmiMWO4f4IOaHI9S3Whp2S90P4 xL1Q== X-Forwarded-Encrypted: i=1; AJvYcCWjgU0PY+eYmA5xXxZdgZDHlx6o6xoKSz1OSkk0HVG5arparregpOP8naLfB02f4XlIx85LVT0bpIY2VjHcsX5q42wYYk9WktVkPmh88g== X-Gm-Message-State: AOJu0Yw9GdaAjFHeK39TRV1fxbWoPwCIfntuMLkiQGtkshjrSQN8qO8X zosCPxp8zU5xpNLxhpgV10cMoARe8ZIyP7F8+HBKdknbf/FDzJkI X-Google-Smtp-Source: AGHT+IEWBoo8aKQ+rhH3wECek+er/5s3+pgrDtnmm/i6RTQEI2dsnRcEdQUdqHyCbbcfWAsQO+YxXQ== X-Received: by 2002:a05:620a:4ce:b0:792:989e:7c5b with SMTP id af79cd13be357-794994b3f82mr46181585a.60.1716336991148; Tue, 21 May 2024 17:16:31 -0700 (PDT) Received: from hurd (dsl-205-233-124-234.b2b2c.ca. [205.233.124.234]) by smtp.gmail.com with ESMTPSA id af79cd13be357-792bf2972cdsm1325371785a.54.2024.05.21.17.16.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 May 2024 17:16:30 -0700 (PDT) From: Maxim Cournoyer In-Reply-To: <87h6eunkw3.fsf@elephly.net> (Ricardo Wurmus's message of "Sun, 19 May 2024 12:42:04 +0200") References: <9ac2df37867548ae5e15e4c262458d8fc63ba9a1.1715989953.git.maxim.cournoyer@gmail.com> <87h6eunkw3.fsf@elephly.net> Date: Tue, 21 May 2024 20:16:28 -0400 Message-ID: <87r0du4s6b.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2607:f8b0:4864:20::72c; envelope-from=maxim.cournoyer@gmail.com; helo=mail-qk1-x72c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -0.96 X-Spam-Score: -0.96 X-Migadu-Queue-Id: 37F127700 X-Migadu-Scanner: mx11.migadu.com X-TUID: KYuR2Txjy6FT Hi Ricardo, Ricardo Wurmus writes: > Maxim Cournoyer writes: > >> -When configuring Guix on a system that already has a Guix installation, >> -be sure to specify the same state directory as the existing installation >> -using the @option{--localstatedir} option of the @command{configure} >> -script (@pxref{Directory Variables, @code{localstatedir},, standards, >> -GNU Coding Standards}). Usually, this @var{localstatedir} option is set >> -to the value @file{/var}. The @command{configure} script protects >> -against unintended misconfiguration of @var{localstatedir} so you do not >> -inadvertently corrupt your store (@pxref{The Store}). The configuration >> -directory should also be configured by setting the @option{--sysconfdir} >> -option to the @file{/etc} value, which is the location used by Guix to >> -store for example the access control list of authorized machines and the >> -definition of offload machines. > > This information is still useful, isn't it? It's important for people > who intend to modify these locations, such as system administrators who > might want to install things elsewhere. Perhaps this could be rewritten > to explain why this would be a bad idea. It's useful, but it's duplicated with the warning you'd get from the GUIX_CHECK_LOCALSTATEDIR m4/guix.m4 macro: --8<---------------cut here---------------start------------->8--- dnl GUIX_CHECK_LOCALSTATEDIR dnl dnl Check that the LOCALSTATEDIR value is consistent with that of the existing dnl Guix installation, if any. Error out or warn if they do not match. AC_DEFUN([GUIX_CHECK_LOCALSTATEDIR], [ AC_REQUIRE([GUIX_CURRENT_LOCALSTATEDIR]) if test "x$guix_cv_current_localstatedir" != "xnone"; then if test "$guix_cv_current_localstatedir" != "$guix_localstatedir"; then case "$localstatedir" in NONE|\${prefix}*) # User kept the default value---i.e., did not pass '--localstatedir'. AC_MSG_ERROR([chosen localstatedir '$guix_localstatedir' does not match \ that of the existing installation '$guix_cv_current_localstatedir' Installing may corrupt $storedir! Use './configure --localstatedir=$guix_cv_current_localstatedir'.]) ;; *) # User passed an explicit '--localstatedir'. Assume they know what # they're doing. AC_MSG_WARN([chosen localstatedir '$guix_localstatedir' does not match \ that of the existing installation '$guix_cv_current_localstatedir']) AC_MSG_WARN([installing may corrupt $storedir!]) ;; esac fi fi]) --8<---------------cut here---------------end--------------->8--- So it seems judicious to remove it, especially since with this change the default `./configure` would no longer require the user to think about '--localstatedir' and friends (unless their system was an odd snowflake, in which case the macro would do its job to warn them). Does that clarify the intent? -- Thanks, Maxim