From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id GDfmGoC+cmZ6kwAAe85BDQ:P1 (envelope-from ) for ; Wed, 19 Jun 2024 11:18:24 +0000 Received: from aspmx1.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2.migadu.com with LMTPS id GDfmGoC+cmZ6kwAAe85BDQ (envelope-from ) for ; Wed, 19 Jun 2024 13:18:24 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=nicolasgoaziou.fr header.s=mailo header.b=b4rkstBD; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1718795904; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=JnpnzX4F4WizP0Ozbq63Le/C948r54Do02RRCOvObbQ=; b=Z7eZO66qh43dzrcIbByW0xpTbiwaPBtEE3Vkv/R7pfe806khIp/5Azm5GX61aQkEK8RDHg B47LZzzRfqL3WonhV8QQDsdPb37ZNCmpnmLWTW6mczuXQ/uVv4XbSywMKsI3MbsLUzvDHt 2BvkJnW2aSJPMgUWlVJxn6jKLF4N+q7X08IDwLEIv38h3YCjH+PNH26Vei/zYSoI4I8KCJ FXxUOwKORxUYxLomSdv43O/8pmS5CAMh2/8URkS/Cn/v/UjDdQxwbrTXY134/Z0u1yXQO7 2ee8W310uiJZ2JkH2lKMDD4J9WLz2qJtk6Jqb7/so/VvC5V/uPrc9ARFlSLcIw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=nicolasgoaziou.fr header.s=mailo header.b=b4rkstBD; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Seal: i=1; s=key1; d=yhetil.org; t=1718795904; a=rsa-sha256; cv=none; b=QqzRhweCUou1QjvlKpki3CPeOc0tir01NGsaDISkp/FaFjN4XomUOI4nnMlCCQ0Kj/XSDg jLnEcE5QVy4WMw2ImnO28Kr1pEIOdxnl+qzq6VA1fC2KZ3boT8g7ghR0jzGy0YkZcKV12X Ee4flnd0hwtLbujXdexrPKHiPf5rQ/8w8NaxWRr64LQxplX2uk8opJFfA1q/ltPlZBx4P6 ibA0NDN7K5GuAnoEad3axmY6EcJ9JAQ3ggjp1yeByG5s6RjFkqfGZaV+IPezPXd6yzHop5 94r0KGR9xQB237xwGOHrwkHHckaK7sL77K76K5yEZE5z5ha9D7+MLzA5aLWZhw== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 57D323F960 for ; Wed, 19 Jun 2024 13:18:24 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sJtKC-00037J-Pi; Wed, 19 Jun 2024 07:18:00 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sJtKC-00036z-0D for guix-patches@gnu.org; Wed, 19 Jun 2024 07:18:00 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sJtKB-0008A7-Ou for guix-patches@gnu.org; Wed, 19 Jun 2024 07:17:59 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sJtKE-0001gn-Tb for guix-patches@gnu.org; Wed, 19 Jun 2024 07:18:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#71319] [PATCH v2 2/3] gnu: emacs-ddskk: Improve package style. Resent-From: Nicolas Goaziou Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 19 Jun 2024 11:18:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71319 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: gemmaro Cc: 71319@debbugs.gnu.org, Katherine Cox-Buday , Liliana Marie Prikler , Andrew Tropin Received: via spool by 71319-submit@debbugs.gnu.org id=B71319.17187958226361 (code B ref 71319); Wed, 19 Jun 2024 11:18:02 +0000 Received: (at 71319) by debbugs.gnu.org; 19 Jun 2024 11:17:02 +0000 Received: from localhost ([127.0.0.1]:40310 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sJtJG-0001eM-1M for submit@debbugs.gnu.org; Wed, 19 Jun 2024 07:17:02 -0400 Received: from msg-2.mailo.com ([213.182.54.12]:38084 helo=mailo.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sJtJE-0001dz-OU for 71319@debbugs.gnu.org; Wed, 19 Jun 2024 07:17:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=nicolasgoaziou.fr; s=mailo; t=1718795811; bh=0uYZSmz1o8zGa1mFvvSLiTMihmtVxSwfFedVvYbw/Dc=; h=X-EA-Auth:From:To:Cc:Subject:In-Reply-To:References:Date: Message-ID:MIME-Version:Content-Type; b=b4rkstBDMfJX3Qsv2oH0HNvF79/irf3AGIU/0F1ltRwJTh62wRTSZWQlUbKtBvMbc aNn+oP/BI9u8Spuv98cCrkOM6I6Stnn0MVutDhgnbmdeLV3UfOGSIBBTmQjL0zDAUQ fIxYEZP3/3zWXvuoIAHLk/vh5r1qC7WLJvEpZ1rg= Received: by b221-6.in.mailobj.net [192.168.90.26] with ESMTP via ip-20.mailobj.net [213.182.54.20] Wed, 19 Jun 2024 13:16:50 +0200 (CEST) X-EA-Auth: pOrj1gDZyIDb4LlZXFD7YoUh1y399misuzJkSeO0lNzXCPyT8fPToB5NEYuMDq/pvDXuuIYpZilpi4I3M7pljoUh3cZzvoaL0R4le3yY2GY= In-Reply-To: <73fdffde326d9fdb418056b636e08be7b5be8644.1718104831.git.gemmaro.dev@gmail.com> (gemmaro's message of "Tue, 11 Jun 2024 20:20:30 +0900") References: <4328ea3c1b2e79691a6ed1d76e21688a5452f410.1718104831.git.gemmaro.dev@gmail.com> <73fdffde326d9fdb418056b636e08be7b5be8644.1718104831.git.gemmaro.dev@gmail.com> Date: Wed, 19 Jun 2024 13:16:35 +0200 Message-ID: <87r0ct41yk.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Nicolas Goaziou X-ACL-Warn: , Nicolas Goaziou via Guix-patches From: Nicolas Goaziou via Guix-patches via Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Queue-Id: 57D323F960 X-Migadu-Scanner: mx13.migadu.com X-Migadu-Spam-Score: -5.36 X-Spam-Score: -5.36 X-TUID: MHMVGY7fzZbu Hello, gemmaro writes: > * gnu/packages/emacs-xyz.scm (emacs-ddskk)[arguments]: Use newer > package style. Thanks. Some comments follow. > + (list #:modules '((guix build gnu-build-system) > + (guix build utils) > + (guix build emacs-utils)) > + #:imported-modules `(,@%gnu-build-system-modules > + (guix build emacs-utils)) > + #:test-target "test" > + #:phases > + #~(modify-phases %standard-phases > + (replace 'configure > + (lambda* (#:key outputs #:allow-other-keys) Use (lambda _ ...) here. > + (make-file-writable "SKK-MK") I don't think this line is necessary. Could you double-check? > + (emacs-substitute-variables "SKK-MK" > + ("PREFIX" (assoc-ref outputs "out")) (assoc-ref outputs "out") -> #$output > + ("LISPDIR" '(expand-file-name "/share/emacs/site-lisp" PREFIX)) > + ("SKK_PREFIX" "") > + ("SKK_INFODIR" '(expand-file-name "info" PREFIX))) > + (for-each make-file-writable (find-files "./doc")) > + #t)) Could you remove this trailing #T, too? Regards, -- Nicolas Goaziou