From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id CAiOG3DskGZYOgAA62LTzQ:P1 (envelope-from ) for ; Fri, 12 Jul 2024 08:42:24 +0000 Received: from aspmx1.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1.migadu.com with LMTPS id CAiOG3DskGZYOgAA62LTzQ (envelope-from ) for ; Fri, 12 Jul 2024 10:42:24 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=inria.fr header.s=dc header.b=NdvnZMVX; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=inria.fr (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1720773744; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=WgcyIroe3fKKnCMmFitlhPg8EbYiTO4WTQgUp6ZtsAY=; b=fy9t0wu2dIZok8rTyRCuZEI1iXXa7vZsC398nLEER1xLs1xQxGdea2GVZRfZEFiquOZJcm lFdkBgueGUzoACN5ZZ17ScZaplWl6NZipdnR3EWS53S0yAXIBY0jBns9jfTECbY5mQBBz6 v/LrvDdNW4PJTxlOtiVCxxztxqzkhGreYVZ6vp2y1ALJPBdKwJf8qdvCaoAg1LPYDGYN65 pSHomJBojqUL0t0pvsVpEVN/Sp6EAiobA/j8C5/KVXGg842RFi4bSR95bCk3iZvoqhML40 jkl4jDMTtIWxOmXGsl7aWizqmmOwdxXuObpbJeGEEPFvg01kNqz3Fxvx4CL7Nw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=inria.fr header.s=dc header.b=NdvnZMVX; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=inria.fr (policy=none) ARC-Seal: i=1; s=key1; d=yhetil.org; t=1720773744; a=rsa-sha256; cv=none; b=epHgyyJQVFGdphUlgJ3n0SkKJUHf8W6COjIsNcZdOWLrfdIcQoDjvVluUkp9t2eQNKofAY hGcSL3SdhF5F1PJ9KQrgE+heZB/nkByNBYZM/1D8gRSJkPctBQVgxlLbdow507lrHxpsMV y5S6Ya5urVw3Eda6/5K1b+nv4eDEPpfFC4Cx7Si9FywA8DvOBdu7Y6PH0Ja2tZgfObNWoH QSUH7zIz8pHFnR8SpXTOTiK7xJsaeoku+LP65XzCYxhEmsTRxEr8M6o+7huUpr/7PyVHDi AJWPd1DBd3SUFgHAL3PKp744IuJLBEIsrrED2LDlsHQ4vW1IX2Zn6xhxy/OjLw== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 14B537C7DE for ; Fri, 12 Jul 2024 10:42:24 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sSBqu-0002Sh-Ov; Fri, 12 Jul 2024 04:42:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sSBqt-0002HO-0V for guix-patches@gnu.org; Fri, 12 Jul 2024 04:42:03 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sSBqr-0000yz-HH for guix-patches@gnu.org; Fri, 12 Jul 2024 04:42:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sSBqr-0004k7-Jp for guix-patches@gnu.org; Fri, 12 Jul 2024 04:42:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#72062] [PATCH 3/4] gnu: Add openmpi-5. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 12 Jul 2024 08:42:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 72062 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Romain GARBAGE Cc: 72062@debbugs.gnu.org Received: via spool by 72062-submit@debbugs.gnu.org id=B72062.172077366318146 (code B ref 72062); Fri, 12 Jul 2024 08:42:01 +0000 Received: (at 72062) by debbugs.gnu.org; 12 Jul 2024 08:41:03 +0000 Received: from localhost ([127.0.0.1]:53158 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sSBpu-0004iW-DL for submit@debbugs.gnu.org; Fri, 12 Jul 2024 04:41:02 -0400 Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]:11310) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sSBps-0004hx-IS for 72062@debbugs.gnu.org; Fri, 12 Jul 2024 04:41:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=inria.fr; s=dc; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version:content-transfer-encoding; bh=WgcyIroe3fKKnCMmFitlhPg8EbYiTO4WTQgUp6ZtsAY=; b=NdvnZMVX9yxcKQgIXz/9fmPvTbdB33b2M9fqZXi7wLSopRCDdN18nnKs H+hKxb/jg7fv3wwlimNaED3XWFL/m84OySvmi/RnlRyeG4xWLSwp8siCV FHn1PHGSVI7AQsfTEghe89/S4rI70gbOI+Mc/On6AonIKenHHq+RbwK7t 0=; X-IronPort-AV: E=Sophos;i="6.09,202,1716242400"; d="scan'208";a="92013927" Received: from 91-160-117-201.subs.proxad.net (HELO ribbon) ([91.160.117.201]) by mail3-relais-sop.national.inria.fr with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Jul 2024 10:40:53 +0200 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= In-Reply-To: <20240711143540.25601-3-romain.garbage@inria.fr> (Romain GARBAGE's message of "Thu, 11 Jul 2024 16:35:24 +0200") References: <20240711143540.25601-1-romain.garbage@inria.fr> <20240711143540.25601-3-romain.garbage@inria.fr> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: Quintidi 25 Messidor an 232 de la =?UTF-8?Q?R=C3=A9volution, ?= jour de la Pintade X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Fri, 12 Jul 2024 10:40:53 +0200 Message-ID: <87r0bzypd6.fsf@inria.fr> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Spam-Score: 2.60 X-Migadu-Queue-Id: 14B537C7DE X-Migadu-Scanner: mx10.migadu.com X-Migadu-Spam-Score: 2.60 X-TUID: /MzbqR9fr8u6 Hello! Romain GARBAGE skribis: > * gnu/packages/mpi.scm (openmpi-5): New variable. > > Change-Id: I048692b2e928077c9cfa9fb8076ceb356251e1db [...] > +(define-public openmpi-5 > + (package/inherit openmpi I think it=E2=80=99s a case where (package (inherit openmpi) =E2=80=A6) is = more appropriate: =E2=80=98package/inherit=E2=80=99 would cause the =E2=80=98rep= lacement=E2=80=99 of =E2=80=98openmpi=E2=80=99 to be inherited, which is probably not a good ide= a since it=E2=80=99s a different version. > + (substitute-keyword-arguments (package-arguments openmpi) > + ((#:configure-flags flags) > + #~(append (list "--enable-prte-prefix-by-default" ;replaces --en= able-mpirun-prefix-by-default > + ;; Enable support for the 'Process Management > + ;; Interface for Exascale' (PMIx) used e.g. by > + ;; Slurm for the management communication and > + ;; coordination of MPI processes. > + (string-append "--with-pmix=3D" #$(this-package-= input "openpmix")) > + (string-append "--with-prrte=3D" #$(this-package= -input "prrte")) > + > + ;; Since 5.x, Infiniband support is provided by = ucx. > + (string-append "--with-ucx=3D" #$(this-package-i= nput "ucx"))) > + (filter (lambda (e) > + (and (not (string-contains e "pmi")) ;; Sinc= e 5.x, OpenMPI doesn't support PMI/PMI-2 > + ;; Deprecated since 5.x. > + (not (string-contains e "enable-mpirun-= prefix-by-default")) > + ;; Infiniband support is deprecated and= superseded by ucx > + ;; See https://docs.open-mpi.org/en/mai= n/release-notes/networks.html#miscellaneous-network-notes > + (not (string-contains e "openib")))) > + #$flags))) How about listing all the configure flags explicitly rather than relative to those of 4.x? I feel like this would be clearer and that there=E2=80=99s little to be gained by factorizing anyway. Thanks, Ludo=E2=80=99.