From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id uM8aEhwrKmcsGgAAqHPOHw:P1 (envelope-from ) for ; Tue, 05 Nov 2024 14:26:36 +0000 Received: from aspmx1.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0.migadu.com with LMTPS id uM8aEhwrKmcsGgAAqHPOHw (envelope-from ) for ; Tue, 05 Nov 2024 15:26:36 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=tplQRvsW; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=PPY+uOb3; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1730816796; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=EOW0tJo5s0iKaOHB+q7KOdqjmoeLcKHOVwB5UoUXmpw=; b=RF/VOzyOP8P/VB7qVw4RAzcgOKBjujn8rYOcWvKTeWz2VSJZYxYEbLgcKaA3Y5FfNifcb1 FsyBhtHM3QLi5T9M9/bbaFfDvEL9EHvSxlCOfupHtNUV0mHAVaOGBABz9s2ymrPpKvu73Z pIhzv8UfE1D5DNDzT4vS8gPNau44FMIIAJHTAvR/pMqe+ohEQwCkELferGmArI53K+diT+ gy3UP3WVlgzcpKTW1m3wJs5YCORhN0WBv2Rv16GN0FxLtUBXmvTDn/FToJJr5lQWXUmDYh Z/d7aB4EdrTWHvqx/2xaWvRmpyka09KvJyFeFV12qC62WfXTmd4Izz5FA7uqXw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1730816796; a=rsa-sha256; cv=none; b=FwAyZSud0exZzooR4zrmAR4wlnTYV+5eFPCN+7IDknLYeiNVJCePe3egp8B3UMNFz2ZYDP Wdp6mgt9TjRnuiYEGmSlNUnUcEZH4A1eWDrTKr/vAWtsvfmNlLQmgHVgK+toetrcXeOw5q +gOBZu7wZegDnewExvnkRbKZMnOX70JrHpg1y/T33XRCLuojvnyAuMeNWymbDDK3L8gQ2x 0JcmfIUc/BQAfonmj5/nSAQfXeTBfQOb0/yIeePvY3NeZt3hwZrSd2zwCvjBA9GSaKPOWD SJmmCLm5jxTzdLSTOt5ZS7weqgcuBVe32/DSKwzp/QeRIK3UdTN2XGvSyIkyaw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=tplQRvsW; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=PPY+uOb3; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 043F35AD52 for ; Tue, 05 Nov 2024 15:26:36 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1t8KVc-0008P7-Ie; Tue, 05 Nov 2024 09:26:16 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t8KVR-0008Kg-Ji for guix-patches@gnu.org; Tue, 05 Nov 2024 09:26:07 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1t8KVP-0005Qy-45 for guix-patches@gnu.org; Tue, 05 Nov 2024 09:26:05 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=EOW0tJo5s0iKaOHB+q7KOdqjmoeLcKHOVwB5UoUXmpw=; b=tplQRvsWNkNdLp4nEBsoq4lrrLEYxW84KgwQBhRncAsfzbI4t/XJ/jqSkWyKPGZ6qMmiG0svGIXizhHYDuMqnhuLyYTjjcYNEa9pn6vWmPdlIZ3nlr+FRaRZYiuTkRKXjw/AAAhnso5fcJwBncTT2zVcJzqLMZtn2IT/EwuXoKRfjtS34pSF63oYvIEjLuJ1PFId+t2FCD2Yy/CipQVa2T7/vVcxYzEELYdijB3+FiEhfg9Sc06UPihI8KGtWutGP+0ATfULUJGSaaWxoaMuRsMuhtZPJqqCD2I7a+8aamBi6V4/ac4G88ammSC8Ro45lY+ocxBb42F5f0oqGePFTQ==; Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1t8KVO-0000x0-1i for guix-patches@gnu.org; Tue, 05 Nov 2024 09:26:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#73842] [PATCH v4 1/3] gnu: appimage: New packages for the appimage runtime. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 05 Nov 2024 14:26:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73842 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: =?UTF-8?Q?No=C3=A9?= Lopez Cc: =?UTF-8?Q?No=C3=A9?= Lopez , 73842@debbugs.gnu.org, pelzflorian , Maxim Cournoyer Received: via spool by 73842-submit@debbugs.gnu.org id=B73842.17308167173638 (code B ref 73842); Tue, 05 Nov 2024 14:26:01 +0000 Received: (at 73842) by debbugs.gnu.org; 5 Nov 2024 14:25:17 +0000 Received: from localhost ([127.0.0.1]:43976 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t8KUe-0000uj-C6 for submit@debbugs.gnu.org; Tue, 05 Nov 2024 09:25:16 -0500 Received: from eggs.gnu.org ([209.51.188.92]:54188) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t8KUa-0000kj-1r for 73842@debbugs.gnu.org; Tue, 05 Nov 2024 09:25:14 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t8KSL-0004rU-73; Tue, 05 Nov 2024 09:22:53 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=EOW0tJo5s0iKaOHB+q7KOdqjmoeLcKHOVwB5UoUXmpw=; b=PPY+uOb3HtQ/p4u6JT0R GKRRJY7znAwhwyynEl5nxDOXfqBJlgC3R7ge95oLqhFQ7n+OLZWf5SGajCa814PzW8mTkoTbSdd3z IO/nHX1cHJ6zJ9HZA67aFxyzF6n+shFDmZOLVyiC3LJIbTVFFmS/2YxHN9tmyy2RlJ9xXhssgCo/Q rhnGVbkLsEK8nnCpdNw/JIEP9eGmefKgL5Qsi9fEJlLJ9rJivw9Qq3p5rvnB2AauxoZqoUPIRBfn+ 7c/7Z4gPcItbftvYN+mheLGxCTfg3pyJceZXzAMi12S1F3mGlVMCpV2kS3h6MZbplAAORRBNvnt0W vDSMioENY5u0Gw==; From: Ludovic =?UTF-8?Q?Court=C3=A8s?= In-Reply-To: ("=?UTF-8?Q?No=C3=A9?= Lopez"'s message of "Sun, 3 Nov 2024 23:37:19 +0100") References: Date: Tue, 05 Nov 2024 15:22:50 +0100 Message-ID: <87r07pyd39.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -1.87 X-Spam-Score: -1.87 X-Migadu-Queue-Id: 043F35AD52 X-Migadu-Scanner: mx13.migadu.com X-TUID: 5M8fGIeSgzWu Hi! No=C3=A9 Lopez skribis: > From: No=C3=A9 Lopez > > * gnu/packages/appimage.scm > (gnu packages appimage): New module. > (fuse-for-appimage, squashfuse-for-appimage) > (appimage-type2-runtime): New variables. > > Change-Id: I857a8eb5399a6a493e52db70b6c8cf0c71360930 > --- > gnu/packages/appimage.scm | 126 ++++++++++++++++++++++++++++++++++++++ Please add this file to =E2=80=98gnu/local.mk=E2=80=99. > +(define fuse-for-appimage > + (package > + (inherit fuse) Due to restrictions having to do with circular module dependencies, this package must be defined in the same file as =E2=80=98fuse=E2=80=99 itself (= apologies for overlooking it!). You could add the =E2=80=98hidden?=E2=80=99 property if = needed, but IMO it perhaps not even necessary to hide it. > +(define squashfuse-for-appimage > + (package > + (inherit squashfuse) Likewise, this should be in the same file as =E2=80=98squashfuse=E2=80=99. > + (arguments > + (list > + #:make-flags > + #~(list "-Csrc/runtime" "runtime-fuse3" > + (string-append "CFLAGS=3D" "-I" #$fuse-2 "/include/fuse/" Rather: #$(this-package-input "fuse"). > + " -DGIT_COMMIT=3D'\"" "guix-" #$version "= \"'" > + " -D_FILE_OFFSET_BITS=3D64" > + " -static")) You may need to add =E2=80=9C-O2 -g=E2=80=9D here, or the code might be com= piled as with =E2=80=9C-O0 -g0=E2=80=9D. > + ;; Must be after all elf reliant phases. > + (add-after 'make-dynamic-linker-cache 'set-magic-by= tes > + (lambda _ > + (let ((port (open (string-append #$output > + "/bin/runtime-fuse3") > + (logior O_WRONLY)))) > + (seek port 8 SEEK_SET) > + (put-bytevector port #vu8(#x41 #x49 #x02)) > + (close-port port))))) What=E2=80=99s the story with magic bytes here? :-) Could you add a comment explaining what the phase does and why it=E2=80=99s necessary? > + #:disallowed-references (list squashfuse-for-appimage > + fuse-for-appimage zstd zlib))) > + ;; Only needed at build time. > + (inputs (list squashfuse-for-appimage fuse-for-appimage > + `(,zstd "static") > + `(,zlib "static"))) It should probably be =E2=80=98native-inputs=E2=80=99, then. Also, in #:disallowed-references, I think you need: `(,zstd "static") `(,zlib "static") > + (synopsis "Runtime for executing AppImages") > + (description "The runtime is the executable part of every AppImage= , it > +mounts the payload via FUSE and executes the entrypoint.") Please make that a full sentence, as per .