From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id SMiUGaqWX2f6HQAA62LTzQ:P1 (envelope-from ) for ; Mon, 16 Dec 2024 02:55:38 +0000 Received: from aspmx1.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1.migadu.com with LMTPS id SMiUGaqWX2f6HQAA62LTzQ (envelope-from ) for ; Mon, 16 Dec 2024 03:55:38 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=jdeJsyQH; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=WhZli1HG; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1734317738; a=rsa-sha256; cv=none; b=ryD553fHgYrB7cZvRmsF4ZjLolS0h8va/60Gu7AhSv9JRjp6nTAghyRyJjs6OKKpz3lUAO dSIX6tCMX+ZVtpzhyztxW9qf1ApjbAGz+pwdHchjyvckLL2pjy1Gw5f4FKn2N1DINqH5gW z/5wYlg1zUUwmt+wXj1l71ALHJ/HS0KIUgV0rjwO62MHuO7xXbxwPys2omzJAj4HS60mC5 i7AqfLJSe+bH30i4GVszase/SgMsAd4L9d7hwjToyjEeDDZZ/MUYmsiMuxODwljaJLSGBf IDRKrjl0OSV8Kzf6YihWjcV65wbm9C6Ayuge3OP0aYhtLjmwOhgnhJ4bKyXTzg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=jdeJsyQH; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=WhZli1HG; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1734317738; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=3umyfD08AjsnAfpXt8m7rZ5rm6+obJwjH73SOP3O1po=; b=FWUkJhD2hbTbw+eAm4YzbRc12o/J6ffOQ8QegbfRTQmKpU/M1cO7l0jF0pq3mSrQO7ck2I TlZBZuGOpD6jFjcKrK6/1uyI2RFJGRHgyRudTH0szpzyysaD73B05IG0f8/uIiJezqBBpn 6ABRbUqi/ExtLnWhJVH6MaWhKGSqSllClLD50VV0RiuRVKickapgxnXHayty1LBVAdjuzp gkmQtvfQGCU2s6Q808vYOewbqvaVm7t4IkrrL/tXr8/3wLFzAAnuBp5oOYy3IG6s/UkLJS N484UuCBoAJcybRlq1RygFnXCU4CLncYaRhDVuUBvhhbGsfWaxzlWKM9pdHn8g== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 1972D8F633 for ; Mon, 16 Dec 2024 03:55:37 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tN1GD-0006X9-HP; Sun, 15 Dec 2024 21:55:05 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tN1GB-0006Wp-GP for bug-guix@gnu.org; Sun, 15 Dec 2024 21:55:04 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tN1GB-0007mv-5t for bug-guix@gnu.org; Sun, 15 Dec 2024 21:55:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=3umyfD08AjsnAfpXt8m7rZ5rm6+obJwjH73SOP3O1po=; b=jdeJsyQHUtRzaqSG9T8Xfbl5o0zxkmdLxyPNKv+1brlXiMz3bsPIExt+3DGhOYn8gNUYo8y6hSE7FO0z2pGMJrUgFk1M5Hr7HQf3qNkxnST/cHFYdjQWKWL2octCGnnxDQPtCZbDqoXHodF7Zie5T0RXmObxwzpPWpP1WTW68rQL9OmdYyFa6JTdzzRbbvRkjgT+/iVAzJYKEZXnYqRC6kJQZQuSOUEDN8fhIdHQ42PRudpHr+faZG3L+MykFVhiWdJ0b0B4Ue2BNGwQ/Lr7IxxYE4WezRLtErF8efg5jYlkXsDNih/0idOleE/uF7rKfLvvUYsRtfT/ZCIXm4ixPQ==; Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tN1GA-0003BO-Ho for bug-guix@gnu.org; Sun, 15 Dec 2024 21:55:02 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#67241: [PATCH] guix-install.sh: Add message about Info reader. Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Mon, 16 Dec 2024 02:55:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 67241 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Simon Tournier Cc: 67241@debbugs.gnu.org Received: via spool by 67241-submit@debbugs.gnu.org id=B67241.173431767612188 (code B ref 67241); Mon, 16 Dec 2024 02:55:02 +0000 Received: (at 67241) by debbugs.gnu.org; 16 Dec 2024 02:54:36 +0000 Received: from localhost ([127.0.0.1]:52890 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tN1Fj-0003AV-Ct for submit@debbugs.gnu.org; Sun, 15 Dec 2024 21:54:35 -0500 Received: from mail-pl1-f169.google.com ([209.85.214.169]:49474) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tN1Ff-0003AL-8I for 67241@debbugs.gnu.org; Sun, 15 Dec 2024 21:54:32 -0500 Received: by mail-pl1-f169.google.com with SMTP id d9443c01a7336-2166f1e589cso36977115ad.3 for <67241@debbugs.gnu.org>; Sun, 15 Dec 2024 18:54:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1734317610; x=1734922410; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=3umyfD08AjsnAfpXt8m7rZ5rm6+obJwjH73SOP3O1po=; b=WhZli1HGYv3DdoL2On0E4YFmupaDj3SJnoqrE50gP1UAEXyRzUacwgjyzK0gE6oXgv nhT9KPqXh4XpYNypUEXeztiDgpObJkwVTEmtRE1Udypm5xdal8APL910ojzQrgKq0GM1 Wcwim4oDrmVhcB9g1hhatQHddFVwFTIDTYdcAHWHig135ZIvEHtzC2xLvdSfTDqyateZ bM7xfqCoudaIVx9P14mc+SNxH6MxxLyn8yPOShHr5wZeqjrWpOuWFIyt762SJAJ1prUR gvhXELalltbjPX/o4Ncs2Gm8qKccVk10Krqopa0HrpmQ2T1ipX6zjaxpWoBKIZdiR+Nn e3cw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734317610; x=1734922410; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=3umyfD08AjsnAfpXt8m7rZ5rm6+obJwjH73SOP3O1po=; b=kYzw9z47RdtsdrDFUgtr/2HWbLq1fuqdPClzAhtovCDY0+ZeUCc0m2VdZ+vGnJk9UC cURGVBpyIJ9h/iU8IQf9Vg8irApMATj8CAPuwBi/pUc+gRvpEKcjJhOc91OJTffvOrn/ FDO9zxdpDYYBCZN6tqvhCwSV+5OzC36FvbvmLfw5zEJ6ScBXdGqIbln6z2fcZ5WOlvtY FJCikR4m7FuJEGuyVL6KcaElW8iULRmak45TM0fcslJCSa0g+gU8xm4lhmTubAKeAVxp +lzBuQpNJYJZub/eu1YKcQ4mUudx+az9LZXBZAUez5HkBBQ/7f+/Q6T9okDve5wB+dBl xGGw== X-Gm-Message-State: AOJu0YyDGjJTSwEOeJ5VLbaAOX97jzXiio2HaCz+YyuWba3MDasToAEw rGxTSapc0EZrCJTH3yuqSCxzVBKu1FBJ9JSRqpX9b03w7ZxlvuA+6XcZRCzN X-Gm-Gg: ASbGncug6FcuH/B1YmFFliG5a5uLWwOM2T95hn/m+IWiBPecG3hfOcoPoBhAMCsoMqV 9CGT2CE7x/2tIwNMzyiLdV31DyD10ooLiJYg9JoRzq62oJYi48pzk0uNSkwQPnltwT3p8bhE+fx aUS7YHQLgBMYIzqtjDJe9u0nzfTRyQr/wXeer098nMA9xEcOy2NxM8h7zEXiU4tLHz2wgQiGjKC yBDWwQvnbQRls/svnXT3JfdMoiBpEa/JemWuxlrg5QT1MLKhpvj7Q== X-Google-Smtp-Source: AGHT+IFK7fStAPczwHlA6yCdTHGEWfNfhVKkNEHzP+7Oko2ly14DB1rtE62c8uxDLUdgFFObIQt2tg== X-Received: by 2002:a17:903:944:b0:216:3dc0:c8ab with SMTP id d9443c01a7336-218929f1d64mr159992485ad.9.1734317609607; Sun, 15 Dec 2024 18:53:29 -0800 (PST) Received: from terra ([2405:6586:be0:0:c8ff:1707:9b9:af89]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-218a1e5cf5asm32789185ad.178.2024.12.15.18.53.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 15 Dec 2024 18:53:29 -0800 (PST) From: Maxim Cournoyer In-Reply-To: (Simon Tournier's message of "Sat, 16 Nov 2024 08:54:07 +0100") References: <87h68d6k4e.fsf@gmail.com> Date: Mon, 16 Dec 2024 11:53:18 +0900 Message-ID: <87r068uyn5.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: bug-guix-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -4.84 X-Spam-Score: -4.84 X-Migadu-Queue-Id: 1972D8F633 X-Migadu-Scanner: mx12.migadu.com X-TUID: aIc+FWUNjD6R Hi Simon, Simon Tournier writes: > * etc/guix-install.sh (_info): New procedure. > (_chk_sys_nscd, main_install): Use it. > > Change-Id: I2cad8bc2554cd4ea88f30c8a104b7c62f2aa2e0e > --- > etc/guix-install.sh | 18 ++++++++++++++---- > 1 file changed, 14 insertions(+), 4 deletions(-) > > diff --git a/etc/guix-install.sh b/etc/guix-install.sh > index f07b2741bb..08e25de238 100755 > --- a/etc/guix-install.sh > +++ b/etc/guix-install.sh > @@ -5,7 +5,7 @@ > # Copyright =C2=A9 2018 Efraim Flashner > # Copyright =C2=A9 2019=E2=80=932020, 2022 Tobias Geerinckx-Rice > # Copyright =C2=A9 2020 Morgan Smith > -# Copyright =C2=A9 2020 Simon Tournier > +# Copyright =C2=A9 2020, 2024 Simon Tournier > # Copyright =C2=A9 2020 Daniel Brooks > # Copyright =C2=A9 2021 Jakub K=C4=85dzio=C5=82ka > # Copyright =C2=A9 2021 Chris Marusich > @@ -129,6 +129,16 @@ die() > exit 1 > } >=20=20 > +_info() > +{ > + if [ "$(type -P info)" ]; then > + _msg "$1" > + else > + _msg "${WAR}Please install Info reader; see package 'info-reader= '" > + _msg "$1" > + fi > +} It seems odd to me to "overload" _msg into _info that deals with some side effect; I'd rather see this conditional explicit at the message printing site. Also, your test is testing for the empty string when info is not found, not the exist status, which is wrong. I think you meant something like: --8<---------------cut here---------------start------------->8--- if type -P info >/dev/null then [...]; fi --8<---------------cut here---------------end--------------->8--- But this got me curious again... could we instead automate the installation of info post-installation? If yes, we should also automate the installation of glibc-locales, using prompts that the user can accept or decline like for the other configuration choices. That'd be more useful than asking the user to manually install things itself. --=20 Thanks, Maxim