From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <guix-patches-bounces+larch=yhetil.org@gnu.org>
Received: from mp1.migadu.com ([2001:41d0:403:58f0::])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))
	by ms13.migadu.com with LMTPS
	id aDssJn+veWeY5wAA62LTzQ:P1
	(envelope-from <guix-patches-bounces+larch=yhetil.org@gnu.org>)
	for <larch@yhetil.org>; Sat, 04 Jan 2025 22:00:31 +0000
Received: from aspmx1.migadu.com ([2001:41d0:403:58f0::])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))
	by mp1.migadu.com with LMTPS
	id aDssJn+veWeY5wAA62LTzQ
	(envelope-from <guix-patches-bounces+larch=yhetil.org@gnu.org>)
	for <larch@yhetil.org>; Sat, 04 Jan 2025 23:00:31 +0100
X-Envelope-To: larch@yhetil.org
Authentication-Results: aspmx1.migadu.com;
	dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=chUaWxLv;
	dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=JSkH9qfN;
	spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org";
	dmarc=pass (policy=none) header.from=gnu.org
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org;
	s=key1; t=1736028031;
	h=from:from:sender:sender:reply-to:subject:subject:date:date:
	 message-id:message-id:to:to:cc:cc:mime-version:mime-version:
	 content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:resent-cc:
	 resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to:
	 references:references:list-id:list-help:list-unsubscribe:
	 list-subscribe:list-post:dkim-signature;
	bh=kqRQAPnTcQqMSiRgNtuz4ACD6Ld5rDn5EB+Z2vhqrKo=;
	b=WcPa9Ekg8gUJQ8+dsKGfMO8DyXz0fttwl82aKg2UVKykUQgm9vNLKAbOUN4A4ChtdD8cn+
	Z/c6mxzLqncoowaHHknPIEOxLA9Xe5IfwBmQwCTT70IHFcEe6H9UGu2InRE/JoJW03Cnno
	V0lm6SVP+yyQusP4FuwtdtOvN25wyfX4l2tbvIuqHD4iygKm0WrGyiMx8lmtUiiMY5XAl3
	LG//LtqOgC8kVjA2OTl70aGSMV0S90PfMDXQC7j83abMzeAG17auDh8HYot7RlLmFKQF4r
	iOF4fNNDiqmRNBN8t9AK2xU44BPz4yhOJv1H+/xn6IEC7OE8q5EN/HQeLRxpnQ==
ARC-Authentication-Results: i=1;
	aspmx1.migadu.com;
	dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=chUaWxLv;
	dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=JSkH9qfN;
	spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org";
	dmarc=pass (policy=none) header.from=gnu.org
ARC-Seal: i=1; s=key1; d=yhetil.org; t=1736028031; a=rsa-sha256; cv=none;
	b=R5+x9r3Rca5FHzgXmn6VIvLIctvHHpY0oVkgNSn9dSs0rsvgC5ioumpbkBYifIq8Uc7ATG
	K2VvFahd63Ik6HW6jEmMoqu2I4fjmY1P2gwFUKASH67wAE7/lhZvGGRpucBZN0+MWv6mrO
	uimBHpmQWeslWCjnQnXuV2k3czw27nq9G4zeA1vym5LhEKSNFssNn5D9zUf7XBklwsAr8W
	tJT6N/2VO8+ZCUgU7PtA8gosQ/Od/e6qoLpYOXSFgTTdm4lGQYk4Te5Qhu6bcHqrARJw60
	Exhs08CUhQhro/zZUwCQIQ2n7KAyCU8ZuDtL+XbZcx3NEikVnvMY6IueCr8azQ==
Received: from lists.gnu.org (lists.gnu.org [209.51.188.17])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by aspmx1.migadu.com (Postfix) with ESMTPS id 2A53F83138
	for <larch@yhetil.org>; Sat, 04 Jan 2025 23:00:31 +0100 (CET)
Received: from localhost ([::1] helo=lists1p.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.90_1)
	(envelope-from <guix-patches-bounces@gnu.org>)
	id 1tUCBr-0000pz-1f; Sat, 04 Jan 2025 17:00:15 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10])
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1tUCBh-0000pb-An
 for guix-patches@gnu.org; Sat, 04 Jan 2025 17:00:06 -0500
Received: from debbugs.gnu.org ([2001:470:142:5::43])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.90_1) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1tUCBe-0008Ha-Pn
 for guix-patches@gnu.org; Sat, 04 Jan 2025 17:00:04 -0500
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
 d=debbugs.gnu.org; s=debbugs-gnu-org; 
 h=MIME-Version:Date:References:In-Reply-To:From:To:Subject;
 bh=kqRQAPnTcQqMSiRgNtuz4ACD6Ld5rDn5EB+Z2vhqrKo=; 
 b=chUaWxLv387+l08umoK5wUlA2YvtjOZcDahkdikpJIZFoktpa1IfXKOliTwYPLTfBJd+Ih1n9koywLh+Ys+PQj7xVg+Qn5PrG7a2/VviP4/HnCjst0st9ooIKMHGSsgV34+OIBRIYg0+Ntd99WP+S9jhEch5H1dJ6tm3r6MwYUiT9jzmoTzNGt116UG9r5/+4OTMi5Wm3zmacGsNQxI8khncgRy8Co7exTjLAR5WvJ0YPD9jxYaeFeCeL/Ws1R8Teg41oFjNNTg26Wy9gKMkEqhfvrfbDNhJ/pOpBitojoJyD51LIBKb5h3LNyv5wdj1JPxWgjab6jh13UGNXbF9zw==;
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1tUCBe-0007Ir-0F
 for guix-patches@gnu.org; Sat, 04 Jan 2025 17:00:02 -0500
X-Loop: help-debbugs@gnu.org
Subject: [bug#74734] [PATCH v3] gnu: Add inferno.
Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-CC: guix-patches@gnu.org
Resent-Date: Sat, 04 Jan 2025 22:00:01 +0000
Resent-Message-ID: <handler.74734.B74734.173602796928001@debbugs.gnu.org>
Resent-Sender: help-debbugs@gnu.org
X-GNU-PR-Message: followup 74734
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: Homo <gay@disroot.org>
Cc: 74734@debbugs.gnu.org
Received: via spool by 74734-submit@debbugs.gnu.org id=B74734.173602796928001
 (code B ref 74734); Sat, 04 Jan 2025 22:00:01 +0000
Received: (at 74734) by debbugs.gnu.org; 4 Jan 2025 21:59:29 +0000
Received: from localhost ([127.0.0.1]:57761 helo=debbugs.gnu.org)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <debbugs-submit-bounces@debbugs.gnu.org>)
 id 1tUCB6-0007HZ-QQ
 for submit@debbugs.gnu.org; Sat, 04 Jan 2025 16:59:29 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10]:48402)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.84_2) (envelope-from <ludo@gnu.org>) id 1tUCB4-0007HK-Iu
 for 74734@debbugs.gnu.org; Sat, 04 Jan 2025 16:59:27 -0500
Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <ludo@gnu.org>)
 id 1tUCAz-0008EL-1i; Sat, 04 Jan 2025 16:59:21 -0500
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To:
 From; bh=kqRQAPnTcQqMSiRgNtuz4ACD6Ld5rDn5EB+Z2vhqrKo=; b=JSkH9qfN7ldcLjnHs+lX
 YiHeS1hsICZkLUMAA39dY1QlTl8kHqDeToBNbQ9kWfxLe3M6lTVsuRpVjgqL4ie57UFmGbxU/Mpz6
 jg6X9qwoRBV0e+NsuVWLfHkLoCv7pEu1O6WBn0zpuVapWHL8IYQBC+8p1OQbfeIaRmiMPLkHxvMPq
 vQ0iHgvsbBX+4NRki2Wugf3ArIM2kXslvlSNWqaY7mDVoYZCyv5qQ+ZcU8IvXZDgWPHnYoid/IHRK
 k9bUDCwHENZ5zSCpOkGs+kMGdSHn0z51rVBOeOx3t26SYrJoKY/COHY61plpBef7hEekay+AzIkGY
 0FMQenPpoSN4yg==;
From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>
In-Reply-To: <20241225212804.26266-1-gay@disroot.org> (Homo's message of "Wed, 
 25 Dec 2024 23:23:30 +0200")
References: <20241208002411.20796-1-gay@disroot.org>
 <20241225212804.26266-1-gay@disroot.org>
Date: Sat, 04 Jan 2025 22:59:17 +0100
Message-ID: <87r05insui.fsf@gnu.org>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-BeenThere: debbugs-submit@debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
X-BeenThere: guix-patches@gnu.org
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-patches>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org
Sender: guix-patches-bounces+larch=yhetil.org@gnu.org
X-Migadu-Flow: FLOW_IN
X-Migadu-Country: US
X-Migadu-Scanner: mx11.migadu.com
X-Migadu-Spam-Score: -7.60
X-Spam-Score: -7.60
X-Migadu-Queue-Id: 2A53F83138
X-TUID: 65tW+pJCYbiU

Hi,

Homo <gay@disroot.org> skribis:

> Based on earlier work rejected for licensing reasons, code has been relic=
ensed from LPL to Expat.
>
> Just in case remove all fonts from distribution, instead fonts from plan9=
port are used.
>
> * gnu/packages/inferno.scm: New file.
> * gnu/packages/patches/inferno-fix-crash.patch: New file.
> * gnu/local.mk (GNU_SYSTEM_MODULES, dist_patch_DATA): Register new files.
>
> Change-Id: Ie655f97fec5e249b8bbc92c66c5f13afabbc0552

[...]

> +(define-public inferno
> +  (let ((commit "67e70befb2ad0058fd7894be34c492ddb6d09988")
> +        (revision "0"))
> +    (package
> +      (name "inferno")
> +      (version (git-version "4" revision commit))

If there=E2=80=99s no release that can be used, please add a short comment
explaining why we=E2=80=99re picking a snapshot.

> +         ;; Remove bundled non-free and potentially non-free fonts.
> +         (snippet '(begin
> +                     (delete-file-recursively "fonts") #t))))

Just: (snippet '(delete-file-recursively "fonts")).

> +      (build-system gnu-build-system)
> +      (inputs (list libx11 libxext plan9port xorgproto))
> +      (arguments

Usually =E2=80=98arguments=E2=80=99 goes right after =E2=80=98build-system=
=E2=80=99.

> +       (list
> +        #:phases
> +        #~(let*
> +            ((bash (assoc-ref %build-inputs "bash"))
> +             (bindir (string-append #$output "/bin"))
> +             (emu-script (string-append bindir "/emu"))

This is quite unusual.  I would suggest instead moving these definitions
in the procedure where they=E2=80=99re used.

Also, prefer =E2=80=98search-input-file=E2=80=99 & co. instead of (assoc-ref
%build-inputs =E2=80=A6).

Otherwise LGTM.

Could you send an updated patch?

Thanks,
Ludo=E2=80=99.