From: "Ludovic Courtès" <ludo@gnu.org>
To: Homo <gay@disroot.org>
Cc: 74734@debbugs.gnu.org
Subject: [bug#74734] [PATCH v3] gnu: Add inferno.
Date: Sat, 04 Jan 2025 22:59:17 +0100 [thread overview]
Message-ID: <87r05insui.fsf@gnu.org> (raw)
In-Reply-To: <20241225212804.26266-1-gay@disroot.org> (Homo's message of "Wed, 25 Dec 2024 23:23:30 +0200")
Hi,
Homo <gay@disroot.org> skribis:
> Based on earlier work rejected for licensing reasons, code has been relicensed from LPL to Expat.
>
> Just in case remove all fonts from distribution, instead fonts from plan9port are used.
>
> * gnu/packages/inferno.scm: New file.
> * gnu/packages/patches/inferno-fix-crash.patch: New file.
> * gnu/local.mk (GNU_SYSTEM_MODULES, dist_patch_DATA): Register new files.
>
> Change-Id: Ie655f97fec5e249b8bbc92c66c5f13afabbc0552
[...]
> +(define-public inferno
> + (let ((commit "67e70befb2ad0058fd7894be34c492ddb6d09988")
> + (revision "0"))
> + (package
> + (name "inferno")
> + (version (git-version "4" revision commit))
If there’s no release that can be used, please add a short comment
explaining why we’re picking a snapshot.
> + ;; Remove bundled non-free and potentially non-free fonts.
> + (snippet '(begin
> + (delete-file-recursively "fonts") #t))))
Just: (snippet '(delete-file-recursively "fonts")).
> + (build-system gnu-build-system)
> + (inputs (list libx11 libxext plan9port xorgproto))
> + (arguments
Usually ‘arguments’ goes right after ‘build-system’.
> + (list
> + #:phases
> + #~(let*
> + ((bash (assoc-ref %build-inputs "bash"))
> + (bindir (string-append #$output "/bin"))
> + (emu-script (string-append bindir "/emu"))
This is quite unusual. I would suggest instead moving these definitions
in the procedure where they’re used.
Also, prefer ‘search-input-file’ & co. instead of (assoc-ref
%build-inputs …).
Otherwise LGTM.
Could you send an updated patch?
Thanks,
Ludo’.
next prev parent reply other threads:[~2025-01-04 22:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-08 0:24 [bug#74734] [PATCH] gnu: Add inferno Homo via Guix-patches via
2024-12-08 23:52 ` [bug#74734] [PATCH v2] " Homo via Guix-patches via
2024-12-25 21:23 ` [bug#74734] [PATCH v3] " Homo via Guix-patches via
2025-01-04 21:59 ` Ludovic Courtès [this message]
2025-01-06 9:33 ` gay--- via Guix-patches via
2025-01-06 17:32 ` [bug#74734] [PATCH v4] " Homo via Guix-patches via
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r05insui.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=74734@debbugs.gnu.org \
--cc=gay@disroot.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.