From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: guix-package --roll-back
Date: Thu, 03 Jan 2013 15:41:13 +0100
Message-ID: <87pq1m5nxy.fsf@gnu.org>
References: <871uejyq9z.fsf@karetnikov.org> <874nj4sbfe.fsf@karetnikov.org>
	<87y5gf8sm1.fsf@gnu.org> <87hamy4yaj.fsf@karetnikov.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([208.118.235.92]:48580)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1Tqlyu-0005Te-NU
	for bug-guix@gnu.org; Thu, 03 Jan 2013 09:41:17 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1Tqlyt-0002pk-6G
	for bug-guix@gnu.org; Thu, 03 Jan 2013 09:41:16 -0500
Received: from mail4-relais-sop.national.inria.fr ([192.134.164.105]:42650)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <ludo@gnu.org>)
	id 1Tqlyt-0002pg-0O
	for bug-guix@gnu.org; Thu, 03 Jan 2013 09:41:15 -0500
In-Reply-To: <87hamy4yaj.fsf@karetnikov.org> (Nikita Karetnikov's message of
	"Thu, 03 Jan 2013 00:43:03 -0500")
List-Id: Bug reports for GNU Guix <bug-guix.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-guix>
List-Post: <mailto:bug-guix@gnu.org>
List-Help: <mailto:bug-guix-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=subscribe>
Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org
Sender: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org
To: Nikita Karetnikov <nikita@karetnikov.org>
Cc: bug-guix@gnu.org

Hi,

Nikita Karetnikov <nikita@karetnikov.org> skribis:

>>> +(define (roll-back)
>>> +  "Roll back to the previous profile."
>
>> Please add a =E2=80=98profile=E2=80=99 parameter, as for the other funct=
ions.
>>
>> It should be possible to run:
>>=20
>>   $ guix-package -p foo --roll-back
>
> Should I add any profile-related sanity checks to 'roll-back'?

What kind of sanity check?

> Should 'roll-back' only work for 'guix-profile-*-link' and
> 'default-*-link'? If not, then we have a problem because 'profile-rx'
> can't handle something like '42-custom-profile'. Is it possible to
> create such a profile?

Yes, but I think the regexp handles it just fine, no?

Thanks,
Ludo=E2=80=99.