From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH] Inhibit duplicates in fold-packages
Date: Wed, 13 Feb 2013 22:35:37 +0100
Message-ID: <87pq03kic6.fsf@gnu.org>
References: <87d2w5q8wk.fsf@tines.lan>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([208.118.235.92]:36808)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1U5jzZ-0005ro-HA
	for bug-guix@gnu.org; Wed, 13 Feb 2013 16:35:50 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1U5jzX-0002yb-Ta
	for bug-guix@gnu.org; Wed, 13 Feb 2013 16:35:49 -0500
Received: from [2a01:e0b:1:123:ca0a:a9ff:fe03:271e] (port=47610
	helo=xanadu.aquilenet.fr) by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1U5jzX-0002u6-KV
	for bug-guix@gnu.org; Wed, 13 Feb 2013 16:35:47 -0500
In-Reply-To: <87d2w5q8wk.fsf@tines.lan> (Mark H. Weaver's message of "Tue, 12
	Feb 2013 20:50:35 -0500")
List-Id: Bug reports for GNU Guix <bug-guix.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-guix>
List-Post: <mailto:bug-guix@gnu.org>
List-Help: <mailto:bug-guix-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=subscribe>
Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org
Sender: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org
To: Mark H Weaver <mhw@netris.org>
Cc: bug-guix@gnu.org

Mark H Weaver <mhw@netris.org> skribis:

> Here's a patch to inhibit the same package (in the sense of eq?) from
> being traversed more than once by fold-packages.  One example where this
> helps is the guile-2.0 package in (gnu packages guile), which is
> exported in two different variables: guile-2.0 and guile-2.0/fixed.

Looks good to me; can you update the docstring to mention that each
package is traversed only once?  Then feel free to push.

BTW, I think =E2=80=98guile-2.0/fixed=E2=80=99 is the only case where this =
happens
actually, no?

BTW2, when doing non-trivial changes like this one, make sure to add a
copyright line under your name.

Thanks!

Ludo=E2=80=99.