From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH] gnu: Add ffmpeg.
Date: Mon, 02 Dec 2013 13:38:22 +0100
Message-ID: <87pppftold.fsf@gnu.org>
References: <20131031221901.GA21979@debian> <87mwln66dr.fsf@gnu.org>
	<20131102074708.GA18924@debian> <20131127225054.GA11343@debian>
	<20131130204426.GA4174@debian> <87mwkltrex.fsf@gnu.org>
	<20131201145129.GA6641@debian>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:37806)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1VnSli-0001Fg-GR
	for guix-devel@gnu.org; Mon, 02 Dec 2013 07:38:36 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1VnSlc-0007b8-AT
	for guix-devel@gnu.org; Mon, 02 Dec 2013 07:38:30 -0500
Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:48522)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <ludo@gnu.org>)
	id 1VnSlc-0007Z5-42
	for guix-devel@gnu.org; Mon, 02 Dec 2013 07:38:24 -0500
In-Reply-To: <20131201145129.GA6641@debian> (Andreas Enge's message of "Sun, 1
	Dec 2013 15:51:29 +0100")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Andreas Enge <andreas@enge.fr>
Cc: guix-devel@gnu.org

Andreas Enge <andreas@enge.fr> skribis:

> On Sun, Dec 01, 2013 at 12:12:54AM +0100, Ludovic Court=C3=A8s wrote:
>> The samples wouldn=E2=80=99t really have to be =E2=80=9Cpackaged=E2=80=
=9D: they=E2=80=99d just be an
>> input.  For someone using substitutes, the samples are not going to be a
>> problem (because they=E2=80=99ll never be downloaded.)  However, it is i=
ndeed a
>> problem when building things locally.
>
> Well, so far the only way I have been told to get them is via rsync.
> So one might need to create a .tar(.gz?) from the download.

Not necessarily.  It could fetch the directory as is.  There could be an
=E2=80=98rsync-fetch=E2=80=99 method for <origin>, just like we have =E2=80=
=98url-fetch=E2=80=99.  (A
little bit of work, but that seems doable, if we want to.)

> And in any case, an input means a package variable, no?

I would rather make it an <origin> (assuming there=E2=80=99s a way to get a=
t an
immutable version of those samples), and it doesn=E2=80=99t need to be boun=
d a
variable:

  (define ffmpeg
    (package
      ...
      (inputs `(("samples" ,(origin
                              (method rsync-fetch)
                              ...))))))

Back to the problem at hand: the short-term answer is to add
#:tests? #f with a link to this discussion.  The longer term answer
may be to try to run those FATE tests.

WDYT?

Ludo=E2=80=99.