Re: [PATCH] gnu: Add ffmpeg.

[ludo@gnu.org (Ludovic Courtès)]

Andreas Enge <andreas@enge.fr> skribis:

> On Sun, Dec 01, 2013 at 12:12:54AM +0100, Ludovic Courtès wrote:
>> The samples wouldn’t really have to be “packaged”: they’d just be an
>> input.  For someone using substitutes, the samples are not going to be a
>> problem (because they’ll never be downloaded.)  However, it is indeed a
>> problem when building things locally.
>
> Well, so far the only way I have been told to get them is via rsync.
> So one might need to create a .tar(.gz?) from the download.

Not necessarily.  It could fetch the directory as is.  There could be an
‘rsync-fetch’ method for <origin>, just like we have ‘url-fetch’.  (A
little bit of work, but that seems doable, if we want to.)

> And in any case, an input means a package variable, no?

I would rather make it an <origin> (assuming there’s a way to get at an
immutable version of those samples), and it doesn’t need to be bound a
variable:

  (define ffmpeg
    (package
      ...
      (inputs `(("samples" ,(origin
                              (method rsync-fetch)
                              ...))))))

Back to the problem at hand: the short-term answer is to add
#:tests? #f with a link to this discussion.  The longer term answer
may be to try to run those FATE tests.

WDYT?

Ludo’.