[PATCH 1/4] gnu: openmpi: Add memchecker support

[PATCH 1/4] gnu: openmpi: Add memchecker support

[Eric Bavier]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: 0001-gnu-openmpi-Add-memchecker-support.patch --]
[-- Type: text/x-diff, Size: 1781 bytes --]

From 3aaab98e3b9a0b1b893dd5bc64e098136364e717 Mon Sep 17 00:00:00 2001
From: Eric Bavier <bavier@member.fsf.org>
Date: Sat, 17 May 2014 00:02:44 -0500
Subject: [PATCH 1/4] gnu: openmpi: Add memchecker support

* gnu/packages/mpi.scm (openmpi) [inputs]: Add valgrind.
  [arguments]: Add configure flags for memchecker.
---
 gnu/packages/mpi.scm |    8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/mpi.scm b/gnu/packages/mpi.scm
index 37b7858..e525ed8 100644
--- a/gnu/packages/mpi.scm
+++ b/gnu/packages/mpi.scm
@@ -32,6 +32,7 @@
   #:use-module (gnu packages xml)
   #:use-module (gnu packages ncurses)
   #:use-module (gnu packages pkg-config)
+  #:use-module (gnu packages valgrind)
   #:use-module (srfi srfi-1))
 
 (define-public hwloc
@@ -99,7 +100,8 @@ bind processes, and much more.")
     (native-inputs
      `(("pkg-config" ,pkg-config)))
     (propagated-inputs
-     `(("gfortran" ,gfortran-4.8)))
+     `(("gfortran" ,gfortran-4.8)
+       ("valgrind" ,valgrind)))
     (arguments
      `(#:configure-flags `("--enable-static"
                            "--enable-oshmem"
@@ -110,6 +112,10 @@ bind processes, and much more.")
                            ;; "--enable-mpi-thread-multiple"
                            "--enable-mpi-ext=all"
                            "--with-devel-headers"
+                           "--enable-debug"
+                           "--enable-memchecker"
+                           ,(string-append "--with-valgrind="
+                                           (assoc-ref %build-inputs "valgrind"))
                            ,(string-append "--with-hwloc="
                                            (assoc-ref %build-inputs "hwloc")))))
     (home-page "http://www.open-mpi.org")
-- 
1.7.9.5


[-- Attachment #2: Type: text/plain, Size: 133 bytes --]


-- 
Eric Bavier

Please avoid sending me Word or PowerPoint attachments.
See http://www.gnu.org/philosophy/no-word-attachments.html

Re: [PATCH 1/4] gnu: openmpi: Add memchecker support

[Ludovic Courtès]

Eric Bavier <ericbavier@gmail.com> skribis:

> From 3aaab98e3b9a0b1b893dd5bc64e098136364e717 Mon Sep 17 00:00:00 2001
> From: Eric Bavier <bavier@member.fsf.org>
> Date: Sat, 17 May 2014 00:02:44 -0500
> Subject: [PATCH 1/4] gnu: openmpi: Add memchecker support
>
> * gnu/packages/mpi.scm (openmpi) [inputs]: Add valgrind.
>   [arguments]: Add configure flags for memchecker.

[...]

>      (native-inputs
>       `(("pkg-config" ,pkg-config)))
>      (propagated-inputs
> -     `(("gfortran" ,gfortran-4.8)))
> +     `(("gfortran" ,gfortran-4.8)
> +       ("valgrind" ,valgrind)))

Why is Valgrind propagated?  I would expect it to be used only in
Open MPI’s test suite, no?

(I also wonder why GFortran is propagated, probably overlooked it
before.)

Thanks,
Ludo’.

Re: [PATCH 1/4] gnu: openmpi: Add memchecker support

[Eric Bavier]

Ludovic Courtès writes:

> Eric Bavier <ericbavier@gmail.com> skribis:
>
>> From 3aaab98e3b9a0b1b893dd5bc64e098136364e717 Mon Sep 17 00:00:00 2001
>> From: Eric Bavier <bavier@member.fsf.org>
>> Date: Sat, 17 May 2014 00:02:44 -0500
>> Subject: [PATCH 1/4] gnu: openmpi: Add memchecker support
>>
>> * gnu/packages/mpi.scm (openmpi) [inputs]: Add valgrind.
>>   [arguments]: Add configure flags for memchecker.
>
> [...]
>
>>      (native-inputs
>>       `(("pkg-config" ,pkg-config)))
>>      (propagated-inputs
>> -     `(("gfortran" ,gfortran-4.8)))
>> +     `(("gfortran" ,gfortran-4.8)
>> +       ("valgrind" ,valgrind)))
>
> Why is Valgrind propagated?  I would expect it to be used only in
> OpenMPI’s test suite, no?

The intention of OpenMPI's memchecker option is to allow one to more
easily use valgrind when executing mpi programs.  That being said, it is
an optional feature, so it may not need to be propagated.  I'll look at
that again.

>
> (I also wonder why GFortran is propagated, probably overlooked it
> before.)

GFortran needs to be propagated for the OpenMPI compiler wrappers.

-- 
Eric Bavier

Re: [PATCH 1/4] gnu: openmpi: Add memchecker support

[Ludovic Courtès]

Eric Bavier <ericbavier@gmail.com> skribis:

> Ludovic Courtès writes:
>
>> Eric Bavier <ericbavier@gmail.com> skribis:
>>
>>> From 3aaab98e3b9a0b1b893dd5bc64e098136364e717 Mon Sep 17 00:00:00 2001
>>> From: Eric Bavier <bavier@member.fsf.org>
>>> Date: Sat, 17 May 2014 00:02:44 -0500
>>> Subject: [PATCH 1/4] gnu: openmpi: Add memchecker support
>>>
>>> * gnu/packages/mpi.scm (openmpi) [inputs]: Add valgrind.
>>>   [arguments]: Add configure flags for memchecker.
>>
>> [...]
>>
>>>      (native-inputs
>>>       `(("pkg-config" ,pkg-config)))
>>>      (propagated-inputs
>>> -     `(("gfortran" ,gfortran-4.8)))
>>> +     `(("gfortran" ,gfortran-4.8)
>>> +       ("valgrind" ,valgrind)))
>>
>> Why is Valgrind propagated?  I would expect it to be used only in
>> OpenMPI’s test suite, no?
>
> The intention of OpenMPI's memchecker option is to allow one to more
> easily use valgrind when executing mpi programs.  That being said, it is
> an optional feature, so it may not need to be propagated.  I'll look at
> that again.

But that still makes Valgrind optional when using Open MPI, no?  I would
not propagate it if it’s optional.

>> (I also wonder why GFortran is propagated, probably overlooked it
>> before.)
>
> GFortran needs to be propagated for the OpenMPI compiler wrappers.

OK.  I would not propagate it either because, suppose you just want to
use the library in a C program, then it doesn’t make sense to pull the
Fortran compiler.

WDYT?

Ludo’.