From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Thompson Subject: Re: [PATCH] gnu: Add unixodbs Date: Sun, 12 Oct 2014 08:12:21 -0400 Message-ID: <87ppdxa3mi.fsf@izanagi.i-did-not-set--mail-host-address--so-tickle-me> References: <1413097571-28002-1-git-send-email-jmd@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:52401) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XdI0p-0004Co-9V for guix-devel@gnu.org; Sun, 12 Oct 2014 08:12:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XdI0f-0004UV-R2 for guix-devel@gnu.org; Sun, 12 Oct 2014 08:12:35 -0400 Received: from na3sys009aog102.obsmtp.com ([74.125.149.69]:59661) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XdI0f-0004TR-Jl for guix-devel@gnu.org; Sun, 12 Oct 2014 08:12:25 -0400 Received: by mail-qc0-f175.google.com with SMTP id x13so3888384qcv.6 for ; Sun, 12 Oct 2014 05:12:24 -0700 (PDT) In-Reply-To: <1413097571-28002-1-git-send-email-jmd@gnu.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: guix-devel@gnu.org Cc: John Darrington Typo in the subject line: s/unixodbs/unixodbc/ John Darrington writes: > * gnu/packages/databases.scm (unixodbc): New variable. > --- > gnu/packages/databases.scm | 23 ++++++++++++++++++++++- > 1 file changed, 22 insertions(+), 1 deletion(-) > > diff --git a/gnu/packages/databases.scm b/gnu/packages/databases.scm > index a9ddef6..e9b2f9e 100644 > --- a/gnu/packages/databases.scm > +++ b/gnu/packages/databases.scm > @@ -35,7 +35,7 @@ > #:use-module (gnu packages gnupg) > #:use-module (gnu packages python) > #:use-module ((guix licenses) > - #:select (gpl2 gpl3+ lgpl3+ x11-style bsd-style > + #:select (gpl2 gpl3+ lgpl2.1+ lgpl3+ x11-style bsd-style > public-domain)) > #:use-module (guix packages) > #:use-module (guix download) > @@ -323,3 +323,24 @@ capable RDBMS working for your Perl project you simply have to install this > module, and nothing else.") > (license (package-license perl)) > (home-page "http://search.cpan.org/~ishigaki/DBD-SQLite/lib/DBD/SQLite.pm"))) > + > + > +(define-public unixodbc > + (package > + (name "unixodbc") > + (version "2.3.2") > + (source (origin > + (method url-fetch) > + (uri > + (string-append > + "ftp://ftp.unixodbc.org/pub/unixODBC/unixODBC-" version ".tar.gz")) > + (sha256 > + (base32 "16jw5fq7wgfky6ak1h2j2pqx99jivsdl4q8aq6immpr55xs5jd4w")))) > + (build-system gnu-build-system) > + (synopsis "Data source abstraction library") > + (description "Unixodbc is a library providing a > +API with which to access Data Sources. Data Sources include SQL > +Servers and any Data Source with an ODBC Driver.") This paragraph doesn't look wrapped properly. Also 'an API' not 'a API'. I don't think 'Data Sources' needs to be capitalized like that. > + (license lgpl2.1+) > + ;; COPYING contains copy of lgpl2.1 - but copyright notices just say "LGPL" > + (home-page "http://www.unixodbc.org"))) > -- > 1.7.10.4 > > Looks good to me, minus those few nitpicks. :) -- David Thompson Web Developer - Free Software Foundation - http://fsf.org GPG Key: 0FF1D807 Support the FSF: https://fsf.org/donate