From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Thompson <dthompson2@worcester.edu>
Subject: Re: [PATCH] Update ncmpcpp to v0.6.2
Date: Fri, 27 Feb 2015 11:18:02 -0500
Message-ID: <87pp8v8h1h.fsf@fsf.org>
References: <87sidrll19.fsf@denknerd.org> <87vbin8qo2.fsf@fsf.org>
	<87lhjj72p3.fsf@netris.org>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:32951)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <dthompson2@worcester.edu>) id 1YRNc5-0006Jz-P1
	for guix-devel@gnu.org; Fri, 27 Feb 2015 11:18:06 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <dthompson2@worcester.edu>) id 1YRNc3-0005uc-SP
	for guix-devel@gnu.org; Fri, 27 Feb 2015 11:18:05 -0500
Received: from mail.fsf.org ([208.118.235.13]:36488)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <dthompson2@worcester.edu>) id 1YRNc3-0005uO-OD
	for guix-devel@gnu.org; Fri, 27 Feb 2015 11:18:03 -0500
In-Reply-To: <87lhjj72p3.fsf@netris.org>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Mark H Weaver <mhw@netris.org>
Cc: Guix-devel <guix-devel@gnu.org>

Mark H Weaver <mhw@netris.org> writes:

> David Thompson <dthompson2@worcester.edu> writes:
>
>> Paul van der Walt <paul@denknerd.org> writes:
> [...]
>>> +    (arguments
>>> +     '(#:configure-flags
>>> +       '("BOOST_LIB_SUFFIX=")
>>> +       #:phases
>>> +       (alist-cons-after
>>> +        'unpack 'autogen
>>> +        (lambda _
>>> +          (substitute* "autogen.sh"
>>> +            (("/bin/sh") (which "bash")))
>>
>> Is "autogen.sh" not executable?  If it starts with a shebang, Guix
>> should patch the file appropriately.
>
> The problem here is that this 'autogen' phase is run before the
> 'patch-source-shebangs' phase, at my suggestion.  It has to be that way,
> because 'patch-source-shebangs' (and 'patch-usr-bin-file') will need to
> be run on the files created by 'autogen.sh'.

Oh, okay.  Right.  Thanks for explaining.

>
>>> +          (setenv "NOCONFIGURE" "true")
>>> +          (zero? (system* "bash" "autogen.sh")))
>>
>> If its executable, you can say:
>>
>>     (zero? (system* "./autogen.sh"))
>
> Yes, after the 'substitute*' above, this should presumably work.  My
> guess is that Paul added the "bash" here before he realized that he
> also needed the 'substitute*'.

Makes sense.

-- 
David Thompson
Web Developer - Free Software Foundation - http://fsf.org
GPG Key: 0FF1D807
Support the FSF: https://fsf.org/donate