all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: taylanbayirli@gmail.com (Taylan Ulrich Bayırlı/Kammer)
To: guix-devel@gnu.org
Subject: [PATCH] tests: Use '.' and not 'source' which is a Bashism.
Date: Wed, 06 May 2015 20:18:47 +0200	[thread overview]
Message-ID: <87pp6dk1rs.fsf@taylan.uni.cx> (raw)

[-- Attachment #1: Type: text/plain, Size: 104 bytes --]

I assume the test is supposed to run with any standards compliant shell
and not specifically GNU Bash:


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-tests-Use-.-and-not-source-which-is-a-Bashism.patch --]
[-- Type: text/x-diff, Size: 1061 bytes --]

From 45b02e923e835569c47e4e5b4dd6972ac402a74e Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Taylan=20Ulrich=20Bay=C4=B1rl=C4=B1/Kammer?=
 <taylanbayirli@gmail.com>
Date: Wed, 6 May 2015 20:13:31 +0200
Subject: [PATCH] tests: Use '.' and not 'source' which is a Bashism.

* tests/profiles.scm ("etc/profile"): Use '.' instead of 'source', since the
  latter is a Bashism and not necessarily supported by a standard shell.
---
 tests/profiles.scm | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/tests/profiles.scm b/tests/profiles.scm
index a397171..93801a0 100644
--- a/tests/profiles.scm
+++ b/tests/profiles.scm
@@ -237,8 +237,7 @@
     (mbegin %store-monad
       (built-derivations (list drv))
       (let* ((pipe (open-input-pipe
-                    (string-append "source "
-                                   profile "/etc/profile; "
+                    (string-append ". " profile "/etc/profile; "
                                    "unset GUIX_PROFILE; set")))
              (env  (get-string-all pipe)))
         (return
-- 
2.2.1


             reply	other threads:[~2015-05-06 18:19 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-06 18:18 Taylan Ulrich Bayırlı/Kammer [this message]
2015-05-06 19:32 ` [PATCH] tests: Use '.' and not 'source' which is a Bashism John Darrington
2015-05-06 20:08   ` Taylan Ulrich Bayırlı/Kammer
2015-05-06 20:17     ` Ludovic Courtès
2015-05-06 20:36       ` Taylan Ulrich Bayırlı/Kammer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87pp6dk1rs.fsf@taylan.uni.cx \
    --to=taylanbayirli@gmail.com \
    --cc=guix-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.