From mboxrd@z Thu Jan  1 00:00:00 1970
From: Alex Kost <alezost@gmail.com>
Subject: Re: [PATCH 2/4] build: Produce 'guix-config' instead of using
	compile-time tricks.
Date: Wed, 29 Jul 2015 11:35:57 +0300
Message-ID: <87pp3bl5si.fsf@gmail.com>
References: <1438033720-30958-1-git-send-email-mthl@openmailbox.org>
	<1438033720-30958-3-git-send-email-mthl@openmailbox.org>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:53746)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alezost@gmail.com>) id 1ZKMqI-0003sE-LQ
	for guix-devel@gnu.org; Wed, 29 Jul 2015 04:36:03 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <alezost@gmail.com>) id 1ZKMqF-0007yM-En
	for guix-devel@gnu.org; Wed, 29 Jul 2015 04:36:02 -0400
Received: from mail-lb0-x22e.google.com ([2a00:1450:4010:c04::22e]:34060)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alezost@gmail.com>) id 1ZKMqE-0007xz-Ss
	for guix-devel@gnu.org; Wed, 29 Jul 2015 04:35:59 -0400
Received: by lbbst4 with SMTP id st4so1840424lbb.1
	for <guix-devel@gnu.org>; Wed, 29 Jul 2015 01:35:57 -0700 (PDT)
In-Reply-To: <1438033720-30958-3-git-send-email-mthl@openmailbox.org> (Mathieu
	Lirzin's message of "Mon, 27 Jul 2015 23:48:38 +0200")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Mathieu Lirzin <mthl@openmailbox.org>
Cc: guix-devel@gnu.org

Mathieu Lirzin (2015-07-28 00:48 +0300) wrote:

[...]
> +(defconst guix-prefix
> +  "@prefix@")
> +
> +(defconst guix-emacs-ui-dir
> +  "@emacsuidir@")

I think this constant is useless in this form since its value will be
"${prefix}/share/guile/site/2.0/guix/emacs".  What about making it:

(defconst guix-emacs-ui-dir
  (replace-regexp-in-string "${prefix}" guix-prefix "@emacsuidir@"))

And to leave:

(defvar guix-load-path guix-emacs-ui-dir
  "Directory with scheme files for \"guix.el\" package.")

in "guix-backend.el"?

> +
> +(defconst guix-local-state-dir
> +  "@guix_localstatedir@"oo)
> +
> +(provide 'guix-config)
> +
> +;;; guix-config.el ends here
> diff --git a/emacs/guix-init.el b/emacs/guix-init.el
> new file mode 100644
> index 0000000..353bb27
> --- /dev/null
> +++ b/emacs/guix-init.el
> @@ -0,0 +1,20 @@
> +(require 'guix-config)

I think requiring 'guix-config' is not needed in "guix-init.el".

The rest looks good to me.

-- 
Alex