From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ricardo Wurmus Subject: Re: [PATCH] Update enlightenment.scm: Add Rage Player Date: Thu, 06 Aug 2015 16:24:22 +0200 Message-ID: <87pp30pka1.fsf@elephly.net> References: <87oailvn9g.fsf@elephly.net> <1d73da04df0affa581dbaeead8cb3f35@openmailbox.org> <87mvy5vmb0.fsf@elephly.net> <819f4e78a9c6821d32334d9e457aec33@openmailbox.org> <7c16d9a37b86038dfbb836b31bd7c8e6@openmailbox.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:46481) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZNM62-0003nl-E4 for guix-devel@gnu.org; Thu, 06 Aug 2015 10:24:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZNM61-0001QJ-Ep for guix-devel@gnu.org; Thu, 06 Aug 2015 10:24:38 -0400 In-reply-to: <7c16d9a37b86038dfbb836b31bd7c8e6@openmailbox.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Daniel Pimentel Cc: guix-devel@gnu.org, guix-devel-bounces+d4n1=opmbx.org@gnu.org Thanks for the updated patch! > * gnu/packages/enlightenment.scm: Add Rage. This should really be: * gnu/packages/enlightenment.scm (rage): New variable. Other than that I have no important objections. I think this looks ugly and could be improved, but I don’t think it’s very important: > + (uri > + (string-append > + "http://download.enlightenment.org/rel/apps/rage/rage-" > + version ".tar.gz")) I’d put “(uri (string-append ...” on the same line, pull part of the string onto the same line and align the rest accordingly. But I better leave the comments and the final decision to someone else. ~~ Ricardo