From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark H Weaver Subject: Re: [PATCH] guix: lint: Check for version-only origin file names. Date: Mon, 24 Aug 2015 19:02:11 -0400 Message-ID: <87pp2cmgss.fsf@netris.org> References: <1440371134-2699-1-git-send-email-ericbavier@openmailbox.org> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:48340) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZU0lH-000083-OO for guix-devel@gnu.org; Mon, 24 Aug 2015 19:02:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZU0lE-0006T6-Cg for guix-devel@gnu.org; Mon, 24 Aug 2015 19:02:43 -0400 Received: from world.peace.net ([50.252.239.5]:55861) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZU0lE-0006Sx-9S for guix-devel@gnu.org; Mon, 24 Aug 2015 19:02:40 -0400 In-Reply-To: <1440371134-2699-1-git-send-email-ericbavier@openmailbox.org> (ericbavier@openmailbox.org's message of "Sun, 23 Aug 2015 18:05:34 -0500") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: ericbavier@openmailbox.org Cc: guix-devel@gnu.org, Eric Bavier ericbavier@openmailbox.org writes: > From: Eric Bavier > > * guix/scripts/lint.scm (check-source): Emit warning if source filename > contains only the version of the package. This is not a proper review, but I just wanted to add that another common case is for the filename to start with "v" followed by the version number, e.g. "v3.2.0.tar.gz", so it would be good to check for that too. If you search for the string '/v"' in gnu/packages/*.scm you'll find a great many examples. Thank you for working on it! Mark