From: ludo@gnu.org (Ludovic Courtès)
To: Leo Famulari <leo@famulari.name>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH 0/1] Add lz4 (C implementation)
Date: Sun, 13 Sep 2015 12:10:21 +0200 [thread overview]
Message-ID: <87pp1m7hpu.fsf@gnu.org> (raw)
In-Reply-To: <cover.1441832565.git.leo@famulari.name> (Leo Famulari's message of "Wed, 9 Sep 2015 17:04:11 -0400")
Leo Famulari <leo@famulari.name> skribis:
> I'm looking for advice regarding the tests. The tests take >30 minutes on my on
> my quad-core i5 with 8 gigabytes of RAM and they require Valgrind as a
> native-input. This seems excessive to me but if users install binary
> substitutes, they won't run the tests or need to install Valgrind, right? And
> if distributions won't test software, then who will?
Indeed, I think it’s fine. As Taylan noted, there are already several
cases of long test suites.
> + (name "lz4")
> + (version "r131")
I changed that to “131”, which conforms to the expectations of what a
version number is. For instance:
--8<---------------cut here---------------start------------->8---
scheme@(guile-user)> (package-name->name+version "lz4-r131")
$3 = "lz4-r131"
$4 = #f
scheme@(guile-user)> (package-name->name+version "lz4-131")
$5 = "lz4"
$6 = "131"
--8<---------------cut here---------------end--------------->8---
> + (origin
> + (method url-fetch)
> + (uri (string-append "https://github.com/Cyan4973/lz4/archive/"
> + version ".tar.gz"))
> + (sha256
> + (base32 "1vfg305zvj50hwscad24wan9jar6nqj14gdk2hqyr7bb9mhh0kcx"))))
Added a ‘file-name’ field here so we get “lz4-131.tar.gz” instead of
“r131.tar.gz” (this is purely cosmetic; no functional change.)
Thanks!
Ludo’.
prev parent reply other threads:[~2015-09-13 10:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-09 21:04 [PATCH 0/1] Add lz4 (C implementation) Leo Famulari
2015-09-09 21:04 ` [PATCH 1/1] gnu: Add lz4 Leo Famulari
2015-09-09 21:26 ` [PATCH 0/1] Add lz4 (C implementation) Taylan Ulrich Bayırlı/Kammer
2015-09-09 22:16 ` Leo Famulari
2015-09-13 10:10 ` Ludovic Courtès [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pp1m7hpu.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=guix-devel@gnu.org \
--cc=leo@famulari.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.